This reverts commit d9d08a28.

Add two pointer functions rather than doing a condition.
The functions choose to update the cdf function are set
during the msac_init function.

Required to be able to use pmaddubsw without overflow in the x86 SIMD.

Total decoding time for first 1000 frames of TwxVOYxoukU:
after: 0m3.761s
before: 0m6.868s

Cycle times:
selfguided_3x3_8bpc_c: 438865.8
selfguided_3x3_8bpc_avx2: 112522.6
selfguided_5x5_8bpc_c: 326938.3
selfguided_5x5_8bpc_avx2: 75850.1
selfguided_mix_8bpc_c: 755980.5
selfguided_mix_8bpc_avx2: 195930.3

- remove unused entry from tables.h;
- use non-sized types for scalar values;
- reduce size of intermediate tables from int32 to int16.

Use the fact that the count is at most 32.
Also, apply the same in msac_decode_bool_adapt.

Isolate the MsacContext structure build inside the msac_init function for a cleaner code.

Update the cdf function on each frame and tiles only when disable_cdf_update is false.
When an av1 video is encoded with aomenc, you have the possibility to disable the update
of cdf function with the 'cdf-update-mode' argument.

Replace it with the version used in dav1d_fuzzer to avoid an integer
promotion.

Fixes ubsan index-out-of-bounds error in loop_filter_v_sb128y_c() with
clusterfuzz-testcase-minimized-dav1d_fuzzer-5691087507685376. Credits to
oss-fuzz.

This makes the process exit codes more sensible when failing
verification; when there's a mismatch, memcmp returns the difference
between the two first differing bytes, which can fall outside of the
range of normal exit codes, into the range of exit codes used when
terminated by a signal.

Janne Grunau authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

For example in dav1d_cdef_brow_{8,10}bpc memory sanitizer can not track
that variance is initilized by dsp->cdef.dir() it is implemented by in
asm.

Manually define the necessary HWCAP if sys/auxv.h didn't define
it. (It isn't defined in the Android NDK, one has to include
asm/hwcap.h to get definitions of them. Additionally, the aarch64
cross libc headers in Ubuntu 16.04 lacked HWCAP definitions from
sys/auxv.h, also present in asm/hwcap.h. Ubuntu 16.04's armhf
cross libc headers did however define HWCAP values in sys/auxv.h.)

Don't use any detection at all for NEON on aarch64, since it is a
mandatory feature there. On WSL on Windows 10 1803 arm64,
getauxval(AT_HWCAP) returns 0.

Fixes compilation error on implicitly declared malloc()/free()
due to missing this header. Alphabetizes headers for style too.

Signed-off-by: Dale Curtis <dalecurtis@chromium.org>

posix_memalign is not available in Android <= 4.1 (API level 16 and
below). Fixes #140

Fixes #134.

Janne Grunau authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

For Linux (and Android) use getauxval(). For ios and windows on arm
assume NEON is available.

Janne Grunau authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

Fix 136.

Test case clusterfuzz-testcase-minimized-dav1d_fuzzer-5744823991009280
credits to oss-fuzz. Fix #129.

This reverts commit aeb5a5ef.