Use the same timeout for the RTSP connection as for the RTSP session.
A shorter timeout is inefficient, as it requires clients to reconnect
to refresh the session anyway. A longer timeout is pointless as the
session would timeout and the RTP streams would stop regardless of the
connection staying alive.

Refs #25812.

(cherry picked from commit 38d214bc)

Refs #25812.

(cherry picked from commit ce3269d4)

This should not make any functional differences.

Refs #25812.

(cherry picked from commit 2fd2b843)

On macOS Sierra and higher, we will use the official API to enable
control of VLC, which will always be enabled as potential conflicts are
mitigated by the OS and it is possible to control more than one
application at the same time, so the option is ignored. On earlier
releases of macOS, SPMediaKeyTap can still be optionally disabled.

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

(cherry picked from commit ae6af400)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

the item pointer provided to the constructor is that of a single hotkey
config item. using the longtext from this item in a tooltip on the label
for the entire hotkey table makes zero sense, so let's remove it.

 - for the table shown in the simple view, the "key-play" option was
   arbitrarily used for this.
 - for the table shown in the advanced view, the text from the first
   hotkey config item encountered was used.

(cherry picked from commit b0385e93)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

(cherry picked from commit b407307b)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

With module selection controls which feature a groupbox of module
checkboxes, if individual modules have their own longtext, that is
displayed in a tooltip when hovering on them; for all others, the help
text for the entire control (groupbox) gets displayed, which is just
confusing from a UX point of view.

This removes the general groupbox tooltip, thus fixing this.

It remains for the textbox portion of the control however, so hovering over
that still provides the helptext!

(cherry picked from commit e85dd955)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

if a panel only has one groupbox and it is empty, it was hidden, but
otherwise they were shown; this was surely a bug, and at any rate is
undesirably messy. all empty groupboxes are now hidden.

an example case: this fixes the empty "Performance options" groupbox (on
my system) under the top-level "Advanced" tree node in the advanced
preferences view, which happens to be very visible as the first panel
shown when switching to advanced mode.

(cherry picked from commit 92145903)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

the capability is "sub source" not "spu source"

this mistake came from 1f5744e9.

(cherry picked from commit afc593fb)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

Certain sets of options in the core option set use a cat/subcat of -1 as
a "hack" to avoid those options showing up in the GUI prefs set. This is
the case for options like --help for instance. While the Qt GUI plugin
respects this, the MacOSX one was missing checks for this, and so surely
(I don't have a mac so I can't look and see) it was including them when
it shouldn't.

(cherry picked from commit 05e2f75a)

was mistakenly using shorttext instead of the defined longtext.

(cherry picked from commit a0a76660)

This option should be using DEADZONE_INTER_LONGTEXT instead of
DEADZONE_INTRA_LONGTEXT.

(cherry picked from commit 50e23501)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

(cherry picked from commit 886824ab)

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

If ID3D11DeviceContext4 is not found we should not release is when we call the
error cleanup.


(cherry picked from commit 719dd732)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

(cherry picked from commit 546d0210)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

(cherry picked from commit 8aeef92e)

Felix Paul Kühne authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

On later releases, we will use the public API.

Felix Paul Kühne authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Previously, external apps such as the Touchbar and AppleScript bindings
could attempt to seek non-seekable content leading to persistent silence
until playback was restarted.

Felix Paul Kühne authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This implements playback control via touch bar and the activity widgets.
It also exposes related playback meta data. It is a manual backport of
the respective code on the master branch and fixes #25744.

Quoting mpg123.de website:

"Fix misguided handling of part2_3_length checks in
III_get_scale_factors_1() and III_get_scale_factors_2() which
invalidated decoding of a mono source encoded as ms+i-stereo.
This was a regression introduced with version 1.25.7."

Fixes #25798

(cherry picked from commit 62bf14a8)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

options need to be specified after the cat+subcat declarations otherwise
they may be ignored when constructing the preferences tree in Qt (and
possibly others).

(cherry picked from commit 92654192)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

not having a cat+subcat specified means that the options were ignored
when constructing the preferences tree in Qt (and possibly others).

(cherry picked from commit bc6700f7)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

not having a cat+subcat specified means that the options were ignored
when constructing the preferences tree in Qt (and possibly others).

(cherry picked from commit 90e1fe40)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

not having a cat+subcat specified means that the options were ignored
when constructing the preferences tree in Qt (and possibly others).

(cherry picked from commit f9b5677a)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

fixes problem of option not being shown in GUI

(cherry picked from commit 73e00de6)

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

(cherry picked from commit 801dc62e)

Martin Storsjö authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This fixes building with the very latest nightly of Clang.

(cherry picked from commit 37cdeb67)

Jean-Baptiste Kempf authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Close #23602

(cherry picked from commit e411f5f9)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Petri Hintukainen authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

(cherry picked from commit 262b5460)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

some transmit empty <50 bytes data object

(cherry picked from commit 4ae85635e5998d1b386b834ad22586e807d60969)

Brad Smith authored 3 years ago and Thomas Guillem committed 3 years ago

Set volume/mute function pointers when handle is freed, to ensure
sio_setvol() is not called on a freed handle. Fixes crashes when volume
is adjusted while playback is stopped.

Fixes #25796

(cherry picked from commit e94b04c8)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>