GitLab

Signed-off-by: Ludovic Fauvet <etix@videolan.org>

According to the documentation the implementation of these lifecycle
methods must always call the superclass implementation before doing any
work.

https://developer.android.com/guide/components/activities.html#ImplementingLifecycleCallbacks

If for any reason we don't reach the end of the onCreate() the
thumbnailer may not be instantiated.

Since we are using fragments the search is handled by the mainactivity.

This may fix the following crash:

java.lang.IllegalStateException: Fragment VideoListFragment{4130f1f0} not attached to Activity
at android.support.v4.app.Fragment.getResources(Fragment.java:555)
at org.videolan.vlc.betav7neon.ThumbnailerManager.run(ThumbnailerManager.java:113)
at java.lang.Thread.run(Thread.java:856)

    and correct vocabulary in a FIXME comment for a previous commit
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Using the proper method makes it work. Oops...

The barrier needs to be reset after an InterruptedException, but sadly
we can't do that safely in the catch block. And because doing a reset on
a sane barrier is perfectly valid we'll do it at the beginning of each
loop.

Wait for the preferences to be reviewed and validated by the user.