Skip to content

GitLab

Commit cb6a40f0 authored by Loren Merritt's avatar Loren Merritt
Browse files

macroblock_analyse: simplify cost comparisons. (cosmetic) 

CLI: enable cabac by default.


git-svn-id: svn://svn.videolan.org/x264/trunk@172 df754926-b1dd-0310-bc7b-ec298dee348c
parent 79fa6945
Hide whitespace changes
Inline Side-by-side
encoder/analyse.c
View file @ cb6a40f0
......@@ -171,9 +171,9 @@ static void x264_mb_analyse_init( x264_t *h, x264_mb_analysis_t *a, int i_qp )
&& h->mb.i_subpel_refine >= 5;
/* I: Intra part */
a->i_sad_i16x16 = -1;
a->i_sad_i4x4 = -1;
a->i_sad_i8x8 = -1;
a->i_sad_i16x16 =
a->i_sad_i4x4 =
a->i_sad_i8x8 = COST_MAX;
/* II: Inter part P/B frame */
if( h->sh.i_type != SLICE_TYPE_I )
......@@ -196,39 +196,39 @@ static void x264_mb_analyse_init( x264_t *h, x264_mb_analysis_t *a, int i_qp )
}
#undef CLIP_FMV
a->l0.me16x16.cost = -1;
a->l0.i_cost8x8 = -1;
a->l0.me16x16.cost =
a->l0.i_cost8x8 = COST_MAX;
for( i = 0; i < 4; i++ )
{
a->l0.i_cost4x4[i] = -1;
a->l0.i_cost8x4[i] = -1;
a->l0.i_cost4x8[i] = -1;
a->l0.i_cost4x4[i] =
a->l0.i_cost8x4[i] =
a->l0.i_cost4x8[i] = COST_MAX;
}
a->l0.i_cost16x8 = -1;
a->l0.i_cost8x16 = -1;
a->l0.i_cost16x8 =
a->l0.i_cost8x16 = COST_MAX;
if( h->sh.i_type == SLICE_TYPE_B )
{
a->l1.me16x16.cost = -1;
a->l1.i_cost8x8 = -1;
a->l1.me16x16.cost =
a->l1.i_cost8x8 = COST_MAX;
for( i = 0; i < 4; i++ )
{
a->l1.i_cost4x4[i] = -1;
a->l1.i_cost8x4[i] = -1;
a->l1.i_cost4x8[i] = -1;
a->i_cost8x8direct[i] = -1;
a->l1.i_cost4x4[i] =
a->l1.i_cost8x4[i] =
a->l1.i_cost4x8[i] =
a->i_cost8x8direct[i] = COST_MAX;
}
a->l1.i_cost16x8 = -1;
a->l1.i_cost8x16 = -1;
a->l1.i_cost16x8 =
a->l1.i_cost8x16 =
a->i_cost16x16bi = -1;
a->i_cost16x16direct = -1;
a->i_cost8x8bi = -1;
a->i_cost16x8bi = -1;
a->i_cost8x16bi = -1;
a->i_cost16x16bi =
a->i_cost16x16direct =
a->i_cost8x8bi =
a->i_cost16x8bi =
a->i_cost8x16bi = COST_MAX;
}
}
}
......@@ -398,7 +398,7 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *res )
i_sad = h->pixf.satd[PIXEL_16x16]( p_dst, i_stride, p_src, i_stride ) +
res->i_lambda * bs_size_ue( x264_mb_pred_mode16x16_fix[i_mode] );
/* if i_score is lower it is better */
if( res->i_sad_i16x16 == -1 || res->i_sad_i16x16 > i_sad )
if( res->i_sad_i16x16 > i_sad )
{
res->i_predict16x16 = i_mode;
res->i_sad_i16x16 = i_sad;
......@@ -427,7 +427,7 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *res )
p_src_by = p_src + 4 * x + 4 * y * i_stride;
p_dst_by = p_dst + 4 * x + 4 * y * i_stride;
i_best = -1;
i_best = COST_MAX;
predict_4x4_mode_available( h->mb.i_neighbour, idx, predict_mode, &i_max );
for( i = 0; i < i_max; i++ )
{
......@@ -446,7 +446,7 @@ static void x264_mb_analyse_intra( x264_t *h, x264_mb_analysis_t *res )
i_sad += res->i_lambda * (i_pred_mode == x264_mb_pred_mode4x4_fix[i_mode] ? 1 : 4);
/* if i_score is lower it is better */
if( i_best == -1 || i_best > i_sad )
if( i_best > i_sad )
{
res->i_predict4x4[x][y] = i_mode;
i_best = i_sad;
......@@ -478,7 +478,7 @@ static void x264_mb_analyse_intra_chroma( x264_t *h, x264_mb_analysis_t *res )
uint8_t *p_dstc[2], *p_srcc[2];
int i_stride[2];
if( res->i_sad_i8x8 >= 0 )
if( res->i_sad_i8x8 < COST_MAX )
return;
/* 8x8 prediction selection for chroma */
......@@ -491,7 +491,7 @@ static void x264_mb_analyse_intra_chroma( x264_t *h, x264_mb_analysis_t *res )
i_stride[1] = h->mb.pic.i_stride[2];
predict_8x8_mode_available( h->mb.i_neighbour, predict_mode, &i_max );
res->i_sad_i8x8 = -1;
res->i_sad_i8x8 = COST_MAX;
for( i = 0; i < i_max; i++ )
{
int i_sad;
......@@ -511,7 +511,7 @@ static void x264_mb_analyse_intra_chroma( x264_t *h, x264_mb_analysis_t *res )
res->i_lambda * bs_size_ue( x264_mb_pred_mode8x8_fix[i_mode] );
/* if i_score is lower it is better */
if( res->i_sad_i8x8 == -1 || res->i_sad_i8x8 > i_sad )
if( res->i_sad_i8x8 > i_sad )
{
res->i_predict8x8 = i_mode;
res->i_sad_i8x8 = i_sad;
......@@ -1112,7 +1112,7 @@ static void x264_mb_analyse_inter_b8x8( x264_t *h, x264_mb_analysis_t *a )
i_part_cost = i_part_cost_bi;
h->mb.i_sub_partition[i] = D_BI_8x8;
}
if( a->i_cost8x8direct[i] < i_part_cost && a->i_cost8x8direct[i] >= 0)
if( a->i_cost8x8direct[i] < i_part_cost )
{
i_part_cost = a->i_cost8x8direct[i];
h->mb.i_sub_partition[i] = D_DIRECT_8x8;
......@@ -1291,7 +1291,7 @@ void x264_macroblock_analyse( x264_t *h )
{
x264_mb_analyse_intra( h, &analysis );
if( analysis.i_sad_i4x4 >= 0 && analysis.i_sad_i4x4 < analysis.i_sad_i16x16 )
if( analysis.i_sad_i4x4 < analysis.i_sad_i16x16 )
h->mb.i_type = I_4x4;
else
h->mb.i_type = I_16x16;
......@@ -1465,24 +1465,23 @@ void x264_macroblock_analyse( x264_t *h )
x264_mb_analyse_intra( h, &analysis );
if( h->mb.b_chroma_me &&
( analysis.i_sad_i16x16 < i_cost
|| ( analysis.i_sad_i4x4 < i_cost && analysis.i_sad_i4x4 >= 0 )))
|| ( analysis.i_sad_i4x4 < i_cost )))
{
x264_mb_analyse_intra_chroma( h, &analysis );
analysis.i_sad_i16x16 += analysis.i_sad_i8x8;
if( analysis.i_sad_i4x4 >= 0 )
analysis.i_sad_i4x4 += analysis.i_sad_i8x8;
analysis.i_sad_i4x4 += analysis.i_sad_i8x8;
}
i_intra_type = I_16x16;
i_intra_cost = analysis.i_sad_i16x16;
if( analysis.i_sad_i4x4 >=0 && analysis.i_sad_i4x4 < i_intra_cost )
if( analysis.i_sad_i4x4 < i_intra_cost )
{
i_intra_type = I_4x4;
i_intra_cost = analysis.i_sad_i4x4;
}
if( i_intra_cost >= 0 && i_intra_cost < i_cost )
if( i_intra_cost < i_cost )
{
h->mb.i_type = i_intra_type;
i_cost = i_intra_cost;
......@@ -1535,7 +1534,7 @@ void x264_macroblock_analyse( x264_t *h )
h->mb.i_type = B_BI_BI;
i_cost = analysis.i_cost16x16bi;
}
if( analysis.i_cost16x16direct < i_cost && analysis.i_cost16x16direct >= 0 )
if( analysis.i_cost16x16direct < i_cost )
{
h->mb.i_type = B_DIRECT;
i_cost = analysis.i_cost16x16direct;
......@@ -1659,12 +1658,12 @@ void x264_macroblock_analyse( x264_t *h )
/* best intra mode */
x264_mb_analyse_intra( h, &analysis );
if( analysis.i_sad_i16x16 >= 0 && analysis.i_sad_i16x16 < i_cost )
if( analysis.i_sad_i16x16 < i_cost )
{
h->mb.i_type = I_16x16;
i_cost = analysis.i_sad_i16x16;
}
if( analysis.i_sad_i4x4 >=0 && analysis.i_sad_i4x4 < i_cost )
if( analysis.i_sad_i4x4 < i_cost )
{
h->mb.i_type = I_4x4;
i_cost = analysis.i_sad_i4x4;
......
encoder/me.c
View file @ cb6a40f0
......@@ -83,7 +83,7 @@ void x264_me_search_ref( x264_t *h, x264_me_t *m, int (*mvc)[2], int i_mvc, int
* them yourself */
bmx = x264_clip3( ( m->mvp[0] + 2 ) >> 2, mv_x_min, mv_x_max );
bmy = x264_clip3( ( m->mvp[1] + 2 ) >> 2, mv_y_min, mv_y_max );
bcost = 1<<30;
bcost = COST_MAX;
COST_MV( bmx, bmy );
/* I don't know why this helps */
bcost -= p_cost_mvx[ bmx<<2 ] + p_cost_mvy[ bmy<<2 ];
......@@ -239,7 +239,7 @@ static void refine_subpel( x264_t *h, x264_me_t *m, int hpel_iters, int qpel_ite
{
for( i = step>1 ? hpel_iters : qpel_iters; i > 0; i-- )
{
int bcost = 1<<30;
int bcost = COST_MAX;
int bdir = 0;
COST_MV( bmx, bmy - step, 0 );
COST_MV( bmx, bmy + step, 1 );
......
encoder/me.h
View file @ cb6a40f0
......@@ -24,6 +24,8 @@
#ifndef _ME_H
#define _ME_H 1
#define COST_MAX (1<<28)
typedef struct
{
/* input */
......
x264.c
View file @ cb6a40f0
......@@ -100,7 +100,6 @@ int main( int argc, char **argv )
#endif
x264_param_default( &param );
param.b_cabac = 0;
/* Parse command line */
if( Parse( argc, argv, &param, &hin, &fout, &b_decompress ) < 0 )
......@@ -138,7 +137,7 @@ static void Help( x264_param_t *defaults )
" --b-bias <integer> Influences how often B-frames are used [%d]\n"
" --b-pyramid Keep some B-frames as references\n"
"\n"
" -c, --cabac Enable CABAC\n"
" --no-cabac Disable CABAC\n"
" -r, --ref <integer> Number of reference frames [%d]\n"
" -n, --nf Disable loop filter\n"
" -f, --filter <alpha:beta> Loop filter AplhaCO and Beta parameters [%d]\n"
......@@ -263,6 +262,7 @@ static int Parse( int argc, char **argv,
#define OPT_BPYRAMID 279
#define OPT_CHROMA_QP 280
#define OPT_NO_CHROMA_ME 281
#define OPT_NO_CABAC 282
static struct option long_options[] =
{
......@@ -277,7 +277,7 @@ static int Parse( int argc, char **argv,
{ "scenecut",required_argument, NULL, OPT_SCENECUT },
{ "nf", no_argument, NULL, 'n' },
{ "filter", required_argument, NULL, 'f' },
{ "cabac", no_argument, NULL, 'c' },
{ "no-cabac",no_argument, NULL, OPT_NO_CABAC },
{ "qp", required_argument, NULL, 'q' },
{ "qpmin", required_argument, NULL, OPT_QPMIN },
{ "qpmax", required_argument, NULL, OPT_QPMAX },
......@@ -383,8 +383,8 @@ static int Parse( int argc, char **argv,
case 'r':
param->i_frame_reference = atoi( optarg );
break;
case 'c':
param->b_cabac = 1;
case OPT_NO_CABAC:
param->b_cabac = 0;
break;
case 'x':
*pb_decompress = 1;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

VideoLAN code repository instance