• Fiona Glaser's avatar
    Fix regression in r736 · d4e07786
    Fiona Glaser authored
    r736 added intra RD refinement to B-frames; however, it is possible for subme=7 to be used without b-rdo.
    This means intra RD isn't run, and therefore it is possible for intra chroma analysis to not have been run, since update_cache was never called for an intra block, and chroma ME is not required even at subme=7.
    r801, which removed a memset, made this worse because previously the chroma prediction mode was at least initialized to zero; now it was not initialized at all.
    Therefore, --no-chroma-me, --subme 7, and no --b-rdo had the potential to crash.
    This change restricts intra RD refinement to only be run when --b-rdo is enabled (sensible to begin with), thus preventing a crash in this case.
    d4e07786
analyse.c 99.2 KB