Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
7
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Open sidebar
VideoLAN
VLMC
Commits
c5e1fbbe
Commit
c5e1fbbe
authored
Feb 16, 2014
by
Hugo Beauzée-Luyssen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
PreviewWidget: Remove differentiation between stopped & endReached
parent
6be90ad2
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
4 additions
and
35 deletions
+4
-35
src/Gui/preview/PreviewWidget.cpp
src/Gui/preview/PreviewWidget.cpp
+1
-12
src/Gui/preview/PreviewWidget.h
src/Gui/preview/PreviewWidget.h
+0
-2
src/Gui/preview/ui/PreviewWidget.ui
src/Gui/preview/ui/PreviewWidget.ui
+1
-10
src/Renderer/ClipRenderer.cpp
src/Renderer/ClipRenderer.cpp
+0
-1
src/Renderer/GenericRenderer.h
src/Renderer/GenericRenderer.h
+0
-8
src/Renderer/WorkflowRenderer.cpp
src/Renderer/WorkflowRenderer.cpp
+2
-2
No files found.
src/Gui/preview/PreviewWidget.cpp
View file @
c5e1fbbe
...
@@ -87,7 +87,6 @@ PreviewWidget::setRenderer( GenericRenderer *renderer )
...
@@ -87,7 +87,6 @@ PreviewWidget::setRenderer( GenericRenderer *renderer )
connect
(
m_renderer
,
SIGNAL
(
playing
()
),
this
,
SLOT
(
videoPlaying
()
)
);
connect
(
m_renderer
,
SIGNAL
(
playing
()
),
this
,
SLOT
(
videoPlaying
()
)
);
connect
(
m_renderer
,
SIGNAL
(
frameChanged
(
qint64
,
Vlmc
::
FrameChangedReason
)
),
connect
(
m_renderer
,
SIGNAL
(
frameChanged
(
qint64
,
Vlmc
::
FrameChangedReason
)
),
this
,
SLOT
(
frameChanged
(
qint64
,
Vlmc
::
FrameChangedReason
)
)
);
this
,
SLOT
(
frameChanged
(
qint64
,
Vlmc
::
FrameChangedReason
)
)
);
connect
(
m_renderer
,
SIGNAL
(
endReached
()
),
this
,
SLOT
(
endReached
()
)
);
connect
(
m_ui
->
rulerWidget
,
SIGNAL
(
frameChanged
(
qint64
,
Vlmc
::
FrameChangedReason
)
),
connect
(
m_ui
->
rulerWidget
,
SIGNAL
(
frameChanged
(
qint64
,
Vlmc
::
FrameChangedReason
)
),
m_renderer
,
SLOT
(
previewWidgetCursorChanged
(
qint64
)
)
);
m_renderer
,
SLOT
(
previewWidgetCursorChanged
(
qint64
)
)
);
connect
(
m_renderer
,
SIGNAL
(
error
()
),
this
,
SLOT
(
error
()
)
);
connect
(
m_renderer
,
SIGNAL
(
error
()
),
this
,
SLOT
(
error
()
)
);
...
@@ -161,17 +160,6 @@ PreviewWidget::updateVolume( int volume )
...
@@ -161,17 +160,6 @@ PreviewWidget::updateVolume( int volume )
m_renderer
->
setVolume
(
volume
);
m_renderer
->
setVolume
(
volume
);
}
}
void
PreviewWidget
::
endReached
()
{
m_previewStopped
=
true
;
m_ui
->
pushButtonPlay
->
setIcon
(
QIcon
(
":/images/play"
)
);
// Set the black background
m_ui
->
renderWidget
->
setPalette
(
m_videoPalette
);
}
void
void
PreviewWidget
::
on_pushButtonNextFrame_clicked
()
PreviewWidget
::
on_pushButtonNextFrame_clicked
()
{
{
...
@@ -199,6 +187,7 @@ PreviewWidget::stop()
...
@@ -199,6 +187,7 @@ PreviewWidget::stop()
{
{
m_previewStopped
=
true
;
m_previewStopped
=
true
;
m_renderer
->
stop
();
m_renderer
->
stop
();
m_ui
->
pushButtonPlay
->
setIcon
(
QIcon
(
":/images/play"
)
);
}
}
}
}
...
...
src/Gui/preview/PreviewWidget.h
View file @
c5e1fbbe
...
@@ -49,7 +49,6 @@ private:
...
@@ -49,7 +49,6 @@ private:
GenericRenderer
*
m_renderer
;
GenericRenderer
*
m_renderer
;
bool
m_endReached
;
bool
m_endReached
;
bool
m_previewStopped
;
bool
m_previewStopped
;
QPalette
m_videoPalette
;
protected:
protected:
virtual
void
changeEvent
(
QEvent
*
e
);
virtual
void
changeEvent
(
QEvent
*
e
);
...
@@ -68,7 +67,6 @@ private slots:
...
@@ -68,7 +67,6 @@ private slots:
void
videoStopped
();
void
videoStopped
();
void
volumeChanged
();
void
volumeChanged
();
void
updateVolume
(
int
);
void
updateVolume
(
int
);
void
endReached
();
void
markerStartClicked
();
void
markerStartClicked
();
void
markerStopClicked
();
void
markerStopClicked
();
void
createNewClipFromMarkers
();
void
createNewClipFromMarkers
();
...
...
src/Gui/preview/ui/PreviewWidget.ui
View file @
c5e1fbbe
...
@@ -29,16 +29,7 @@
...
@@ -29,16 +29,7 @@
<property
name=
"spacing"
>
<property
name=
"spacing"
>
<number>
0
</number>
<number>
0
</number>
</property>
</property>
<property
name=
"leftMargin"
>
<property
name=
"margin"
>
<number>
0
</number>
</property>
<property
name=
"topMargin"
>
<number>
0
</number>
</property>
<property
name=
"rightMargin"
>
<number>
0
</number>
</property>
<property
name=
"bottomMargin"
>
<number>
0
</number>
<number>
0
</number>
</property>
</property>
<item>
<item>
...
...
src/Renderer/ClipRenderer.cpp
View file @
c5e1fbbe
...
@@ -283,5 +283,4 @@ ClipRenderer::__endReached()
...
@@ -283,5 +283,4 @@ ClipRenderer::__endReached()
m_isRendering
=
false
;
m_isRendering
=
false
;
if
(
m_mediaChanged
==
true
)
if
(
m_mediaChanged
==
true
)
m_clipLoaded
=
false
;
m_clipLoaded
=
false
;
emit
endReached
();
}
}
src/Renderer/GenericRenderer.h
View file @
c5e1fbbe
...
@@ -225,14 +225,6 @@ signals:
...
@@ -225,14 +225,6 @@ signals:
*/
*/
void
frameChanged
(
qint64
newFrame
,
void
frameChanged
(
qint64
newFrame
,
Vlmc
::
FrameChangedReason
reason
);
Vlmc
::
FrameChangedReason
reason
);
/**
* \brief Emmited when render end is reached.
*
* This should be emmited just before stopped
* \sa stopped();
*/
void
endReached
();
/**
/**
* \brief Emited when something went wrong with the render.
* \brief Emited when something went wrong with the render.
*
*
...
...
src/Renderer/WorkflowRenderer.cpp
View file @
c5e1fbbe
...
@@ -74,7 +74,7 @@ WorkflowRenderer::initializeRenderer()
...
@@ -74,7 +74,7 @@ WorkflowRenderer::initializeRenderer()
connect
(
m_mediaPlayer
,
SIGNAL
(
paused
()
),
this
,
SIGNAL
(
paused
()
),
Qt
::
DirectConnection
);
connect
(
m_mediaPlayer
,
SIGNAL
(
paused
()
),
this
,
SIGNAL
(
paused
()
),
Qt
::
DirectConnection
);
connect
(
m_mediaPlayer
,
SIGNAL
(
errorEncountered
()
),
this
,
SLOT
(
errorEncountered
()
)
);
connect
(
m_mediaPlayer
,
SIGNAL
(
errorEncountered
()
),
this
,
SLOT
(
errorEncountered
()
)
);
//FIXME:: check if this doesn't require Qt::QueuedConnection
//FIXME:: check if this doesn't require Qt::QueuedConnection
connect
(
m_mediaPlayer
,
SIGNAL
(
stopped
()
),
this
,
SIGNAL
(
endReach
ed
()
)
);
connect
(
m_mediaPlayer
,
SIGNAL
(
stopped
()
),
this
,
SIGNAL
(
stopp
ed
()
)
);
}
}
WorkflowRenderer
::~
WorkflowRenderer
()
WorkflowRenderer
::~
WorkflowRenderer
()
...
@@ -452,8 +452,8 @@ WorkflowRenderer::loadProject( const QDomElement &project )
...
@@ -452,8 +452,8 @@ WorkflowRenderer::loadProject( const QDomElement &project )
void
void
WorkflowRenderer
::
__endReached
()
WorkflowRenderer
::
__endReached
()
{
{
//FIXME: Is this necessary?!
stop
();
stop
();
emit
endReached
();
}
}
void
void
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment