Fixed deadlock in SettingsManager

5b3a8cf5 · Hugo Beauzee-Luyssen · c6d71cae · 5b3a8cf5
Commit 5b3a8cf5 authored Dec 22, 2009 by Hugo Beauzee-Luyssen
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

src/Configuration/SettingsManager.cpp src/Configuration/SettingsManager.cpp +5 -1

No files found.
--- a/src/Configuration/SettingsManager.cpp
+++ b/src/Configuration/SettingsManager.cpp
@@ -64,8 +64,12 @@ void  SettingsManager::setValue( const QString& part , const QString& key, const
 {
    m_globalLock.lockForRead();
    if ( !m_tempData.contains( part ) )
+    {
+        m_globalLock.unlock();
        addNewSettingsPart( part );
-    m_globalLock.unlock();
+    }
+    else
+        m_globalLock.unlock();
    QWriteLocker    lock( &m_globalLock );
    SettingsPart*   tmp = m_tempData[part];
    SettingsPart::ConfigPair::iterator it = tmp->m_data.find( key );