From b898bd73947a21fc1ddf31e4732fa3040cf86433 Mon Sep 17 00:00:00 2001
From: Fatih Uzunoglu <fuzun54@outlook.com>
Date: Tue, 11 Mar 2025 18:19:30 +0200
Subject: [PATCH 1/2] qml: make header color transparent by default in
`TableViewExt`
Having a header color by default does not make sense here:
- There is header background color but not background color for the rest.
- Views are not controls, and are often placed within controls where
background is handled properly.
- A purely transparent rectangle does not create a scene graph node thus
not rendered. This is considered an optimization for rendering. In this
case, since the background is likely to be the same as the background
color of the parent control, the area is painted twice with the same
color. If the color needs to be different, the property can be overridden
to deviate from transparent color.
---
modules/gui/qt/widgets/qml/TableViewExt.qml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/modules/gui/qt/widgets/qml/TableViewExt.qml b/modules/gui/qt/widgets/qml/TableViewExt.qml
index 490ab07e3d50..cfd6a14490ab 100644
--- a/modules/gui/qt/widgets/qml/TableViewExt.qml
+++ b/modules/gui/qt/widgets/qml/TableViewExt.qml
@@ -112,7 +112,7 @@ FocusScope {
property Component header: null
property Item headerItem: view.headerItem?.loadedHeader ?? null
- property color headerColor: colorContext.bg.primary
+ property color headerColor: "transparent"
property int headerTopPadding: 0
--
GitLab
From 567be20648eda24b09805984020fcd929bb8f104 Mon Sep 17 00:00:00 2001
From: Fatih Uzunoglu <fuzun54@outlook.com>
Date: Tue, 11 Mar 2025 18:20:33 +0200
Subject: [PATCH 2/2] qml: do not set `headerColor` in
`MusicAlbumsGridExpandDelegate`
The background color is the same as header color, there is no
need to have extra coloring in the header.
---
.../qt/medialibrary/qml/MusicAlbumsGridExpandDelegate.qml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/modules/gui/qt/medialibrary/qml/MusicAlbumsGridExpandDelegate.qml b/modules/gui/qt/medialibrary/qml/MusicAlbumsGridExpandDelegate.qml
index 4c12af4ac4f6..4121a148e7c9 100644
--- a/modules/gui/qt/medialibrary/qml/MusicAlbumsGridExpandDelegate.qml
+++ b/modules/gui/qt/medialibrary/qml/MusicAlbumsGridExpandDelegate.qml
@@ -77,6 +77,8 @@ FocusScope {
}
Rectangle {
+ id: background
+
anchors.fill: parent
color: theme.bg.secondary
@@ -418,10 +420,7 @@ FocusScope {
}
}]
-
- headerColor: theme.bg.secondary
-
- fadingEdge.backgroundColor: headerColor
+ fadingEdge.backgroundColor: background.color
header: Loader {
sourceComponent: VLCStyle.isScreenSmall
--
GitLab