VLC merge requestshttps://code.videolan.org/videolan/vlc/-/merge_requests2024-03-26T08:26:53Zhttps://code.videolan.org/videolan/vlc/-/merge_requests/5129macosx: Fix assert in audio artist view2024-03-26T08:26:53ZAnkit Meelmacosx: Fix assert in audio artist view```
2024-03-25 05:45:26.343517+0530 vlc-osx-static[12026:2028980] *** Assertion failure in -[VLCLibraryAudioViewController presentPlaceholderAudioView], VLCLibraryAudioViewController.m:360
2024-03-25 05:45:26.349972+0530 vlc-osx-static[1...```
2024-03-25 05:45:26.343517+0530 vlc-osx-static[12026:2028980] *** Assertion failure in -[VLCLibraryAudioViewController presentPlaceholderAudioView], VLCLibraryAudioViewController.m:360
2024-03-25 05:45:26.349972+0530 vlc-osx-static[12026:2028980] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Received invalid audio library segment from audio data source!'
*** First throw call stack:
(
0 CoreFoundation 0x00000001912aeccc __exceptionPreprocess + 176
1 libobjc.A.dylib 0x0000000190d96788 objc_exception_throw + 60
2 Foundation 0x000000019241fc6c -[NSCalendarDate initWithCoder:] + 0
3 libmacosx_plugin.dylib 0x0000000108f83338 -[VLCLibraryAudioViewController presentPlaceholderAudioView] + 912
4 libmacosx_plugin.dylib 0x0000000108f83f0c -[VLCLibraryAudioViewController updatePresentedView] + 112
5 libmacosx_plugin.dylib 0x0000000108f84088 -[VLCLibraryAudioViewController setCurrentSegmentType:] + 56
6 libmacosx_plugin.dylib 0x0000000108f5a914 -[VLCLibraryWindow showAudioLibrary] + 168
7 libmacosx_plugin.dylib 0x0000000108f59560 -[VLCLibraryWindow setViewForSelected
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Received invalid audio library segment from audio data source!'
*** First throw call stack:
(
0 CoreFoundation 0x00000001912aeccc __exceptionPreprocess + 176
1 libobjc.A.dylib 0x0000000190d96788 objc_exception_throw + 60
2 Foundation 0x000000019241fc6c -[NSCalendarDate initWithCoder:] + 0
3 libmacosx_plugin.dylib 0x0000000108f83338 -[VLCLibraryAudioViewController presentPlaceholderAudioView] + 912
4 libmacosx_plugin.dylib 0x0000000108f83f0c -[VLCLibraryAudioViewController updatePresentedView] + 112
5 libmacosx_plugin.dylib 0x0000000108f84088 -[VLCLibraryAudioViewController setCurrentSegmentType:] + 56
6 libmacosx_plugin.dylib 0x0000000108f5a914 -[VLCLibraryWindow showAudioLibrary] + 168
7 libmacosx_plugin.dylib 0x0000000108f59560 -[VLCLibraryWindow setViewForSelectedSegment] + 148
8 libmacosx_plugin.dylib 0x0000000108f59620 -[VLCLibraryWindow setLibrarySegmentType:] + 104
9 libmacosx_plugin.dylib 0x0000000108f61914 -[VLCLibraryWindowNavigationSidebarController outlineViewSelectionDidChange:] + 312
10 CoreFoundation 0x000000019122eb1c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 148
11 CoreFoundation 0x00000001912c2db8 ___CFXRegistrationPost_block_invoke + 88
12 CoreFoundation 0x00000001912c2d00 _CFXRegistrationPost + 440
13 CoreFoundation 0x00000001911fd648 _CFXNotificationPost + 768
14 Foundation 0x0000000192319464 -[NSNotificationCenter postNotificationName:object:userInfo:] + 88
15 AppKit 0x0000000194b80e08 -[NSTableView _sendSelectionChangedNotificationForRows:columns:] + 200
16 AppKit 0x0000000194d3559c -[NSTableView mouseDown:] + 3856
17 AppKit 0x0000000194d3450c -[NSOutlineView mouseDown:] + 76
18 AppKit 0x0000000194c3099c -[NSWindow(NSEventRouting) _handleMouseDownEvent:isDelayedEvent:] + 3472
19 AppKit 0x0000000194bbbf78 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 364
20 AppKit 0x0000000194bbbc38 -[NSWindow(NSEventRouting) sendEvent:] + 284
21 AppKit 0x0000000195281e70 -[NSApplication(NSEventRouting) sendEvent:] + 1604
22 AppKit 0x0000000194ecf8cc -[NSApplication _handleEvent:] + 60
23 AppKit 0x0000000194a83cdc -[NSApplication run] + 512
24 vlc-osx-static 0x00000001000032f8 main + 1780
25 dyld 0x0000000190dd20e0 start + 2360
)
2024-03-25 05:45:26.350775+0530 vlc-osx-static[12026:2028980] [General] An uncaught exception was raised
2024-03-25 05:45:26.350919+0530 vlc-osx-static[12026:2028980] [General] Received invalid audio library segment from audio data source!
2024-03-25 05:45:26.351067+0530 vlc-osx-static[12026:2028980] [General] (
0 CoreFoundation 0x00000001912aeccc __exceptionPreprocess + 176
1 libobjc.A.dylib 0x0000000190d96788 objc_exception_throw + 60
2 Foundation 0x000000019241fc6c -[NSCalendarDate initWithCoder:] + 0
3 libmacosx_plugin.dylib 0x0000000108f83338 -[VLCLibraryAudioViewController presentPlaceholderAudioView] + 912
4 libmacosx_plugin.dylib 0x0000000108f83f0c -[VLCLibraryAudioViewController updatePresentedView] + 112
5 libmacosx_plugin.dylib 0x0000000108f84088 -[VLCLibraryAudioViewController setCurrentSegmentType:] + 56
VLC media player 4.0.0-dev Otto Chriek (revision 4.0.0-dev-28252-g5514572ec9)
```https://code.videolan.org/videolan/vlc/-/merge_requests/5128contrib: soxr: don't force the CMAKE_SYSTEM_NAME when cross compiling2024-03-28T09:57:03ZSteve Lhommecontrib: soxr: don't force the CMAKE_SYSTEM_NAME when cross compilingThe proper value is already set in the toolchain.cmake since a6dcec33242e131addf60fd8f324256fc2127bb5.
If the value is not set for a cross compiled target, building fails since f2e67d22ff313ce44bd60cd534d51ff529ffda00.The proper value is already set in the toolchain.cmake since a6dcec33242e131addf60fd8f324256fc2127bb5.
If the value is not set for a cross compiled target, building fails since f2e67d22ff313ce44bd60cd534d51ff529ffda00.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/5126contrib: ffmpeg: disable source folder linking when generating PDB2024-03-28T12:00:27ZSteve Lhommecontrib: ffmpeg: disable source folder linking when generating PDBIt messes with the source folder location.It messes with the source folder location.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/5125extras: ci: allow wasm-shared building2024-03-28T09:11:22ZKhalid Masumextras: ci: allow wasm-shared buildinghttps://code.videolan.org/videolan/vlc/-/merge_requests/5123macOS/tools/contribs: support out of source build2024-03-26T06:38:42ZAnkit MeelmacOS/tools/contribs: support out of source buildAlthough contribs tarballs are placed in git repo, it doesn't interfere
with meson. The implementation is similar to vlc's bootstrap/configure.
TOOLS_BUILDDIR and CONTRIBS_BUILDDIR are relative to the caller `pwd`.
Example invocation in ...Although contribs tarballs are placed in git repo, it doesn't interfere
with meson. The implementation is similar to vlc's bootstrap/configure.
TOOLS_BUILDDIR and CONTRIBS_BUILDDIR are relative to the caller `pwd`.
Example invocation in `vlcbuild` directory:
TOOLS_BUILDDIR=./keep_tools/ CONTRIBS_BUILDDIR=./keep_contribs ../vlc/extras/package/macosx/build.sh
----------
meson doesn't support having dependencies installed in the source dir.
This eases supporting contribs and vlc with meson.
And later support packaging the app using meson too.https://code.videolan.org/videolan/vlc/-/merge_requests/5122qml: Ctrl+L shortcut to open the playlist view now works the first time2024-03-25T09:31:55ZAsh Vqml: Ctrl+L shortcut to open the playlist view now works the first timeAdded missing `updatePlaylistVisible` transition in the `fsmForceHidden` FSMState of the `PlayerPlaylistVisibilityFSM.qml` to update the FSMState of the PlayerPlaylistVisibilityFSM when Ctrl + L is hit for the first time to change the FS...Added missing `updatePlaylistVisible` transition in the `fsmForceHidden` FSMState of the `PlayerPlaylistVisibilityFSM.qml` to update the FSMState of the PlayerPlaylistVisibilityFSM when Ctrl + L is hit for the first time to change the FSMState from `fsmForceHidden` to `fsmFollowVisible` — while playing a video.<br>
<br>
<b>Previously:</b><br>
![Previously](/uploads/02defca6990d44269e155d1555f0be78/Screencast_from_23-03-24_10_02_02_PM_IST.webm)<br>
<b>Presently:</b><br>
![Presently](/uploads/54123e8f5b52756af61f0686919bb68e/Screencast_from_23-03-24_10_03_03_PM_IST.webm)<br>
<br>
Fixes Issue: #285004.0https://code.videolan.org/videolan/vlc/-/merge_requests/5120qml: add press and hold animation to play button2024-03-27T17:34:26ZFatih Uzunoğluqml: add press and hold animation to play buttonRequest review @chub.
[simplescreenrecorder-2024-03-22_15.40.06.mkv](/uploads/dcd1bc4e1ff8cc480703513763879da8/simplescreenrecorder-2024-03-22_15.40.06.mkv)Request review @chub.
[simplescreenrecorder-2024-03-22_15.40.06.mkv](/uploads/dcd1bc4e1ff8cc480703513763879da8/simplescreenrecorder-2024-03-22_15.40.06.mkv)4.0https://code.videolan.org/videolan/vlc/-/merge_requests/5104qml: maintenance work around ExpandGridView2024-03-20T12:01:46ZPrince Guptaqml: maintenance work around ExpandGridViewhttps://code.videolan.org/videolan/vlc/-/merge_requests/5100fingerprinter: abort processing on close2024-03-22T10:37:14ZFatih Uzunoğlufingerprinter: abort processing on closeRequest review @tguillem.Request review @tguillem.https://code.videolan.org/videolan/vlc/-/merge_requests/5094qml: make ArtworkInfoWidget toolbar control draggable2024-03-20T14:36:03ZFatih Uzunoğluqml: make ArtworkInfoWidget toolbar control draggableDragging this toolbar control is now
possible and is equivalent to dragging
the current playlist item.Dragging this toolbar control is now
possible and is equivalent to dragging
the current playlist item.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/5093qt: enable drop support in playlist media list view2024-03-20T12:57:30ZFatih Uzunoğluqt: enable drop support in playlist media list viewWith this patch, it is now possible to drag
media library and input items directly
into a playlist.
New input item is created for an unknown
source. So, actions such as dragging from
file browser should also be supported as long
as the ...With this patch, it is now possible to drag
media library and input items directly
into a playlist.
New input item is created for an unknown
source. So, actions such as dragging from
file browser should also be supported as long
as the drag event contains URLs.
It is also possible to append a playlist into
another playlist.
Previously, it was only possible to first
load the playlist in order to add items.
Now, in the playlist view (the view where
all the playlists are listed) items can be
dropped in to the playlists.https://code.videolan.org/videolan/vlc/-/merge_requests/5089Fixes incorrect artist view2024-03-21T03:33:35ZAakarsh MJmj.akarsh@gmail.comFixes incorrect artist view![28556](/uploads/70c039eafd3f987531fac43942b04844/28556.mp4)
[28556](https://code.videolan.org/videolan/vlc/-/issues/28556)
Signed-off-by: Aakarsh MJ <mj.akarsh@gmail.com>![28556](/uploads/70c039eafd3f987531fac43942b04844/28556.mp4)
[28556](https://code.videolan.org/videolan/vlc/-/issues/28556)
Signed-off-by: Aakarsh MJ <mj.akarsh@gmail.com>4.0https://code.videolan.org/videolan/vlc/-/merge_requests/5073qt: invalidate playlist current item while waiting for a new current item2024-03-26T16:39:20ZFatih Uzunoğluqt: invalidate playlist current item while waiting for a new current itemRequest review @alexandre-janniaux.Request review @alexandre-janniaux.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/5071qt: playlistmedialist/TypeError: Cannot read property 'count' of null2024-03-28T09:50:31ZDarshan Jainqt: playlistmedialist/TypeError: Cannot read property 'count' of nullWhen we click on Playlist view, a Qt warning is generated. TypeError: Cannot read property 'count' of null
This is due to the function \_getCount(model) is not defined when "model.count" is undefined
With this commit the warning is con...When we click on Playlist view, a Qt warning is generated. TypeError: Cannot read property 'count' of null
This is due to the function \_getCount(model) is not defined when "model.count" is undefined
With this commit the warning is controlled.
Fixes: #285614.0https://code.videolan.org/videolan/vlc/-/merge_requests/5066qt: update filter rules to respect logging verbosity2024-03-26T09:41:48ZFatih Uzunoğluqt: update filter rules to respect logging verbosityRequest review @alexandre-janniaux.Request review @alexandre-janniaux.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/5065contrib: add buildbindir to path2024-03-22T10:39:15ZFatih Uzunoğlucontrib: add buildbindir to pathQt's `qsb` tries to run `spirv-opt` through `PATH`.
Request review @robUx4.Qt's `qsb` tries to run `spirv-opt` through `PATH`.
Request review @robUx4.https://code.videolan.org/videolan/vlc/-/merge_requests/5059qt: don't cache large medialibrary covers2024-03-23T09:41:11ZPrince Guptaqt: don't cache large medialibrary coversdon't cache large media covers of GridItem to save on memory
prioritize caching small and frequently used images like 'fallbackImage'don't cache large media covers of GridItem to save on memory
prioritize caching small and frequently used images like 'fallbackImage'4.0https://code.videolan.org/videolan/vlc/-/merge_requests/5056qml: determine resize handle width according to scroll bar width2024-03-14T16:15:18ZFatih Uzunoğluqml: determine resize handle width according to scroll bar widthResize handle may overlap the scroll bar. In that case, using
scroll bar may be impossible because the resize handle might
have a width that is larger than the width of the scroll bar.
Since scroll bar is not customized, we have no cont...Resize handle may overlap the scroll bar. In that case, using
scroll bar may be impossible because the resize handle might
have a width that is larger than the width of the scroll bar.
Since scroll bar is not customized, we have no control over
the width of the scroll bar. Therefore, in this patch it is
proposed to set the width of resize handle to half of the
scroll bar's width. This makes both scrolling and resizing
feasible.https://code.videolan.org/videolan/vlc/-/merge_requests/5044qml: Handling unsortable columns2024-03-28T09:50:33ZAsh Vqml: Handling unsortable columns- Added `isSortable` key/flag in the qml list view colModels for KeyNavigableTableView.
- Now, sorting cannot be done according to columns which are invalid sort criteria in the C++ data models.
- For such columns the <ins>*isSortable fl...- Added `isSortable` key/flag in the qml list view colModels for KeyNavigableTableView.
- Now, sorting cannot be done according to columns which are invalid sort criteria in the C++ data models.
- For such columns the <ins>*isSortable flag is explicitly set to false*</ins> in the colModels.
<br><br>
Fixes Issue: #28503https://code.videolan.org/videolan/vlc/-/merge_requests/5042qt: attempt to fix color banding - request 30-bit color depth2024-03-28T09:50:30ZFatih Uzunoğluqt: attempt to fix color banding - request 30-bit color depthWe use colors (notably in shadows) that is not possible to be represented by an 8-bit number.
Qt uses pre-multiplied alpha representation, this reduces the color depth to below 24-bit.
Consider the color RGBA(0.05, 0.05, 0.05, 0.1), th...We use colors (notably in shadows) that is not possible to be represented by an 8-bit number.
Qt uses pre-multiplied alpha representation, this reduces the color depth to below 24-bit.
Consider the color RGBA(0.05, 0.05, 0.05, 0.1), this becomes RGBA(0.005, 0.005, 0.005, 0.1) when pre-multiplied. 0.005 is out of the range of values that can be represented in 8 bits.
If 30-bit depth request fails, it should use the default 24-bit depth.
Closes #27897.4.0