VLC merge requestshttps://code.videolan.org/videolan/vlc/-/merge_requests2024-03-01T13:50:31Zhttps://code.videolan.org/videolan/vlc/-/merge_requests/2753qt: release window resources on scale factor change2024-03-01T13:50:31ZFatih Uzunoğluqt: release window resources on scale factor change4.0https://code.videolan.org/videolan/vlc/-/merge_requests/3925qml: remove menu button from TableViewDelegate2024-02-28T14:22:21ZFatih Uzunoğluqml: remove menu button from TableViewDelegateThis menu button is useless and looks ugly. Users are supposed to use the menu key or right click for initiating the context menu.
CC @chub, I think we agreed on removing this before. Please correct if not.
Close #26689.This menu button is useless and looks ugly. Users are supposed to use the menu key or right click for initiating the context menu.
CC @chub, I think we agreed on removing this before. Please correct if not.
Close #26689.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/3004qt: handle special case with high precision scrolling in custom scroll handler2024-02-20T15:40:38ZFatih Uzunoğluqt: handle special case with high precision scrolling in custom scroll handlerIt appears that at least with XWayland, pixel delta is reported as angle delta, and this information can be used to properly handle high precision scrolling.
I have heard that Mac OS was also problematic with this regard. I can't test i...It appears that at least with XWayland, pixel delta is reported as angle delta, and this information can be used to properly handle high precision scrolling.
I have heard that Mac OS was also problematic with this regard. I can't test it, but this may also fix the behavior on that platform.
This will fix scrolling behavior in at least these cases:
- Smooth scrolling disabled, and high precision mouse/trackpad is used.
- Smooth scrolling enabled (default). However, used Qt version is < 5.15.8, so custom scroll handler is force enabled for high precision scrolling.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/2617contrib: remove default prebuilt URL2024-01-29T12:25:11ZSteve Lhommecontrib: remove default prebuilt URLThe user will have to provide a URL for the prebuilt to use (can be a file:// URL).The user will have to provide a URL for the prebuilt to use (can be a file:// URL).4.0https://code.videolan.org/videolan/vlc/-/merge_requests/3518[3.0] vout/win32: cleanup code2024-01-29T12:22:30ZSteve Lhomme[3.0] vout/win32: cleanup codeAfter a lot of patching over the years, the code has become a bit messy.
This patchset cleans things up a bit in the common code and in respective modules.After a lot of patching over the years, the code has become a bit messy.
This patchset cleans things up a bit in the common code and in respective modules.3.0.x maintenancehttps://code.videolan.org/videolan/vlc/-/merge_requests/4598fetcher: use a local heap buffer to read data and do less allocation2024-01-29T09:43:16ZSteve Lhommefetcher: use a local heap buffer to read data and do less allocationAnd fix the fetched notification on success.And fix the fetched notification on success.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/3529h26x: improve h264/hevc probing2024-01-29T09:29:41ZThomas Guillemh26x: improve h264/hevc probingThis fixes playback for several camera recording that can store some metadata (address, time, GPS...) before the h264/hevc video.This fixes playback for several camera recording that can store some metadata (address, time, GPS...) before the h264/hevc video.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/2632qt: fix texture blending issue2023-12-21T16:09:52ZFatih Uzunoğluqt: fix texture blending issueWhen the built-in blur function is used, it adjusts the data that is reinterpreted as alpha in the Qt Quick side. (Edges are faded to transparent)
`QImage` RGB32 format does not report having an alpha channel, but it still has 8 bits pe...When the built-in blur function is used, it adjusts the data that is reinterpreted as alpha in the Qt Quick side. (Edges are faded to transparent)
`QImage` RGB32 format does not report having an alpha channel, but it still has 8 bits per pixel reserved with value of `0xff`. The blur function adjusts these bits, and when the texture is generated from the image, the blending of the node material is disabled because the image reports it does not have an alpha channel. However, the fragment shader still respects the alpha value even if blending is disabled.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/3846access: rtp: have owner callbacks instead of symbols2023-12-07T14:48:52ZFrançois Cartegnieaccess: rtp: have owner callbacks instead of symbolsduplicate symbols on static libsduplicate symbols on static libs4.0François CartegnieFrançois Cartegniehttps://code.videolan.org/videolan/vlc/-/merge_requests/2505contrib: force dependencies on forced packages2023-08-11T08:50:28ZAlexandre Janniauxajanni@videolabs.iocontrib: force dependencies on forced packagesIf the package `foo` has been forced (PKGS_ENABLE += foo) and the
dependencies of package `bar` includes `foo` (DEPS_bar = foo), but `foo`
has been found on the system (PKGS_FOUND += foo), then `foo` and `bar`
would be built simultaneous...If the package `foo` has been forced (PKGS_ENABLE += foo) and the
dependencies of package `bar` includes `foo` (DEPS_bar = foo), but `foo`
has been found on the system (PKGS_FOUND += foo), then `foo` and `bar`
would be built simultaneously.
This commit ensure that forced packages like `foo` are still built
before packages depending on them, like `bar`.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/1962nvdec: hw_pool: fix allocation function2023-08-11T08:49:43ZAlexandre Janniauxajanni@videolabs.ionvdec: hw_pool: fix allocation function- null-deref on error path
- leak on error path
- dos2unix the whole file
- use flexible array instead of VLA to fix warning- null-deref on error path
- leak on error path
- dos2unix the whole file
- use flexible array instead of VLA to fix warning4.0https://code.videolan.org/videolan/vlc/-/merge_requests/3401adaptive: avoid creating a global string2023-05-17T06:21:02ZSteve Lhommeadaptive: avoid creating a global stringIt has to be created as soon as the module is loaded, rather than when the
string will actually be used.It has to be created as soon as the module is loaded, rather than when the
string will actually be used.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/2380qml: use GridView for network devices2022-10-25T15:27:51ZLeon Vitanosqml: use GridView for network devices4.0https://code.videolan.org/videolan/vlc/-/merge_requests/2155network: use a function to turn network errors into string2022-09-06T07:46:26ZSteve Lhommenetwork: use a function to turn network errors into stringSo whether we decide to turn network errors into `errno` or keep using `net_errno`, the code logging network errors won't need to change.
Also report `bind()` errors early which both simplifies the code and make the log order more logic...So whether we decide to turn network errors into `errno` or keep using `net_errno`, the code logging network errors won't need to change.
Also report `bind()` errors early which both simplifies the code and make the log order more logical on Linux.
---
v2: poll sets `errno` on all error pathes on Windows, so don't use `net_errno` to report poll errors.4.0Steve LhommeSteve Lhommehttps://code.videolan.org/videolan/vlc/-/merge_requests/1644test: interrupt: handle signals when cancelled2022-08-31T09:19:00ZAlexandre Janniauxajanni@videolabs.iotest: interrupt: handle signals when cancelledDuring cancellation, signals can be sent to the threads to interrupt the
syscalls, leading to spurrious failure of the test depending on when
vlc_cancel race against poll().
With ASAN enabled, I typically got almost 100% reproductibilit...During cancellation, signals can be sent to the threads to interrupt the
syscalls, leading to spurrious failure of the test depending on when
vlc_cancel race against poll().
With ASAN enabled, I typically got almost 100% reproductibility of
vlc_poll_i11e returning -1 with errno=EINTR, with a non-interrupted
context, in the cancelled thread test. Note that it can also be
reproduced **without** ASAN but less often.
Since we have a test without thread cancellation, allow EINTR in the
thread cancellation scenario to check that timeout can still happen.
strace -f --trace=%signal,poll,write,read build/src/test_interrupt
...
strace: Process 421456 attached
[pid 421453] rt_sigprocmask(SIG_SETMASK, [INT QUIT PIPE TERM], NULL, 8) = 0
[pid 421456] rt_sigprocmask(SIG_SETMASK, [INT QUIT PIPE TERM], <unfinished ...>
[pid 421453] rt_sigprocmask(SIG_SETMASK, [], <unfinished ...>
[pid 421456] <... rt_sigprocmask resumed>NULL, 8) = 0
[pid 421453] <... rt_sigprocmask resumed>NULL, 8) = 0
[pid 421453] rt_sigaction(SIGRTMIN, {sa_handler=0x7fafedcdaa80, sa_mask=[], sa_flags=SA_RESTORER|SA_RESTART|SA_SIGINFO, sa_restorer=0x7fafedc91560}, NULL, 8) = 0
[pid 421453] rt_sigprocmask(SIG_BLOCK, ~[], [], 8) = 0
[pid 421453] tgkill(421453, 421456, SIGRTMIN) = 0
[pid 421456] poll([{fd=5, events=POLLIN}], 1, 1 <unfinished ...>
[pid 421453] rt_sigprocmask(SIG_SETMASK, [], <unfinished ...>
[pid 421456] <... poll resumed>) = ? ERESTART_RESTARTBLOCK (Interrupted by signal)
[pid 421453] <... rt_sigprocmask resumed>NULL, 8) = 0
[pid 421456] --- SIGRTMIN {si_signo=SIGRTMIN, si_code=SI_TKILL, si_pid=421453, si_uid=1000} ---
[pid 421456] rt_sigreturn({mask=[INT QUIT PIPE TERM]}) = -1 EINTR (Interrupted system call)
[pid 421456] write(2, "test_interrupt: ../../src/test/i"..., 119test_interrupt: ../../src/test/interrupt.c:86: test_context_simple: Assertion `vlc_poll_i11e(NULL, 0, 1) == 0' failed.
) = 119
[pid 421456] rt_sigprocmask(SIG_UNBLOCK, [ABRT], NULL, 8) = 0
[pid 421456] tgkill(421453, 421456, SIGABRT) = 0
[pid 421456] --- SIGABRT {si_signo=SIGABRT, si_code=SI_TKILL, si_pid=421453, si_uid=1000} ---
[pid 421456] +++ killed by SIGABRT (core dumped) +++
+++ killed by SIGABRT (core dumped) +++
Fix #264884.0Alexandre Janniauxajanni@videolabs.ioAlexandre Janniauxajanni@videolabs.iohttps://code.videolan.org/videolan/vlc/-/merge_requests/1188uavs3d: AVS3 decoder2022-07-29T15:35:54ZRémi Denis-Courmontuavs3d: AVS3 decoderRefs #26463Refs #26463https://code.videolan.org/videolan/vlc/-/merge_requests/826threads: let vlc_join tell if the joined thread was canceled2022-05-31T07:48:33ZSteve Lhommethreads: let vlc_join tell if the joined thread was canceledThe arbitrary value may collide with an actual thread return value.
We can then remove `VLC_THREAD_CANCELED`.
Deprecates !770
## Update
v2: added a check on a TLS test that uses the return value of a thread (even though the file doe...The arbitrary value may collide with an actual thread return value.
We can then remove `VLC_THREAD_CANCELED`.
Deprecates !770
## Update
v2: added a check on a TLS test that uses the return value of a thread (even though the file doesn't use cancelation).4.0https://code.videolan.org/videolan/vlc/-/merge_requests/1265access_output/srt: fix signedness warning2022-05-01T15:06:59ZRomain Vimontaccess_output/srt: fix signedness warningFix comparison of integer expressions of different signedness (size_t vs
int). Since the result is assigned to an int (chunk_size), explicitly
convert size_t to int.
Also move the call to block_BytestreamRemaining() out of the __MIN()
m...Fix comparison of integer expressions of different signedness (size_t vs
int). Since the result is assigned to an int (chunk_size), explicitly
convert size_t to int.
Also move the call to block_BytestreamRemaining() out of the __MIN()
macro, to avoid evaluating it twice.4.0https://code.videolan.org/videolan/vlc/-/merge_requests/1024Translated some entries2022-03-27T09:37:06ZŠimon (Simon) RatajTranslated some entrieshttps://code.videolan.org/videolan/vlc/-/merge_requests/7config: (docs) clarify return type2021-12-07T13:44:14ZLyndon Brownconfig: (docs) clarify return type(Formerly titled "documentation fixes", now reduced to just the one commit that has been receiving a lot of attention, with the others that were bundled moved out to their own MRs).(Formerly titled "documentation fixes", now reduced to just the one commit that has been receiving a lot of attention, with the others that were bundled moved out to their own MRs).