2.1 regression / wasapi: Qt volume control fails

added Component::Audio: other plugins label

assigned to @Courmisch

Does changing the volume from HTTP interface crash, work or do nothing? I suspect a UI bug here...

added Component::Audio: Windows plugins label and removed Component::Audio: other plugins label

added Severity::critical label

added Status::needs more info label

closed

why didn't i find that bug report when searching? :|

with the http interface volume change works, but is not visible in the GUI window

edit: however, in the http interface the volume is initially at -100 % and jumps back to 0 % when i try to change volume, seems to be only a visual bug, though, since the volume does actually change, not sure if it is even remote related to this specific bug report, then.

Original author: http://dessa.myopenid.com/

Replying to [comment:2 courmisch]:

Does changing the volume from HTTP interface crash, work or do nothing? I suspect a UI bug here...

it works that way, but slider keeps returning to 0

Confirmed to work with HTTP interface, so Qt4 UI bug.

added Component::Interface: Qt label and removed Component::Audio: Windows plugins Status::needs more info labels

changed milestone to %2.1.x maintenance bugs

reopened

changed title from vlc 2.1.0 win64 crash in volume control to 2.1 regression: Qt volume control crash on Windows

unassigned @Courmisch

Just want to link to my bug (which was marked as a duplicate of this one) because there is a link to an uploaded sample video that can be used to verify any fix that will be applied:

#6954 (closed)

commit 12627b88 Author: Rémi Denis-Courmont remi@remlab.net Date: Mon Aug 6 21:36:13 2012 +0300

wasapi: report volume/mute (refs [#6880](https://code.videolan.org/videolan/vlc/-/issues/6880), refs [#7203](https://code.videolan.org/videolan/vlc/-/issues/7203))

This is a temporary hack to make the volume controls mostly work until
Windows volume notifications are correctly implemented.

Original author: remi@remlab.net

assigned to @Courmisch

unassigned @Courmisch

Problem is simple: Qt is leaking its COM single threaded apartment to LibVLC. That causes WASAPI to fail to reach the multithread apartment.

It is generally not safe to call back into LibVLC API while attached to a COM apartment.

(The source of the problem is probably the Windows 7 taskbar handler.)

changed title from 2.1 regression: Qt volume control crash on Windows to 2.1 regression / wasapi: Qt volume control fails

added Version::master git label

This patch works for me on Win7 x86:

diff --git a/modules/audio_output/wasapi.c b/modules/audio_output/wasapi.c
index 73e9de0..9107197
--- a/modules/audio_output/wasapi.c
+++ b/modules/audio_output/wasapi.c
@@ -90,6 +90,9 @@ static int TryEnter(vlc_object_t *obj)
 {
     HRESULT hr = CoInitializeEx(NULL, COINIT_MULTITHREADED);
     if (unlikely(FAILED(hr)))
+        hr = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED);
+
+    if (unlikely(FAILED(hr)))
     {
         msg_Err (obj, "cannot initialize COM (error 0x%lx)", hr);
         return -1;

assigned to @Courmisch

commit 0bbd5859 Author: Rémi Denis-Courmont remi@remlab.net Date: Thu Oct 4 18:19:22 2012 +0300

Qt4: use MTA apartment for COM (fixes [#6880](https://code.videolan.org/videolan/vlc/-/issues/6880))

Original author: remi@remlab.net

added Status::fixed label

closed

mentioned in issue #6954 (closed)

mentioned in issue #7217 (closed)

mentioned in issue #7219 (closed)

mentioned in issue #7424 (closed)

2.1 regression / wasapi: Qt volume control fails

Child items ...

Activity