Skip to content

--logo-repeat parameter in logo videofilter treated incorrect (Solution included)

The --logo-repeat parameter in the logo videofilter is counted wrong (or the description of repeat is incorrect ;)

Example useing sfilter logo in transcoding chain to blend out an image:

... :transcode{sfilter={logo{file='c:\image.png,500,255;c:\image.png,500,170;c:\image.png,500,85',repeat=,x=0,y=0}},vcodec=I420}

-1 : works fine and loops forever showing image transitions from opaque to translucent. \ 0 : works fine not showing anything. \ 1 : Should show at least one transition of images blending out but shows nothing. \ 2 : Shows one transition of images blending out but should show two transitions. \ N : Shows transitions of images blending but should show N transitions. \

I have located the bug in:

 370     /* Send an empty subpicture to clear the display when needed */
 371     if( p_list->i_repeat != -1 && p_list->i_counter == 0 )
 372     {
 373         p_list->i_repeat--;
 374*        if( p_list->i_repeat == 0 )
 375*            goto exit;
 376     }

Solution: Just remove line 374 and 375 and repeat parameter should work as expected.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information