3.0.21 regression: Opus fails to decode

At least two users report broken Opus parsing: https://www.reddit.com/r/VLC/comments/1dfxhda/vlc_stopped_playing_audio_for_a_video_file_for/

changed milestone to %3.0.22

added Component::Decoders Type::bug labels

(Please don't ask me for samples that I don't have.)

added Status::needs more info label

There is supposedly a sample on the Reddit thread if someone cares to upload it where it belongs.

assigned to @fcartegnie

output_vlc.mkv

and on windows VLC 3.0.21 (32 bits) crash when opening this .mkv (playing fine on other players)

define 'crash'

no crash for me with the 32-bit version

i do not have the log because it crashed but i can show this:

In vlc.exe_240615_132954.dmp the assembly instruction at d3d11!NDXGI::CDevice::WaitForSynchronizationObjectCB+2e in C:\Windows\System32\d3d11.dll from Microsoft Corporation has caused an access violation exception (0xC0000005) when trying to read from memory location 0x00000004 on thread 22

Thread 22 - System ID 13376 Entry point msvcrt!_threadstartex Create time 15/06/2024 13:29:52 Time spent in user mode 0 Days 00:00:00.000 Time spent in kernel mode 0 Days 00:00:00.000 ntdll!NtWaitForMultipleObjects+c KERNELBASE!WaitForMultipleObjectsEx+103 KERNELBASE!WaitForMultipleObjects+18 kernel32!WerpReportFaultInternal+3b7 kernel32!WerpReportFault+9d kernel32!BasepReportFault+19 KERNELBASE!UnhandledExceptionFilter+290 ntdll!__RtlUserThreadStart+3c884 ntdll!_RtlUserThreadStart+1b

I confirm it works on 3.0.20 on Windows but not in 3.0.21.

[00007f0b60c20540] opus decoder error: cannot read Opus header
[00007f0b60c20540] opus decoder error: initial Opus header is corrupted

It does not happen with all opus files. Seems container dependent issue

mentioned in merge request !5590 (merged)

Fixed by !5590 (merged)

see #28671 (comment 441997)

closed