Decrease Volume tray menu underlined access key collides with Speed (minor issue)
In the VLC system tray menu, "Decrease Volume" has an underline under the first e
. However, "Speed" also has an underline under its first e
. Thus, when I want to decrease the volume from the system tray and press E
, VLC instead opens the speed popup.
Here is a link to a video showing off the problem (it plays in VLC): https://cdn.discordapp.com/attachments/969806593858342912/1025834332423737354/simplescreenrecorder-2022-10-01_14.18.28.mp4
What I would like to happen is the shortcut key to be D
, which would fit in with I
being for "Increase Volume" (the first letter).
I attempted to make a patch for this:
diff --git a/modules/gui/qt/menus/menus.cpp b/modules/gui/qt/menus/menus.cpp
index 7d21be6f07..68ec3fec0a 100644
--- a/modules/gui/qt/menus/menus.cpp
+++ b/modules/gui/qt/menus/menus.cpp
@@ -383,7 +383,7 @@ static inline void VolumeEntries( qt_intf_t *p_intf, QMenu *current )
current->addSeparator();
current->addAction( QIcon( ":/menu/volume-high.svg" ), qtr( "&Increase Volume" ), THEMIM, &PlayerController::setVolumeUp );
- current->addAction( QIcon( ":/menu/volume-low.svg" ), qtr( "D&ecrease Volume" ), THEMIM, &PlayerController::setVolumeDown );
+ current->addAction( QIcon( ":/menu/volume-low.svg" ), qtr( "&Decrease Volume" ), THEMIM, &PlayerController::setVolumeDown );
current->addAction( QIcon( ":/menu/volume-muted.svg" ), qtr( "&Mute" ), THEMIM, &PlayerController::toggleMuted );
}
However, I don't think this would work flawlessly, as most of the po
files rely on "D&ecrease Volume" for translations: (example from Spanish translation)
#: modules/gui/qt/menus.cpp:597
#, fuzzy
msgid "D&ecrease Volume"
msgstr "Bajar volumen"
Furthermore, I attempted to use my patched version and compiled it, but I got dropped into an unfamiliar UI where neither the increase nor decrease options from the system tray worked (I was on the master
branch when I made my patch, though).