DVD: Subtitle language name incorrect for Hebrew

Playing a DVD that has Hebrew subtitles shows up in the "Subtitles > Subtitles Track" menu as "iw" instead of "Hebrew".

Added attachment:

• vlc-23602.jpg

Indeed.

added Component::Input: optical media label

I'm guessing it has something to do with this list: https://code.videolan.org/videolan/vlc/-/blob/master/src/text/iso-639_def.h

But how can we solve this without breaking the actual standard?

The thing is: Hebrew was using the code "iw" in the past but at some point the standard switched to "he" like it is today, so this list is correct.

The question is: can we add something to it although it's out of standard just for the sake of compatibilty and what other impact it may have?

Thanks.

Maybe we need to add a line for iw in src/text/iso-639_def.h

Indeed, "iw" was changed to "he" in 1989 from the original ISO 639:1988, so adding to the definitions seems to be the correct fix for legacy files, especially since "iw" was not re-assigned to another language in the meantime so there is no conflict.

changed milestone to %3.0.x maintenance

I think I can fix this myself, I just need to know: Can I simply duplicate the line and change "he" to "iw" or are there any other things that should be changed in that perspective?

Thanks.

I think so. Not so sure, but I think so.

changed title from Subtitle language name incorrect for Hebrew to DVD: Subtitle language name incorrect for Hebrew

mentioned in merge request !117 (merged)

See !117 (merged)

closed with merge request !117 (merged)

changed milestone to %3.0.17