DVB Subtitles showing only first line after some time
Hello,
I am sorry for finding this annoying bug. I am 100% this is not a bug tied to a single machine because previously I had installed Windows 7 and bug still exists in Windows 8.1.
Description: When I watch live television stream provided from my ISP (Slovenian T-2 d.o.o.) DVB subtitles suddenly starts to show only "THE FIRST LINE" of the subtitles. They work normally for some time but then this problem starts. It shows only the first line of them but the second one is ignored. Position of subtitles is OK because position looks like it has second line below (but its empty). If I restart VLC, problem disappears and after a while same thing happens again. It is really annoying if subtitles are not shown properly.
For any further questions please feel free to send me an email. I am glad to respond you with any feedback I can give you. Please understand I am a programer too, so I understand what means if bug has to be fixed.. :)
PC hardware: CPU: Intel I5 650 RAM: 4GB DDR3 SYS: Windows 8.1 Enterprise N X64 GRAPHICS: AMD Radeon HD5570 Driver: 13.152.1.1000
It wouldn't be a problem if this was my girlfriend's PC :P
Thank you for your time, Best Regards.
Jure Skubin
Activity
added Difficulty::medium Severity::major Type::bug Version::master git + 1 deleted label
changed milestone to %Bugs paradize
assigned to @jbk and unassigned @MigrationBot
added Component::Subtitles Severity::normal labels and removed Severity::major + 1 deleted label
We have analyzed the VLC source code and we believe that the problem lies in the Direct3DimportSubpicure function from the direct3d.c. There's a 'break' missing from the loop. Here is the corrected code (can someone with access to the source code please try to integrate this and test it?):
1207 static void Direct3DImportSubpicture(vout_display_t *vd, 1208 int *count_ptr, d3d_region_t **region, 1209 subpicture_t *subpicture) 1229 d3dr->texture = NULL; 1230 for (int j = 0; j < sys->d3dregion_count; j++) { 1231 d3d_region_t *cache = &sys->d3dregion[j]; 1232 if (cache->texture && 1233 cache->format == sys->d3dregion_format && 1234 cache->width == r->fmt.i_visible_width && 1235 cache->height == r->fmt.i_visible_height) { 1236 #ifndef NDEBUG 1237 msg_Dbg(vd, "Reusing %dx%d texture for OSD", 1238 cache->width, cache->height); 1239 #endif 1240 *d3dr = *cache; 1241 memset(cache, 0, sizeof(*cache)); break; /* THIS LINE WAS MISSING IN ORIGINAL CODE */ 1242 } 1243 }Currently, the 'for' loops over all matching regions in the cache, *** sets ALL to 0 *** and returns the last matching region. The next time this code is called, all those regions are ignored (except the one that was returned as a function result and was later reused) so they stay in cache forever. They are never released. The program therefore allocates more and more regions, stores them in the cache and invalidates them during the search.
That's why there is always one region available even when the GPU runs out of memory and why the VLC works fine if only one region is used.
I was able to reproduce the issue by creating a small subtitle file with 3 regions of the same size simultaneously.
1 00:00:2,501 --> 00:00:2,700 {\an8}This is some text for VLC Media Player 2 00:00:2,501 --> 00:00:2,700 {\an5}This is some text for VLC Media Player 3 00:00:2,501 --> 00:00:2,700 {\an2}This is some text for VLC Media PlayerBy modifying a bit the print functions, we can clearly see there is an issue:
direct3d error: Regions: 3 direct3d error: Created texture 195308544 for region 0 direct3d error: Created texture 195308960 for region 1 direct3d error: Created texture 166518912 for region 2 direct3d error: Regions: 3 direct3d debug: Reusing texture 195308544 for region 0 direct3d debug: Reusing texture 195308960 for region 0 direct3d debug: Reusing texture 166518912 for region 0 direct3d error: Created texture 166519200 for region 1 direct3d error: Created texture 166519520 for region 2 direct3d error: Regions: 3 direct3d debug: Reusing texture 166518912 for region 0 direct3d debug: Reusing texture 166519200 for region 0 direct3d debug: Reusing texture 166519520 for region 0 direct3d error: Created texture 166519872 for region 1 direct3d error: Created texture 166520288 for region 2 direct3d error: Regions: 3 direct3d debug: Reusing texture 166519520 for region 0 direct3d debug: Reusing texture 166519872 for region 0 direct3d debug: Reusing texture 166520288 for region 0 direct3d error: Created texture 166520672 for region 1 direct3d error: Created texture 166521088 for region 2 direct3d error: Regions: 3 direct3d debug: Reusing texture 166520288 for region 0 direct3d debug: Reusing texture 166520672 for region 0 direct3d debug: Reusing texture 166521088 for region 0 direct3d error: Created texture 166521504 for region 1 direct3d error: Created texture 166521920 for region 2 direct3d error: Deleted texture 166521088 of region 0 direct3d error: Deleted texture 166521504 of region 1 direct3d error: Deleted texture 166521920 of region 2After the initial allocation, the three textures are invalidated for region 0, we therefore leak the first two textures and we have to allocate two new ones.
Your fix is correct, thanks for reporting and investigating :)
added Component::Video: Direct3D / Win32 Status::fixed labels and removed Component::Subtitles label
changed milestone to %2.2.x maintenance branch
commit e2518461 Author: Felix Abecassis felix.abecassis@gmail.com Date: Thu Feb 13 10:19:05 2014 +0100
Direct3D: do not leak textures when recycling them If several textures from the cache (i.e. used during the previous call) are matching we invalidate all of them but only keep the last one. We therefore lose all references to the other ones. Close [#10248](https://code.videolan.org/videolan/vlc/-/issues/10248) Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>Original author: felix.abecassis@gmail.com
