- 24 May, 2022 4 commits
-
-
It returns true when it overflows.
-
The warning was always triggered because __builtin_constant_p actually checks whether the tested value is constant at compile time and strlen() was never constant at compile time. Note that __builtin_constant_p can be used with a non-constant test expression while using the same expression after ? in a ternary condition.
-
There's no requirement in v3 and v4 that we don't support. v5 doesn't exist yet. Ref. #26999
-
refs #26905
-
- 23 May, 2022 7 commits
-
-
-
To ease the proper freeing of all the `vlc_ml_folder_t` fields.
-
bear cost of instantiating an extra element to save unnecessary binding triggers previous implementation used existing MouseArea coverring whole GridItem to check for ToolTip visibility for subtitle text, but that cause a lot of unnecessary binding evaluation on every mouse move
-
improves recyling time in ExpandGridView
-
_containsItem is called a lot, cache the global variable lookup by caching it
-
-
-
- 22 May, 2022 2 commits
-
-
- 21 May, 2022 16 commits
-
-
Just as when createChunk() fails.
-
-
There's no way to release it during playback but we shouldn't leak it in the end.
-
The source size is a size_t and it represents a size in memory.
-
When building Qt, we only add and link the X11 library and flags when QT5_HAS_X11 is defined (in automake), which happens when we build Qt5X11Extras. Without this check, if autotools find the X11 library, then it might fail to find the headers (because X_CFLAGS won't be used) or will at least fail to link correct (because -lX11 will be missing from the link command). Since we don't use X11 on MacOSX, disable it by default in the configure script like Qt, so that enabling Qt module locally works correctly.
-
-
-
A header previously transitively included has gone missing in the latest 5 releases and was only fixed from 6.x.
-
sed -i doesn't work correctly with non-GNU sed.
-
-
Replace typeof by a decltype()-based equivalent on compilers not supporting typeof. Decltype is not equivalent to typeof, but we are mostly concerned about removing references from the type, since it has no use in C code like VLC list. Note that this fixup is there to fix the usage of headers using typeof in C++ code, not to provide "typeof" directly C++ to replace decltype.
-
C compilers can have GNU extensions to support typeof in C code, but some C++ compilers like clang are removing the builtin since decltype can be used in C++ without the constraints from typeof. Decltype is not 100% equivalent for this reason: references will be kept in the returned type. The check in m4/typeof.m4 comes from graydon/monotone and dovecot/core and was slightly modified to namespace the define for C++ code.
-
in previous code, for path "C:/image.jpg", the url scheme will be "C" and the call to QQmlFile::urlToLocalFileorQrc with fail since url scheme is not "file" but the provided input path is valid file path, fix such cases
-
-
... instead of Q_DECL_OVERRIDE, since it always expand to override for >=C++11 configuration, and the module uses C++11 anyway.
-
-
- 20 May, 2022 11 commits
-
-
x-test syntax (x$foo = xyes/xno) is used to circumvent the fact that shell variables are substituted and not just defining an argument, so that $foo doesn't expand to no argument at all. But "" in posix shell syntax is considered as an argument by itself, so using quotes around the variable removes this issue. Thus, x-test is useless in the case where it has been removed in this patch.
-
Hugo Beauzée-Luyssen authored -
Hugo Beauzée-Luyssen authored
-
-
-
Looking through the tar command line help is brittle, and as a matter of facts fails miserably with non-English locales. Just feed a sorted list of files for tar to archive instead. This should work regardless of the tar tool version in use. Fixes Debian #990247.
-
The interface cannot be closed before the vout_window_t object is disabled, since the playlist/player is running from outside the interfaces. When it happens, a warning was raised from skins2 and the OpenGL code would stay stuck waiting for xcb events, preventing the full closing of the interface resources and delaying the close of the application itself. This commit ensures that no skins2 window is enabled before leaving the Close function from the interface, and no new skins2 window will be enabled in a racy pattern while or after the Close function from the interface is running. The issue was highlighted in previous commit, including the commit 04409ebd which required in its commit description that interface modules should outlive the vout window instances they provide, but didn't provide a mechanism to do so. The added mutex was removed in 6083d3f1 because it was useless as-is. This commit adds a reference count of opened window, and a wait for this reference count to reach zero before ending the interface Close() function, which justify the use of a mutex. Note also that this patch uses the Enable/Disable lifecycle of the window to manage the reference count and skins2 resources, because there is an inversion between the playlist destruction and the interface destruction. We cannot wait for the vout_window_t object to be destroyed while we're waiting in the interface Close(), since the vout is potentially reused up to the playlist destruction (or more precisely, input resource destruction) which can only happen after every interface is destroyed. The implementation here is a bit different to what has been done for other interfaces like Qt. The Qt interface is creating a new libvlc object and stashes the interface state there, while refcounting it. It means that the interface implementation itself will continue to exist even if the interface object is dead. It has particular benefit when the interface is not the usual interface but a dialog provider one. The submitted approach here tries to keep the lifecycle of the interface tied together with its object, to simplify the use of its object for variable or logging, and avoid unnecessary object allocation.
-
Steve Lhomme authored
The destination texture (sys->sceneTexture) has the visible dimensions, not the decoder dimensions. Factorize the size processing for the stretching and the vertex computing. Ref. https://forum.videolan.org/viewtopic.php?f=14&t=159861
-
Steve Lhomme authored
Some platforms may not accept longer names or will truncate it, so we stick to that size. It should work with gcc at least. It also works with LLVM14.
-
Steve Lhomme authored
It exists in very old gcc and clang. VLC_WARN_CALL/VLC_ERROR_CALL may not warn though. Don't define check_delay/check_deadline otherwise and don't force the vlc_tick_sleep/vlc_tick_wait calls.
-
Steve Lhomme authored
Leave VLC_DEPRECATED_ENUM, VLC_FORMAT and VLC_FORMAT_ARG for now as they are more compiler specific.
-
