1. 24 May, 2022 4 commits
  2. 23 May, 2022 7 commits
  3. 22 May, 2022 2 commits
  4. 21 May, 2022 16 commits
  5. 20 May, 2022 11 commits
    • Alexandre Janniaux's avatar
      configure.ac: remove x-test checks · a0186adb
      Alexandre Janniaux authored and Hugo Beauzée-Luyssen's avatar Hugo Beauzée-Luyssen committed
      x-test syntax (x$foo = xyes/xno) is used to circumvent the fact that
      shell variables are substituted and not just defining an argument, so
      that $foo doesn't expand to no argument at all.
      
      But "" in posix shell syntax is considered as an argument by itself, so
      using quotes around the variable removes this issue. Thus, x-test is
      useless in the case where it has been removed in this patch.
      a0186adb
    • Hugo Beauzée-Luyssen's avatar
      7abfc1fa
    • Hugo Beauzée-Luyssen's avatar
      bc03e6e4
    • Rémi Denis-Courmont's avatar
      d1cab347
    • Rémi Denis-Courmont's avatar
      63785ac6
    • Rémi Denis-Courmont's avatar
      share: really sort files in the skins tarball · 739f285e
      Rémi Denis-Courmont authored and Hugo Beauzée-Luyssen's avatar Hugo Beauzée-Luyssen committed
      Looking through the tar command line help is brittle, and as a matter of
      facts fails miserably with non-English locales.
      
      Just feed a sorted list of files for tar to archive instead. This should
      work regardless of the tar tool version in use.
      
      Fixes Debian #990247.
      739f285e
    • Alexandre Janniaux's avatar
      skins2: skin_main: fix window closing after interface · a928eb17
      Alexandre Janniaux authored and Steve Lhomme's avatar Steve Lhomme committed
      The interface cannot be closed before the vout_window_t object is
      disabled, since the playlist/player is running from outside the
      interfaces.
      
      When it happens, a warning was raised from skins2 and the OpenGL code
      would stay stuck waiting for xcb events, preventing the full closing of
      the interface resources and delaying the close of the application itself.
      
      This commit ensures that no skins2 window is enabled before leaving the
      Close function from the interface, and no new skins2 window will be
      enabled in a racy pattern while or after the Close function from the
      interface is running.
      
      The issue was highlighted in previous commit, including the commit
      04409ebd which required in its commit
      description that interface modules should outlive the vout window
      instances they provide, but didn't provide a mechanism to do so.
      
      The added mutex was removed in 6083d3f1
      because it was useless as-is. This commit adds a reference count of
      opened window, and a wait for this reference count to reach zero before
      ending the interface Close() function, which justify the use of a mutex.
      
      Note also that this patch uses the Enable/Disable lifecycle of the
      window to manage the reference count and skins2 resources, because
      there is an inversion between the playlist destruction and the
      interface destruction.
      
      We cannot wait for the vout_window_t object to be destroyed while we're
      waiting in the interface Close(), since the vout is potentially reused
      up to the playlist destruction (or more precisely, input resource
      destruction) which can only happen after every interface is destroyed.
      
      The implementation here is a bit different to what has been done for
      other interfaces like Qt. The Qt interface is creating a new libvlc
      object and stashes the interface state there, while refcounting it.
      It means that the interface implementation itself will continue to exist
      even if the interface object is dead. It has particular benefit when
      the interface is not the usual interface but a dialog provider one.
      
      The submitted approach here tries to keep the lifecycle of the
      interface tied together with its object, to simplify the use of its
      object for variable or logging, and avoid unnecessary object allocation.
      a928eb17
    • Steve Lhomme's avatar
      direct3d9: fix the texture stretching · 86846565
      Steve Lhomme authored
      The destination texture (sys->sceneTexture) has the visible dimensions, not the
      decoder dimensions.
      
      Factorize the size processing for the stretching and the vertex computing.
      
      Ref. https://forum.videolan.org/viewtopic.php?f=14&t=159861
      86846565
    • Steve Lhomme's avatar
      vlc_thread: ensure thread names are not bigger than 16 bytes · a45953d0
      Steve Lhomme authored
      Some platforms may not accept longer names or will truncate it, so we stick to
      that size.
      
      It should work with gcc at least. It also works with LLVM14.
      a45953d0
    • Steve Lhomme's avatar
      vlc_thread: check the delay values when __builtin_constant_p is defined · c9cf3e67
      Steve Lhomme authored
      It exists in very old gcc and clang.
      
      VLC_WARN_CALL/VLC_ERROR_CALL may not warn though.
      
      Don't define check_delay/check_deadline otherwise and don't force the
      vlc_tick_sleep/vlc_tick_wait calls.
      c9cf3e67
    • Steve Lhomme's avatar
      vlc_common: define more attribute based defines using __has_attribute · 0ef98375
      Steve Lhomme authored
      Leave VLC_DEPRECATED_ENUM, VLC_FORMAT and VLC_FORMAT_ARG for now as they are
      more compiler specific.
      0ef98375