1. 11 Aug, 2022 8 commits
  2. 08 Aug, 2022 1 commit
  3. 05 Aug, 2022 5 commits
  4. 04 Aug, 2022 3 commits
  5. 03 Aug, 2022 1 commit
  6. 01 Aug, 2022 1 commit
  7. 29 Jul, 2022 1 commit
  8. 26 Jul, 2022 9 commits
  9. 24 Jul, 2022 7 commits
  10. 23 Jul, 2022 1 commit
    • Sebastian Keller's avatar
      qt: unmap indirection X11 window before reparenting it back to root · 97244141
      Sebastian Keller authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      Reparenting a mapped window to root causes it to become a toplevel
      window and can cause window managers to reparent the window themselves
      to show their decorations.
      
      This could happen in two situations:
      
      1. Theoretically it could happen briefly between WindowReleased and
         WindowClose.
      2. It could trigger a race between VLC and the WM if there is a quick
         sequence of WindowOpen -> WindowReleased -> WindowClose -> WindowOpen
         such as when using single instance mode. If the X-server in this
         situation happens to re-use the XID of the X11 indirection window
         from the first WindowOpen for the second WindowOpen, this could
         result in the following race:
         - VLC creates a new X11 indirection window, reparents and maps it
         - VLC reparents it to root
         - VLC closes the connection, freeing the XID
         - VLC opens a new connection
         - VLC creates a new indirection window with the same XID as before
           and reparents and maps it
         -...
      97244141
  11. 20 Jul, 2022 3 commits