From 7e47fa5242df547f924b0a140286b3d90caf65a7 Mon Sep 17 00:00:00 2001
From: Pierre Lamot <pierre@videolabs.io>
Date: Tue, 29 Mar 2022 14:21:27 +0200
Subject: [PATCH] qt: add missing virtual destructor
---
modules/gui/qt/dialogs/vlm/vlm.hpp | 1 +
modules/gui/qt/maininterface/compositor.hpp | 1 +
modules/gui/qt/medialibrary/medialib.hpp | 1 +
modules/gui/qt/medialibrary/mlfoldersmodel.hpp | 1 +
modules/gui/qt/util/asynctask.hpp | 2 ++
modules/gui/qt/util/selectable_list_model.hpp | 2 ++
6 files changed, 8 insertions(+)
diff --git a/modules/gui/qt/dialogs/vlm/vlm.hpp b/modules/gui/qt/dialogs/vlm/vlm.hpp
index cbaa5c89aa4a..f46a3f97a095 100644
--- a/modules/gui/qt/dialogs/vlm/vlm.hpp
+++ b/modules/gui/qt/dialogs/vlm/vlm.hpp
@@ -149,6 +149,7 @@ public:
VLMAWidget( VLMWrapper *, const QString& name, const QString& input,
const QString& inputOptions, const QString& output,
bool _enable, VLMDialog *parent, int _type = QVLM_Broadcast );
+ virtual ~VLMAWidget() = default;
virtual void update() = 0;
protected:
QLabel *nameLabel;
diff --git a/modules/gui/qt/maininterface/compositor.hpp b/modules/gui/qt/maininterface/compositor.hpp
index 85c123058830..e238e41b0309 100644
--- a/modules/gui/qt/maininterface/compositor.hpp
+++ b/modules/gui/qt/maininterface/compositor.hpp
@@ -94,6 +94,7 @@ public:
class QmlUISurface
{
public:
+ virtual ~QmlUISurface() = default;
virtual QQmlEngine* engine() const = 0;
virtual void setContent(QQmlComponent *component, QQuickItem *item) = 0;
diff --git a/modules/gui/qt/medialibrary/medialib.hpp b/modules/gui/qt/medialibrary/medialib.hpp
index c7619a91d59e..9bd07d0759fc 100644
--- a/modules/gui/qt/medialibrary/medialib.hpp
+++ b/modules/gui/qt/medialibrary/medialib.hpp
@@ -218,6 +218,7 @@ class RunOnMLThreadBaseRunner : public QObject, public QRunnable
{
Q_OBJECT
public:
+ virtual ~RunOnMLThreadBaseRunner() = default;
virtual void runUICallback() = 0;
virtual void cancel() = 0;
signals:
diff --git a/modules/gui/qt/medialibrary/mlfoldersmodel.hpp b/modules/gui/qt/medialibrary/mlfoldersmodel.hpp
index 92fd5b831cd0..9c79a6778f10 100644
--- a/modules/gui/qt/medialibrary/mlfoldersmodel.hpp
+++ b/modules/gui/qt/medialibrary/mlfoldersmodel.hpp
@@ -55,6 +55,7 @@ public:
};
MLFoldersBaseModel( QObject *parent = nullptr );
+ virtual ~MLFoldersBaseModel() = default;
void setCtx(MainCtx* ctx);
inline MainCtx* getCtx() { return m_ctx; }
diff --git a/modules/gui/qt/util/asynctask.hpp b/modules/gui/qt/util/asynctask.hpp
index 81fcc54022ab..e8d0a310ef2e 100644
--- a/modules/gui/qt/util/asynctask.hpp
+++ b/modules/gui/qt/util/asynctask.hpp
@@ -150,6 +150,8 @@ template <typename T>
class AsyncTask : public BaseAsyncTask
{
public:
+ virtual ~AsyncTask() = default;
+
virtual T execute() = 0;
/**
diff --git a/modules/gui/qt/util/selectable_list_model.hpp b/modules/gui/qt/util/selectable_list_model.hpp
index 4682e66bbba9..1c9b948906ea 100644
--- a/modules/gui/qt/util/selectable_list_model.hpp
+++ b/modules/gui/qt/util/selectable_list_model.hpp
@@ -32,6 +32,8 @@ public:
SelectableListModel(QObject *parent = nullptr) :
QAbstractListModel(parent) {}
+ virtual ~SelectableListModel() = default;
+
Q_INVOKABLE bool isSelected(int index) const;
Q_INVOKABLE void setSelected(int index, bool selected);
Q_INVOKABLE void toggleSelected(int index);
--
GitLab