From 65bd3a1a9aead42fcd353024d137277c9ec73fd7 Mon Sep 17 00:00:00 2001
From: Fatih Uzunoglu <fuzun54@outlook.com>
Date: Fri, 29 Jul 2022 18:31:55 +0300
Subject: [PATCH] qml: remove the effect from playlist overlay menu
Visual pleasure the effect provides is not justified due to the side effects the effect causes.
---
.../gui/qt/playlist/qml/PlaylistListView.qml | 3 ---
modules/gui/qt/widgets/qml/OverlayMenu.qml | 19 ++++---------------
2 files changed, 4 insertions(+), 18 deletions(-)
diff --git a/modules/gui/qt/playlist/qml/PlaylistListView.qml b/modules/gui/qt/playlist/qml/PlaylistListView.qml
index 33cc65ecbf42..9315c5f1312e 100644
--- a/modules/gui/qt/playlist/qml/PlaylistListView.qml
+++ b/modules/gui/qt/playlist/qml/PlaylistListView.qml
@@ -20,7 +20,6 @@ import QtQuick.Controls 2.4
import QtQuick.Templates 2.4 as T
import QtQuick.Layouts 1.11
import QtQml.Models 2.2
-import QtGraphicalEffects 1.0
import org.videolan.vlc 0.1
@@ -144,8 +143,6 @@ Control {
isRight: true
rightPadding: VLCStyle.margin_xsmall + VLCStyle.applicationHorizontalMargin
bottomPadding: VLCStyle.margin_large + root.bottomPadding
-
- effectSource: contentItem
}
}
diff --git a/modules/gui/qt/widgets/qml/OverlayMenu.qml b/modules/gui/qt/widgets/qml/OverlayMenu.qml
index c87faa486fad..21e5ee170d3f 100644
--- a/modules/gui/qt/widgets/qml/OverlayMenu.qml
+++ b/modules/gui/qt/widgets/qml/OverlayMenu.qml
@@ -57,8 +57,6 @@ FocusScope {
listView.resetStack()
}
- property alias effectSource: effect.source
-
property alias scrollBarActive: scrollBar.active
visible: false
@@ -103,9 +101,11 @@ FocusScope {
}
}
- Item {
+ Rectangle {
id: parentItem
+ color: root.colors.bg
+
anchors {
top: parent.top
bottom: parent.bottom
@@ -114,6 +114,7 @@ FocusScope {
left: isRight ? undefined : parent.left
}
+ // TODO: Qt >= 5.12 use TapHandler
MouseArea {
anchors.fill: parent
hoverEnabled: true
@@ -121,18 +122,6 @@ FocusScope {
acceptedButtons: Qt.NoButton
}
- FrostedGlassEffect {
- id: effect
- anchors.fill: parent
-
- source: backgroundItem
-
- tint: VLCStyle.colors.topBanner
-
- tintStrength: 0.0
- exclusionStrength: 0.1
- }
-
ListView {
id: listView
--
GitLab