From 58a785a56ec1f8685c1d546f5ca2d4bccbff286a Mon Sep 17 00:00:00 2001 From: Erwan Tulou <erwan10@videolan.org> Date: Thu, 24 Dec 2009 09:36:37 +0100 Subject: [PATCH] skins(Linux) : fix crash with a few skins (e.g Orangeade) and xcb_x11 On X11, windows are created with a 1x1 size and updated later on. In some context, vout_display can catch this 1x1 size before the size is updated. This results in a crash in swcaler.c which gets a 1x0 size (division by zero) Changing default to 10x10 solves the problem. --- modules/gui/skins2/x11/x11_window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/gui/skins2/x11/x11_window.cpp b/modules/gui/skins2/x11/x11_window.cpp index 9b7188f52e2c..d450d0d9cd7d 100644 --- a/modules/gui/skins2/x11/x11_window.cpp +++ b/modules/gui/skins2/x11/x11_window.cpp @@ -88,7 +88,7 @@ X11Window::X11Window( intf_thread_t *pIntf, GenericWindow &rWindow, } // Create the window - m_wnd = XCreateWindow( XDISPLAY, m_wnd_parent, -10, 0, 1, 1, 0, 0, + m_wnd = XCreateWindow( XDISPLAY, m_wnd_parent, -10, 0, 10, 10, 0, 0, InputOutput, CopyFromParent, valuemask, &attr ); // wait for X server to process the previous commands -- GitLab