if an external screen is connected we're not showing the tracklabel anymore but display
that information as part of the external views title (closes ##222)

* position indicator in the middle of the movieViewController
* simplify state code and only show the indicator for buffering when we are not in paused mode before
since we never get an event that we're done with buffering (closes #306)

(cherry picked from commit 19c863d2)

(closes #269)

add nullability to outputview

This commit also removes old references to old podlibs and simplifies imports

VLCKeychainCoordinator: Fix that a playing video is not visible after dismissing the passcodecontroller

After coming back into the app from background and entering a password we had two titlebars.
Now we check for nil and superviews to avoid doubling (closes #157)

When we refactored we didn't pass the movieView to the external screen when displaying externally
This worked well for chromecast and mirroring but sadly not for attaching an external screen via HDMI
(closes #263)

(cherry picked from commit 10de9b62)

(closes #258)

(cherry picked from commit 7c7fea09)

The behavior is now in sync with youtube by limiting pitch to -90 and 90
This fixes issues were the user would experience jumps while panning

(cherry picked from commit 9512e0d8)

When the renderer is disconnected we want to hide the playing Externally view
When we mirror the screen we don't want to show it either so we just check if we have a renderer

(cherry picked from commit 8e664031)

This also makes every ViewController responsible for the correct statusbarstyle,
which also changes with a theme change

Refactor some code of chromecast and external displays

(cherry picked from commit d57be5a9)

on iPad with iOS 9 and higher shouldAutorotate is never called since all orientations are supported by default when
we support multitasking. This lead to no rotationlock when interfacelock was enabled or a 360 video was played.
We're now using supportedInterfaceOrientations: and lock 360 videos to portrait and for interfacelock we save the current orientation and return it.

lastEuler.pitch was accidentally set twice which resulted in jumping and
removing the screenscale + adjusting the zoomfactor makes panning and zooming more responsive

adjusted Bool properties from nonatomic to assign
turned interfacelock off for 360Videos

Note that string literals are being used all over the project to create
identifiers. A new file containing all identifier literals should be
created in the future.

Move from the sidemenu to use the tabbarcontroller, removed the MenuRevealButton
Add the MediaViewController and adjust the architecture in the VLCDisplayController
Created a subclass for the  view of the VLCDisplayController to let touches go through
Have only one instance of the Playbackcontroller that is going to be part of the tabbarcontroller
Changed the code that is currently calculating the miniviews position. This still needs fixing in case you turn the phone
Add sort button still need to implement functionality
Add Presentationtheme and darkmode. Move Appearance code into own class
Move the Wificell into the VLCServerListViewController

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

`_tapToSeekRecognizer` is not initialized when using an iPhoneX
which lead to a `NSInvalidArgumentException`
Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

This removes the confusion between screen brightness and video
filter brightness. Hence, it fixes the position of the brightness silder
position on a start of a media.
Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Since we're having two xibs for iPhone and iPad this block was necessary since the trackselector
on iPhone was previously displayed in the bottom of the phone, overlapped by the controls.
With the refactor we don't need device specific behavior anymore since the controls always appear centered on screen

Since the delegate is being overwritten by the currently playing view it needs
to be set again every time the view reappears to receive updates.

VLCMovieViewController: toggle between filltoCrop and previous aspect ratio for double tap on iPhoneX and refactored the aspect ratio code

(cherry picked from commit 9469da72)