1. 29 Mar, 2018 1 commit
    • Carola Nitz's avatar
      newUI: Introduction of the new UI · 1f034b70
      Carola Nitz authored
      Move from the sidemenu to use the tabbarcontroller, removed the MenuRevealButton
      Add the MediaViewController and adjust the architecture in the VLCDisplayController
      Created a subclass for the  view of the VLCDisplayController to let touches go through
      Have only one instance of the Playbackcontroller that is going to be part of the tabbarcontroller
      Changed the code that is currently calculating the miniviews position. This still needs fixing in case you turn the phone
      Add sort button still need to implement functionality
      Add Presentationtheme and darkmode. Move Appearance code into own class
      Move the Wificell into the VLCServerListViewController
      1f034b70
  2. 08 Mar, 2018 1 commit
  3. 24 Jan, 2018 1 commit
  4. 17 Jan, 2018 1 commit
  5. 06 Sep, 2017 1 commit
  6. 13 Jun, 2016 1 commit
  7. 02 May, 2016 1 commit
  8. 11 Feb, 2016 1 commit
    • Benjamin Adolphi's avatar
      Fixed finding of external subtitle files that are located on non libvlc browsed servers · 5088d8c1
      Benjamin Adolphi authored
      When playing a movie from a server on the local network that is not browsed with libvlc (e.g. an FTP server), subtitles that are located in an external file will not be discovered. This issue was observed on tvOS but should affect iOS as well.
      
      The problem seems to be that when the user selects an item, the following code is executed in the VLCNetworkServerBrowserViewController/VLCServerBrowsingTVViewController (if not in single playback mode):
      
      VLCMediaList *mediaList = self.serverBrowser.mediaList;
      [self.browsingController configureSubtitlesInMediaList:mediaList];
      [self.browsingController streamMediaList:mediaList startingAtIndex:index];
      
      This code tries to find and configure the subtitles for all of the entries in the mediaList. However, at the time when configureSubtitlesInMediaList is called, the mediaList is always empty, so no subtitles are being configured.
      
      The reason for the mediaList being empty is a timing issue. When the mediaList is retrieved from the responsible serverBrowser, it will create a new VLCMediaList from its items and add them to the list using the addMedia method. The problem here is that the addMedia method is adding the items to the list asynchronously on the main thread. Since the code that retrieves the list and then searches for the subtitles also runs on the main thread, the items will only be added after that code is finished.
      
      This commit solves the problem by having the server browser classes that do not use libvlc to discover media not create the media list when the list is requested but already when the browser has found out which files are in the current location.
      Signed-off-by: Felix Paul Kühne's avatarFelix Paul Kühne <fkuehne@videolan.org>
      5088d8c1
  9. 27 Jan, 2016 1 commit
  10. 19 Nov, 2015 1 commit
  11. 29 Oct, 2015 1 commit
  12. 27 Oct, 2015 3 commits
  13. 26 Oct, 2015 1 commit