Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
VLC-iOS
VLC-iOS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 314
    • Issues 314
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLAN
  • VLC-iOSVLC-iOS
  • Issues
  • #948

Closed
Open
Opened Dec 27, 2020 by Yannick Reifschneider@yreifschneider

Inconsistent delete media behaviour on Apple TV

On VLC Mobile on Apple TV in the Remote Playback Screen when you want to delete a file you have to toggle edit mode by long pressing on the remote and then pressing the play/pause button to bring up the delete media modal. But after restarting the app you can delete a file by pressing play/pause before entering the edit mode. This only works the first time, because after showing the "confirm delete" modal, the play/pause gesture recognizer is disabled.

I am not sure, what the expected behaviour of the screen should be, but as it is, the behaviour is inconsistent.

  1. Deleting a file should be possible regardless of being in edit mode by pressing "play/pause" button. This only works the first time after launching VLC.
  2. Deleting a file should only be possible when in editing mode. If this is the intended behaviour, then the "play/pause" button recognizer should be disabled on app startup and only be enabled after entering edit mode.

I would actually prefer the second behaviour and would even start playback of the selected media when pressing play/pause and not being in edit mode.

I am willing to provide a fixed PR when you can tell me, what the expected behaviour should be.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
3.3.0
Milestone
3.3.0
Assign milestone
Time tracking
None
Due date
None
Reference: videolan/vlc-ios#948