SMB is not discovered with Bonjour
Testing with VLC for TVOS version 3.1.0(394) and 3.0.11(405) on TVOS 13.4.8 model A1625, bonjour services with _smb._tcp are not shown or discovered, and "connect generic server" is not displayed in any conditions.
After investigating the logs, the following relevant messages are seen:
default 15:54:19.483194+1000 VLC-tvOS found bonjour service: Hector (_http._tcp.) default 15:54:19.486852+1000 VLC-tvOS found bonjour service: UniFi Controller (172_24_10_134) (_http._tcp.) default 15:54:20.691981+1000 VLC-tvOS VLC Library parsing failed for http://e6a0dbf2a325.local.:8080/libMediaVLC.xml with error Error Domain=NSXMLParserErrorDomain Code=1 "(null)"
It appears that once HTTP services are "found" the NSBonjourServices handler does not provide any other service types to the VLC process, and that has some impact on the "connect generic server" not appearing.
A customised build where I removed the _http._tcp service was then able to correctly discover _sftp._tcp services, but _smb._tcp services were still not found. It appears the order of services in the NSBonjourServices section of the plist may impact this, but I would prefer someone else is able to confirm this.
This may be unique to my network due to the fact I have _http._tcp services in bonjour and _smb._tcp with out netbios/wins. I also have multiple vlans and an avahi reflector between them which causes a large number of services to be present.
The expected behaviour is that generic server connect always appears, and that all types of bonjour servires (sftp, smb etc) are able to be displayed.