Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
VLC-iOS
VLC-iOS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 310
    • Issues 310
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 6
    • Merge Requests 6
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • VideoLAN
  • VLC-iOSVLC-iOS
  • Issues
  • #751

Closed
Open
Opened Oct 15, 2019 by Hugo Beauzée-Luyssen@chouquetteMaintainer
  • Report abuse
  • New issue
Report abuse New issue

Implement medialibrary's onUnhandledException callback

In recent medialibrary versions, a new callback was added: IMediaLibraryCb::onUnhandledException

The iOS application should implement it, as it will be called for various errors which are not explicitly caught on purpose (or not)

The minimal implementation should:

  • Check the 3rd parameter clearSuggested to see if a database clear is advised
  • Invoke IMediaLibrary::clearDatabase if advised (The medialib will take care of attempting to backup the playlists if true is being passed as restorePlaylists parameter

Since the appcenter provides the text associated with the unhandled exceptions, you don't need to have a manual bug reporter (but if you do, and include the database, I would be happy :D)

For what it's worth, implementing this callback will allow you to recover from such errors: https://appcenter.ms/orgs/videolan/apps/VLC-for-iOS-production/crashes/errors/207869758u/overview

Here, the database is reported as corrupted, so there's not much the medialib can do on its own. Instead, the application should request a clear, and the medialib will do what it can from there.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
3.2.3
Milestone
3.2.3 (Past due)
Assign milestone
Time tracking
None
Due date
None
2
Labels
Feature MediaLibrary
Assign labels
  • View project labels
Reference: videolan/vlc-ios#751