Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
VLC-iOS
VLC-iOS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 310
    • Issues 310
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 6
    • Merge Requests 6
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • VideoLAN
  • VLC-iOSVLC-iOS
  • Issues
  • #32

Closed
Open
Opened Jul 30, 2017 by Carola@caroMaintainer
  • Report abuse
  • New issue
Report abuse New issue

Architecture overhaul for folder code and move out parts to slim down the VLCLibraryViewController

The folder model and representation code should be separated from the view presentation in VLCLibraryController. There is a lot of state to handle the representation and creation of folders, the moving in and out of folders and for reordering within.

This leads to a lot of complexity and state that needs to be maintained like:

  • BOOL _inFolder;
  • _indexPaths (which are also used for deletion)
  • id _folderObject;

After solving the decoupling of MediaModel from the View representation we should move code handling folders out of the LibraryVC as well.

This includes methods like:

  • (void)rearrangeFolderTrackNumbersForRemovedItem:(MLFile *) mediaObject
  • (void)createFolder
  • (void)removeFromFolder
  • (void)createFolderWithName:(NSString *)folderName
  • (void)collectionView:(UICollectionView *)collectionView requestToMoveItemAtIndexPath:(NSIndexPath *)itemPath intoFolderAtIndexPath:(NSIndexPath *)folderPath
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
3.0.0
Milestone
3.0.0
Assign milestone
Time tracking
None
Due date
None
2
Labels
Maintenance Must Fix
Assign labels
  • View project labels
Reference: videolan/vlc-ios#32