GitLab

This also gets rid of the sharedinstance that is not necessary

Removes the extra button space in multiSectionMenu on landscape orientation
Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

That led to not showing the screen after initially setting a passcode.
Additionally resetting _avoidPromptingTouchID in completionblock avoids double showing
of the Touch id prompt

UIView and UILayoutguide both have layoutAnchors but no common protocol or class.
This gets rid of warnings and cleanes up code where instances of these classes were
assigned to the same variable.

from the NSUserdefaults.h :
 -synchronize is deprecated and will be marked with the NS_DEPRECATED macro in a future release.

Removed state and the passcodevalidation notification in favor of a completion block.
Removed > iOS8 check

Revert "VLCPlaybackController:send notifications about playback state change when libvlc actually changed it"

moving the notification exposed a variety of underlying issues that we can't fix for 3.0 so we're reverting this for 3.0
This reverts commit f9867ab3.

In presentFileSelectionActionController we first dismissed a presenting controller and in the completion handled the file selection.
Since there was no controller to be dismissed, the completion never got called.
Also replaced some deprecated API while at it and excluded some sharingactivities that included printing.

VLCPlaybackController:send notifications about playback state change when libvlc actually changed it

The notifications were sent too early which caused a wrong determination of isPlaying state in the VLCPlayerDisplayController who observed these
This led to a bug where media was actually playing but there were no controls to actually pause or stop the playback

The layoutGuides can be nil and crashh for <iOS 11 so we need to use self

In iOS 9 and 10 there might not be a Layoutguide and the constraints would cause a crash when guide was set to nil

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

This removes the confusion between screen brightness and video
filter brightness. Hence, it fixes the position of the brightness silder
position on a start of a media.
Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Since we're having two xibs for iPhone and iPad this block was necessary since the trackselector
on iPhone was previously displayed in the bottom of the phone, overlapped by the controls.
With the refactor we don't need device specific behavior anymore since the controls always appear centered on screen

When updateMetadataFromMediaPlayer was called not all fields were overwritten before
This led to titles not being hidden because the metadata had isAudioonly set from previous use.

The title was pinned to the top with 800 pixel more.
On iPad in landscape (height 720 )it was placed outside the views bounds
It's now placed in relation to the bottom of the view

The albumartwork was above the movieview in the viewhierachy on iPad so we moved it underneath it

VLC will now appear in the Files app under my iPhone. User shortcut into VLC from this entry point (closes #19157)

(cherry picked from commit e7c01a34)

(cherry picked from commit a6d0a2c2)

Since the delegate is being overwritten by the currently playing view it needs
to be set again every time the view reappears to receive updates.