GitLab

on iPad with iOS 9 and higher shouldAutorotate is never called since all orientations are supported by default when
we support multitasking. This lead to no rotationlock when interfacelock was enabled or a 360 video was played.
We're now using supportedInterfaceOrientations: and lock 360 videos to portrait and for interfacelock we save the current orientation and return it.

lastEuler.pitch was accidentally set twice which resulted in jumping and
removing the screenscale + adjusting the zoomfactor makes panning and zooming more responsive

adjusted Bool properties from nonatomic to assign
turned interfacelock off for 360Videos

Note that string literals are being used all over the project to create
identifiers. A new file containing all identifier literals should be
created in the future.

Move from the sidemenu to use the tabbarcontroller, removed the MenuRevealButton
Add the MediaViewController and adjust the architecture in the VLCDisplayController
Created a subclass for the  view of the VLCDisplayController to let touches go through
Have only one instance of the Playbackcontroller that is going to be part of the tabbarcontroller
Changed the code that is currently calculating the miniviews position. This still needs fixing in case you turn the phone
Add sort button still need to implement functionality
Add Presentationtheme and darkmode. Move Appearance code into own class
Move the Wificell into the VLCServerListViewController

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

`_tapToSeekRecognizer` is not initialized when using an iPhoneX
which lead to a `NSInvalidArgumentException`
Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

This removes the confusion between screen brightness and video
filter brightness. Hence, it fixes the position of the brightness silder
position on a start of a media.
Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Since we're having two xibs for iPhone and iPad this block was necessary since the trackselector
on iPhone was previously displayed in the bottom of the phone, overlapped by the controls.
With the refactor we don't need device specific behavior anymore since the controls always appear centered on screen

Since the delegate is being overwritten by the currently playing view it needs
to be set again every time the view reappears to receive updates.

VLCMovieViewController: toggle between filltoCrop and previous aspect ratio for double tap on iPhoneX and refactored the aspect ratio code

(cherry picked from commit 9469da72)

VLCMovieViewController: adjust the trackselector width constraint so that it is never too big for the screen

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

VLCMovieViewController: follow up to VLCMovieViewController: adopt the default behavior to switch video aspectratio between fullscreen and without notch on iPhone x

VLCMovieViewController: adopt the default behavior to switch video aspectratio between fullscreen and without notch on iPhone x

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>

VLCFullscreenMovieTVViewController, VLCMovieViewController : remove knowledge of mediaplayer and replace it by new methods from playbackcontroller

UIDevice: Remove the Speedcategory entirely. We're okay with VLCKit dropping frames if the device is too slow and for the UI the devices with iOS 9 are fast enough to be without tweaking

VLCPlaybackController: use scalefactor and added enum for different aspectratios to fix changing between different aspectratios

(cherry picked from commit 134fbd7e)

(cherry picked from commit c934384f)

VLCMovieViewcontroller: move navigationbar into Movieviewcontroller to use autolayoutconstraints and use the presenting navigationbar instead of creating a new one. This removes a lot of unnecessary code and fixes an issue where the navigation bar was colliding with the statusbar (closes #34)

Fixing player UI issue where Multi Selection menu wouldn't properly display its items because of orientation detection going wrong.

remove unnecessary removeGesturerecognizer calls. the array where these recognizers are called gets deallocated when the view gets deallocated