Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
7
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Open sidebar
VideoLAN
VLC-iOS
Commits
9b7d83d5
Commit
9b7d83d5
authored
Aug 17, 2013
by
Felix Paul Kühne
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Vastly improve accessibility support for playback and new VLC menu (close #9017)
parent
ab510f28
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
41 additions
and
0 deletions
+41
-0
AspenProject/UIBarButtonItem+Theme.m
AspenProject/UIBarButtonItem+Theme.m
+3
-0
AspenProject/VLCMovieViewController.m
AspenProject/VLCMovieViewController.m
+37
-0
NEWS
NEWS
+1
-0
Resources/en.lproj/Localizable.strings
Resources/en.lproj/Localizable.strings
+0
-0
No files found.
AspenProject/UIBarButtonItem+Theme.m
View file @
9b7d83d5
...
...
@@ -50,6 +50,9 @@
UIBarButtonItem
*
menuButton
=
[[
UIBarButtonItem
alloc
]
initWithImage
:[
UIImage
imageNamed
:
@"menuCone"
]
style
:
UIBarButtonItemStyleBordered
target
:
target
action
:
selector
];
[
menuButton
setBackgroundImage
:[
UIImage
imageNamed
:
@"button"
]
forState
:
UIControlStateNormal
barMetrics
:
UIBarMetricsDefault
];
[
menuButton
setBackgroundImage
:[
UIImage
imageNamed
:
@"buttonHighlight"
]
forState
:
UIControlStateHighlighted
barMetrics
:
UIBarMetricsDefault
];
menuButton
.
accessibilityLabel
=
NSLocalizedString
(
@"OPEN_VLC_MENU"
,
@""
);
menuButton
.
isAccessibilityElement
=
YES
;
return
menuButton
;
}
...
...
AspenProject/VLCMovieViewController.m
View file @
9b7d83d5
...
...
@@ -93,11 +93,46 @@
self
.
videoFilterView
.
hidden
=
YES
;
_videoFiltersHidden
=
YES
;
_hueLabel
.
text
=
NSLocalizedString
(
@"VFILTER_HUE"
,
@""
);
_hueSlider
.
accessibilityLabel
=
_hueLabel
.
text
;
_hueSlider
.
isAccessibilityElement
=
YES
;
_contrastLabel
.
text
=
NSLocalizedString
(
@"VFILTER_CONTRAST"
,
@""
);
_contrastSlider
.
accessibilityLabel
=
_contrastLabel
.
text
;
_contrastSlider
.
isAccessibilityElement
=
YES
;
_brightnessLabel
.
text
=
NSLocalizedString
(
@"VFILTER_BRIGHTNESS"
,
@""
);
_brightnessSlider
.
accessibilityLabel
=
_brightnessLabel
.
text
;
_brightnessSlider
.
isAccessibilityElement
=
YES
;
_saturationLabel
.
text
=
NSLocalizedString
(
@"VFILTER_SATURATION"
,
@""
);
_saturationSlider
.
accessibilityLabel
=
_saturationLabel
.
text
;
_saturationSlider
.
isAccessibilityElement
=
YES
;
_gammaLabel
.
text
=
NSLocalizedString
(
@"VFILTER_GAMMA"
,
@""
);
_gammaSlider
.
accessibilityLabel
=
_gammaLabel
.
text
;
_gammaSlider
.
isAccessibilityElement
=
YES
;
_playbackSpeedLabel
.
text
=
NSLocalizedString
(
@"PLAYBACK_SPEED"
,
@""
);
_playbackSpeedSlider
.
accessibilityLabel
=
_playbackSpeedLabel
.
text
;
_playbackSpeedSlider
.
isAccessibilityElement
=
YES
;
_positionSlider
.
accessibilityLabel
=
NSLocalizedString
(
@"PLAYBACK_POSITION"
,
@""
);
_positionSlider
.
isAccessibilityElement
=
YES
;
_timeDisplay
.
isAccessibilityElement
=
YES
;
_audioSwitcherButton
.
accessibilityLabel
=
NSLocalizedString
(
@"CHOOSE_AUDIO_TRACK"
,
@""
);
_audioSwitcherButton
.
isAccessibilityElement
=
YES
;
_subtitleSwitcherButton
.
accessibilityLabel
=
NSLocalizedString
(
@"CHOOSE_SUBTITLE_TRACK"
,
@""
);
_subtitleSwitcherButton
.
isAccessibilityElement
=
YES
;
_playbackSpeedButton
.
accessibilityLabel
=
_playbackSpeedLabel
.
text
;
_playbackSpeedButton
.
isAccessibilityElement
=
YES
;
_videoFilterButton
.
accessibilityLabel
=
NSLocalizedString
(
@"VIDEO_FILTER"
,
@""
);
_videoFilterButton
.
isAccessibilityElement
=
YES
;
_resetVideoFilterButton
.
accessibilityLabel
=
NSLocalizedString
(
@"VIDEO_FILTER_RESET_BUTTON"
,
@""
);
_resetVideoFilterButton
.
isAccessibilityElement
=
YES
;
_aspectRatioButton
.
accessibilityLabel
=
NSLocalizedString
(
@"VIDEO_ASPECT_RATIO_BUTTON"
,
@""
);
_aspectRatioButton
.
isAccessibilityElement
=
YES
;
_playPauseButton
.
accessibilityLabel
=
NSLocalizedString
(
@"PLAY_PAUSE_BUTTON"
,
@""
);
_playPauseButton
.
isAccessibilityElement
=
YES
;
_bwdButton
.
accessibilityLabel
=
NSLocalizedString
(
@"BWD_BUTTON"
,
@""
);
_bwdButton
.
isAccessibilityElement
=
YES
;
_fwdButton
.
accessibilityLabel
=
NSLocalizedString
(
@"FWD_BUTTON"
,
@""
);
_fwdButton
.
isAccessibilityElement
=
YES
;
_scrubHelpLabel
.
text
=
NSLocalizedString
(
@"PLAYBACK_SCRUB_HELP"
,
@""
);
...
...
@@ -300,6 +335,7 @@
self
.
positionSlider
.
value
=
0
.;
[
self
.
timeDisplay
setTitle
:
@""
forState
:
UIControlStateNormal
];
self
.
timeDisplay
.
accessibilityLabel
=
@""
;
if
(
!
[
self
_isMediaSuitableForDevice
])
{
UIAlertView
*
alert
=
[[
UIAlertView
alloc
]
initWithTitle
:
NSLocalizedString
(
@"DEVICE_TOOSLOW_TITLE"
,
@""
)
message
:[
NSString
stringWithFormat
:
NSLocalizedString
(
@"DEVICE_TOOSLOW"
,
@""
),
[[
UIDevice
currentDevice
]
model
],
self
.
mediaItem
.
title
]
delegate
:
self
cancelButtonTitle
:
NSLocalizedString
(
@"BUTTON_CANCEL"
,
@""
)
otherButtonTitles
:
NSLocalizedString
(
@"BUTTON_OPEN"
,
@""
),
nil
];
...
...
@@ -587,6 +623,7 @@
[
self
performSelector
:
@selector
(
_setPositionForReal
)
withObject
:
nil
afterDelay
:
0
.
3
];
VLCTime
*
newPosition
=
[
VLCTime
timeWithInt
:(
int
)(
_positionSlider
.
value
*
self
.
mediaItem
.
duration
.
intValue
)];
[
self
.
timeDisplay
setTitle
:
newPosition
.
stringValue
forState
:
UIControlStateNormal
];
self
.
timeDisplay
.
accessibilityLabel
=
[
NSString
stringWithFormat
:
@"%@: %@"
,
NSLocalizedString
(
@"PLAYBACK_POSITION"
,
@""
),
newPosition
.
stringValue
];
_positionSet
=
NO
;
[
self
_resetIdleTimer
];
}
...
...
NEWS
View file @
9b7d83d5
...
...
@@ -8,6 +8,7 @@
* Add Bonjour announcement for the WiFi Uploader's website (#8741)
* Add playback of audio-only media (#9044)
* Newly implemented menu and application flow (#9045)
* Improved VoiceOver and accessibility support (#9017)
* Add Deinterlace option (off by default, #8813)
* Device no longer goes to sleep during media downloads (#9062)
* Improved video output on external screens (#9055, #9079)
...
...
Resources/en.lproj/Localizable.strings
View file @
9b7d83d5
B
"CHOOSE_AUDIO_TRACK"="Choose Audio Track";
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment