fix crash for saving video and moving code out of VLCLibraryViewcontroller

Resources/af.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/ar.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/be.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/bs.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/ca.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/cs.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/da.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/de.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription"="Um das Video in deiner Bibliothek zu speichern brauchen wir Zugang zu einen Photos";
+"NSPhotoLibraryAddUsageDescription" = "Um das Video in deiner Bibliothek zu speichern brauchen wir Zugang zu einen Photos";

Resources/el.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/en-GB.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/en.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/es-MX.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/es.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/fa.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/fi.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/fo.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/fr.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/gl.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/he.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/hu.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/id.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/it.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/ja.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/km.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/ko.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/lv.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/mr.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/ms.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/nb.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/nl.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/pl.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/pt-BR.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/pt-PT.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/ro.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/ru.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/si.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/sk.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/sl.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/sr-Latn.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/sv.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/ta.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/tr.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/uk.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/zh-Hans.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

Resources/zh-Hant.lproj/InfoPlist.strings

+"NSPhotoLibraryUsageDescription" = "In order to save the video we will need access to your camera roll";
+"NSPhotoLibraryAddUsageDescription" = "In order to save the video we will need access to your camera roll";

SharedSources/VLCActivityViewControllerVendor.h

+/*****************************************************************************
+ * VLCActivityViewControllerVendor.h
+ * VLC for iOS
+ *****************************************************************************
+ * Copyright (c) 2017 VideoLAN. All rights reserved.
+ * $Id$
+ *
+ * Authors: Carola Nitz <nitz.carola # gmail.com>
+ *
+ * Refer to the COPYING file of the official project for license.
+ *****************************************************************************/
+
+@interface VLCActivityViewControllerVendor : NSObject
+
++ (UIActivityViewController *)activityViewControllerForFiles:(NSArray *)files presentingButton:(UIBarButtonItem *)button presentingViewController:(UIViewController *)controller;
+
+@end

SharedSources/VLCActivityViewControllerVendor.m

+/*****************************************************************************
+ * VLCActivityViewControllerVendor.m
+ * VLC for iOS
+ *****************************************************************************
+ * Copyright (c) 2017 VideoLAN. All rights reserved.
+ * $Id$
+ *
+ * Authors: Carola Nitz <nitz.carola # gmail.com>
+ *
+ * Refer to the COPYING file of the official project for license.
+ *****************************************************************************/
+
+#import "VLCActivityViewControllerVendor.h"
+#import "VLCOpeninActivity.h"
+#import <AssetsLibrary/AssetsLibrary.h>
+
+@implementation VLCActivityViewControllerVendor
+
++ (UIActivityViewController *)activityViewControllerForFiles:(NSArray *)files presentingButton:(UIBarButtonItem *)button presentingViewController:(UIViewController *)viewController;
+{
+    if (![files count]) {
+        [viewController vlc_showAlertWithTitle:NSLocalizedString(@"SHARING_ERROR_NO_FILES", nil)
+                             message:nil
+                         buttonTitle:NSLocalizedString(@"BUTTON_OK", nil)];
+        return nil;
+    }
+
+    VLCOpenInActivity *openInActivity = [[VLCOpenInActivity alloc] init];
+    openInActivity.presentingViewController = viewController;
+    openInActivity.presentingBarButtonItem = button;
+
+    UIActivityViewController *controller = [[UIActivityViewController alloc] initWithActivityItems:files applicationActivities:@[openInActivity]];
+
+    controller.completionHandler = ^(NSString *activityType, BOOL completed) {
+        APLog(@"UIActivityViewController finished with activity type: %@, completed: %i", activityType, completed);
+
+        // Provide feedback. This could cause a false positive if the user chose "Don't Allow" in the permissions dialog, and UIActivityViewController does not inform us of that, so check the authorization status.
+
+        // By the time this is called, the user has not had time to choose whether to allow access to the Photos library, so only display the message if we are truly sure we got authorization. The first time the user saves to the camera roll he won't see the confirmation because of this timing issue. This is better than showing a success message when the user had denied access. A timing workaround could be developed if needed through UIApplicationDidBecomeActiveNotification (to know when the security alert view was dismissed) or through other ALAssets APIs.
+        if (completed && [activityType isEqualToString:UIActivityTypeSaveToCameraRoll] && [ALAssetsLibrary authorizationStatus] == ALAuthorizationStatusAuthorized) {
+            [viewController vlc_showAlertWithTitle:NSLocalizedString(@"SHARING_SUCCESS_CAMERA_ROLL", nil)
+                                           message:nil
+                                       buttonTitle:NSLocalizedString(@"BUTTON_OK", nil)];
+        }
+    };
+    return controller;
+}
+@end

Sources/VLC for iOS-Info.plist

@@ -262,6 +262,10 @@
 		<key>NSAllowsArbitraryLoads</key>
 		<true/>
 	</dict>
+	<key>NSPhotoLibraryUsageDescription</key>
+	<string>In order to save the video we will need access to your camera roll</string>
+	<key>NSPhotoLibraryAddUsageDescription</key>
+	<string>In order to save the video we will need access to your camera roll</string>
 	<key>NSUserActivityTypes</key>
 	<array>
 		<string>org.videolan.vlc-ios.librarymode</string>

Sources/VLCLibraryViewController.m

@@ -2,7 +2,7 @@
  * VLCLibraryViewController.m
  * VLC for iOS
  *****************************************************************************
- * Copyright (c) 2013-2016 VideoLAN. All rights reserved.
+ * Copyright (c) 2013-2017 VideoLAN. All rights reserved.
  * $Id$
  *
  * Authors: Felix Paul Kühne <fkuehne # videolan.org>
@@ -15,22 +15,23 @@
  *****************************************************************************/
 
 #import "VLCLibraryViewController.h"
-#import "VLCMovieViewController.h"
-#import "VLCPlaylistTableViewCell.h"
-#import "VLCPlaylistCollectionViewCell.h"
-#import "NSString+SupportedMedia.h"
-#import "VLCBugreporter.h"
+
+#import "GTScrollNavigationBar.h"
+#import "LXReorderableCollectionViewFlowLayout.h"
+#import "VLCActivityViewControllerVendor.h"
 #import "VLCAppDelegate.h"
+#import "VLCBugreporter.h"
 #import "VLCFirstStepsViewController.h"
 #import "VLCFolderCollectionViewFlowLayout.h"
-#import "LXReorderableCollectionViewFlowLayout.h"
-#import "VLCOpenInActivity.h"
+#import "VLCKeychainCoordinator.h"
+#import "VLCMovieViewController.h"
 #import "VLCNavigationController.h"
+#import "VLCPlaylistCollectionViewCell.h"
+#import "VLCPlaylistTableViewCell.h"
+
+#import "NSString+SupportedMedia.h"
 #import "VLCPlaybackController+MediaLibrary.h"
-#import "VLCKeychainCoordinator.h"
-#import "GTScrollNavigationBar.h"
 
-#import <AssetsLibrary/AssetsLibrary.h>
 #import <CoreSpotlight/CoreSpotlight.h>
 
 /* prefs keys */
@@ -68,10 +69,9 @@ static NSString *kUsingTableViewToShowData = @"UsingTableViewToShowData";
 
     UIBarButtonItem *_selectAllBarButtonItem;
     UIBarButtonItem *_createFolderBarButtonItem;
-    UIBarButtonItem *_openInActivityBarButtonItem;
+    UIBarButtonItem *_shareBarButtonItem;
     UIBarButtonItem *_removeFromFolderBarButtonItem;
     UIBarButtonItem *_deleteSelectedBarButtonItem;
-    VLCOpenInActivity *_openInActivity;
 }
 
 @property (nonatomic, strong) UIBarButtonItem *displayModeBarButtonItem;
@@ -201,8 +201,8 @@ static NSString *kUsingTableViewToShowData = @"UsingTableViewToShowData";
     _removeFromFolderBarButtonItem.landscapeImagePhoneInsets = UIEdgeInsetsMake(1, 0, -1, 0);
     _removeFromFolderBarButtonItem.enabled = NO;
 
-    _openInActivityBarButtonItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemAction target:self action:@selector(actOnSelection:)];
-    _openInActivityBarButtonItem.enabled = NO;
+    _shareBarButtonItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemAction target:self action:@selector(share:)];
+    _shareBarButtonItem.enabled = NO;
 
     _deleteSelectedBarButtonItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemTrash target:self action:@selector(deleteSelection:)];
     _deleteFromTableView = NO;
@@ -214,7 +214,7 @@ static NSString *kUsingTableViewToShowData = @"UsingTableViewToShowData";
         fixedSpace.width *= 2;
     }
 
-    [self setToolbarItems:@[_openInActivityBarButtonItem,
+    [self setToolbarItems:@[_shareBarButtonItem,
                             fixedSpace,
                             _createFolderBarButtonItem,
                             [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemFlexibleSpace target:nil action:nil],
@@ -1553,7 +1553,7 @@ static NSString *kUsingTableViewToShowData = @"UsingTableViewToShowData";
 {
     NSUInteger count = [indexPaths count];
     if (!indexPaths || count == 0) {
-        _openInActivityBarButtonItem.enabled = NO;
+        _shareBarButtonItem.enabled = NO;
     } else {
         // Look for at least one MLFile
         @synchronized(_foundMedia) {
@@ -1561,7 +1561,7 @@ static NSString *kUsingTableViewToShowData = @"UsingTableViewToShowData";
                 id mediaItem = _foundMedia[[indexPaths[x] row]];
 
                 if ([mediaItem isKindOfClass:[MLFile class]] || [mediaItem isKindOfClass:[MLAlbumTrack class]] | [mediaItem isKindOfClass:[MLShowEpisode class]]) {
-                    _openInActivityBarButtonItem.enabled = YES;
+                    _shareBarButtonItem.enabled = YES;
                     return;
                 }
             }
@@ -1569,98 +1569,56 @@ static NSString *kUsingTableViewToShowData = @"UsingTableViewToShowData";
     }
 }
 
-- (void)actOnSelection:(UIBarButtonItem *)barButtonItem
+- (NSArray *)fileURLsFromSelection
 {
-    NSParameterAssert(barButtonItem);
-    if (!barButtonItem) {
-        APLog(@"Missing a UIBarButtonItem to present from");
-        return;
-    }
-
     NSArray *indexPaths = [self selectedIndexPaths];
 
-    NSUInteger count = indexPaths.count;
-    if (count) {
-        NSMutableArray /* NSURL */ *fileURLobjects = [[NSMutableArray alloc] initWithCapacity:count];
-
-        for (NSUInteger x = 0; x < count; x++) {
-            id mediaItem;
-            @synchronized (_foundMedia) {
-                mediaItem = _foundMedia[[indexPaths[x] row]];
-            }
-            NSURL *fileURL;
+    if (indexPaths.count == 0) return nil;
 
-            if ([mediaItem isKindOfClass:[MLFile class]])
-                fileURL = [(MLFile *) mediaItem url];
-            else if ([mediaItem isKindOfClass:[MLAlbumTrack class]])
-                fileURL = [[(MLAlbumTrack *) mediaItem anyFileFromTrack] url];
-            else if ([mediaItem isKindOfClass:[MLShowEpisode class]])
-                fileURL = [[(MLShowEpisode *) mediaItem anyFileFromEpisode] url];
+    NSMutableArray<NSURL*> *fileURLObjects = [[NSMutableArray alloc] initWithCapacity:indexPaths.count];
 
-            if ([fileURL isFileURL])
-                [fileURLobjects addObject:fileURL];
+    for (NSIndexPath *indexpath in indexPaths) {
+        id mediaItem;
+        @synchronized (_foundMedia) {
+            mediaItem = _foundMedia[[indexpath row]];
         }
+        NSURL *fileURL;
+
+        if ([mediaItem isKindOfClass:[MLFile class]]) {
+            fileURL = [(MLFile *) mediaItem url];
+        } else if ([mediaItem isKindOfClass:[MLAlbumTrack class]]) {
+            fileURL = [[(MLAlbumTrack *) mediaItem anyFileFromTrack] url];
+        } else if ([mediaItem isKindOfClass:[MLShowEpisode class]]) {
+            fileURL = [[(MLShowEpisode *) mediaItem anyFileFromEpisode] url];
+        }
+        if ([fileURL isFileURL]) {
+            [fileURLObjects addObject:fileURL];
+        }
+    }
+    return [fileURLObjects copy];
+}
 
-        if ([fileURLobjects count]) {
-            // Just in case, since we are facing a possible delay from code we do not control (UIActivityViewController), disable any possible changes to selection (or exit from this screen)
-            [[UIApplication sharedApplication] beginIgnoringInteractionEvents];
-
-            // The reason we do a dispatch_async to the main queue here even though we are already on the main queue is because UIActivityViewController blocks the main thread at some point (either during creation or presentation), which won't let UIKit draw our call to disable the toolbar items in time. On an actual device (where the lag can be seen when UIActivityViewController is presented for the first time during an applications lifetime) this makes for a much better user experience. If you have more items to share the lag may be greater.
-            dispatch_async(dispatch_get_main_queue(), ^{
-                _openInActivity = [[VLCOpenInActivity alloc] init];
-                _openInActivity.presentingViewController = self;
-                _openInActivity.presentingBarButtonItem = barButtonItem;
-
-                dispatch_block_t enableInteractionBlock = ^{
-                    // Strangely makeObjectsPerformSelector:withObject has trouble here (when called from presentViewController:animated:completion:)
-                    // [self.navigationController.toolbar.items makeObjectsPerformSelector:@selector(setEnabled:) withObject:@(YES)];
-                    for (UIBarButtonItem *item in self.navigationController.toolbar.items) {
-                        if (_removeFromFolderBarButtonItem && !_inFolder) {
-                            continue;
-                        }
-                        item.enabled = YES;
-                    }
-
-                    if ([[UIApplication sharedApplication] isIgnoringInteractionEvents]) {
-                        [[UIApplication sharedApplication] endIgnoringInteractionEvents];
-                    }
-                };
-
-                UIActivityViewController *controller = [[UIActivityViewController alloc] initWithActivityItems:fileURLobjects applicationActivities:@[_openInActivity]];
-                if (SYSTEM_RUNS_IOS8_OR_LATER)
-                    controller.popoverPresentationController.sourceView = self.navigationController.toolbar;
-
-                controller.completionHandler = ^(NSString *activityType, BOOL completed) {
-                    APLog(@"UIActivityViewController finished with activity type: %@, completed: %i", activityType, completed);
-
-                    // Provide some feedback if saving media to the Camera Roll. Note that this could cause a false positive if the user chooses "Don't Allow" in the permissions dialog, and UIActivityViewController does not inform us of that, so check the authorization status.
-
-                    // By the time this is called, the user has not had time to choose whether to allow access to the Photos library, so only display the message if we are truly sure we got authorization. The first time the user saves to the camera roll he won't see the confirmation because of this timing issue. This is better than showing a success message when the user had denied access. A timing workaround could be developed if needed through UIApplicationDidBecomeActiveNotification (to know when the security alert view was dismissed) or through other ALAssets APIs.
-                    if (completed && [activityType isEqualToString:UIActivityTypeSaveToCameraRoll] && [ALAssetsLibrary authorizationStatus] == ALAuthorizationStatusAuthorized) {
-                        VLCAlertView *alertView = [[VLCAlertView alloc] initWithTitle:NSLocalizedString(@"SHARING_SUCCESS_CAMERA_ROLL", nil)
-                                                                              message:nil
-                                                                             delegate:nil
-                                                                    cancelButtonTitle:NSLocalizedString(@"BUTTON_OK", nil)
-                                                                    otherButtonTitles:nil];
-                        [alertView show];
-                    }
-                    _openInActivity = nil;
+- (void)share:(UIBarButtonItem *)barButtonItem
+{
+    NSParameterAssert(barButtonItem);
+    if (!barButtonItem) {
+        APLog(@"Missing a UIBarButtonItem to present from");
+        return;
+    }
+    //disable any possible changes to selection (or exit from this screen)
+    [[UIApplication sharedApplication] beginIgnoringInteractionEvents];
 
-                    // Just in case, we could call enableInteractionBlock here. Since we are disabling touch interaction for the entire UI, to be safe that we return to the proper state: re-enable everything (if presentViewController:animated:completion: failed for some reason). But UIApplication gives us a warning even if we check isIgnoringInteractionEvents, so do not call it for now.
-                    // enableInteractionBlock();
-                };
-                [self.navigationController presentViewController:controller animated:YES completion:enableInteractionBlock];
-            });
-            return;
+    UIActivityViewController *controller = [VLCActivityViewControllerVendor activityViewControllerForFiles:[self fileURLsFromSelection] presentingButton:barButtonItem presentingViewController:self];
+    if (!controller) {
+        [[UIApplication sharedApplication] endIgnoringInteractionEvents];
+    } else {
+        if (SYSTEM_RUNS_IOS8_OR_LATER) {
+            controller.popoverPresentationController.sourceView = self.navigationController.toolbar;
         }
+        [self.navigationController presentViewController:controller animated:YES completion:^{
+            [[UIApplication sharedApplication] endIgnoringInteractionEvents];
+        }];
     }
-
-    VLCAlertView *alertView = [[VLCAlertView alloc] initWithTitle:NSLocalizedString(@"SHARING_ERROR_NO_FILES", nil)
-                                                          message:nil
-                                                         delegate:nil
-                                                cancelButtonTitle:NSLocalizedString(@"BUTTON_OK", nil)
-                                                otherButtonTitles:nil];
-    [alertView show];
 }
 
 #pragma mark - properties

VLC-iOS-Debug-Info.plist

@@ -252,6 +252,10 @@
 		<key>NSAllowsArbitraryLoads</key>
 		<true/>
 	</dict>
+	<key>NSPhotoLibraryAddUsageDescription</key>
+	<string>In order to save the video we will need access to your camera roll</string>
+	<key>NSPhotoLibraryUsageDescription</key>
+	<string>In order to save the video we will need access to your camera roll</string>
 	<key>NSUserActivityTypes</key>
 	<array>
 		<string>org.videolan.vlc-ios.librarymode</string>

VLC-iOS-no-watch-Debug-Info.plist

@@ -252,6 +252,10 @@
 		<key>NSAllowsArbitraryLoads</key>
 		<true/>
 	</dict>
+    <key>NSPhotoLibraryAddUsageDescription</key>
+    <string>In order to save the video we will need access to your camera roll</string>
+    <key>NSPhotoLibraryUsageDescription</key>
+    <string>In order to save the video we will need access to your camera roll</string>
 	<key>NSUserActivityTypes</key>
 	<array>
 		<string>org.videolan.vlc-ios.librarymode</string>

VLC.xcodeproj/project.pbxproj

@@ -24,6 +24,16 @@
 		4171D35018A2C19000A16EF9 /* VLCFolderCollectionViewFlowLayout.m in Sources */ = {isa = PBXBuildFile; fileRef = 4171D34F18A2C19000A16EF9 /* VLCFolderCollectionViewFlowLayout.m */; };
 		417CDA231A48D1F300D9ACE7 /* VLCCloudServicesTableViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = 417CDA211A48D1F300D9ACE7 /* VLCCloudServicesTableViewController.m */; };
 		417CDA241A48D1F300D9ACE7 /* VLCCloudServicesTableViewController.xib in Resources */ = {isa = PBXBuildFile; fileRef = 417CDA221A48D1F300D9ACE7 /* VLCCloudServicesTableViewController.xib */; };
+		417E68691F307D8F00DB9BB2 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 417E68711F307D8F00DB9BB2 /* InfoPlist.strings */; };
+		417E686A1F307D8F00DB9BB2 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 417E68711F307D8F00DB9BB2 /* InfoPlist.strings */; };
+		417E686B1F307D8F00DB9BB2 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 417E68711F307D8F00DB9BB2 /* InfoPlist.strings */; };
+		417E686C1F307D8F00DB9BB2 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 417E68711F307D8F00DB9BB2 /* InfoPlist.strings */; };
+		417E686D1F307D8F00DB9BB2 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 417E68711F307D8F00DB9BB2 /* InfoPlist.strings */; };
+		417E686E1F307D8F00DB9BB2 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 417E68711F307D8F00DB9BB2 /* InfoPlist.strings */; };
+		417E686F1F307D8F00DB9BB2 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 417E68711F307D8F00DB9BB2 /* InfoPlist.strings */; };
+		417E68B91F321EFF00DB9BB2 /* VLCActivityViewControllerVendor.m in Sources */ = {isa = PBXBuildFile; fileRef = 417E68B81F321EFF00DB9BB2 /* VLCActivityViewControllerVendor.m */; };
+		417E68BA1F321EFF00DB9BB2 /* VLCActivityViewControllerVendor.m in Sources */ = {isa = PBXBuildFile; fileRef = 417E68B81F321EFF00DB9BB2 /* VLCActivityViewControllerVendor.m */; };
+		417E68BB1F321EFF00DB9BB2 /* VLCActivityViewControllerVendor.m in Sources */ = {isa = PBXBuildFile; fileRef = 417E68B81F321EFF00DB9BB2 /* VLCActivityViewControllerVendor.m */; };
 		4184AA151A5492070063DF5A /* VLCCloudStorageController.m in Sources */ = {isa = PBXBuildFile; fileRef = 4184AA141A5492070063DF5A /* VLCCloudStorageController.m */; };
 		41B93C011A53833B00102E8B /* VLCProgressView.m in Sources */ = {isa = PBXBuildFile; fileRef = 41B93C001A53833B00102E8B /* VLCProgressView.m */; };
 		41B93C051A53835300102E8B /* VLCCloudServiceCell.m in Sources */ = {isa = PBXBuildFile; fileRef = 41B93C031A53835300102E8B /* VLCCloudServiceCell.m */; };
@@ -1079,6 +1089,53 @@
 		417CDA201A48D1F300D9ACE7 /* VLCCloudServicesTableViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = VLCCloudServicesTableViewController.h; path = Sources/VLCCloudServicesTableViewController.h; sourceTree = SOURCE_ROOT; };
 		417CDA211A48D1F300D9ACE7 /* VLCCloudServicesTableViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = VLCCloudServicesTableViewController.m; path = Sources/VLCCloudServicesTableViewController.m; sourceTree = SOURCE_ROOT; };
 		417CDA221A48D1F300D9ACE7 /* VLCCloudServicesTableViewController.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; name = VLCCloudServicesTableViewController.xib; path = Resources/VLCCloudServicesTableViewController.xib; sourceTree = SOURCE_ROOT; };
+		417E68701F307D8F00DB9BB2 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68721F307DA900DB9BB2 /* ru */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ru; path = ru.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68731F307DAA00DB9BB2 /* de */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = de; path = de.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68741F307DAD00DB9BB2 /* fr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fr; path = fr.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68751F307DAF00DB9BB2 /* it */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = it; path = it.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68761F307DB100DB9BB2 /* ja */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ja; path = ja.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68771F307DB100DB9BB2 /* fi */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fi; path = fi.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68781F307DB200DB9BB2 /* id */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = id; path = id.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68791F307DB500DB9BB2 /* es */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = es; path = es.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E687A1F307DB600DB9BB2 /* da */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = da; path = da.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E687B1F307DB700DB9BB2 /* he */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = he; path = he.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E687C1F307DB800DB9BB2 /* nl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = nl; path = nl.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E687D1F307DB900DB9BB2 /* sk */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = sk; path = sk.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E687E1F307DBA00DB9BB2 /* tr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = tr; path = tr.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E687F1F307DBA00DB9BB2 /* uk */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = uk; path = uk.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68801F307DBC00DB9BB2 /* zh-Hans */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "zh-Hans"; path = "zh-Hans.lproj/InfoPlist.strings"; sourceTree = "<group>"; };
+		417E68811F307DBD00DB9BB2 /* zh-Hant */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "zh-Hant"; path = "zh-Hant.lproj/InfoPlist.strings"; sourceTree = "<group>"; };
+		417E68821F307DBE00DB9BB2 /* mr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = mr; path = mr.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68831F307DBF00DB9BB2 /* ca */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ca; path = ca.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68841F307DBF00DB9BB2 /* gl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = gl; path = gl.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68851F307DC000DB9BB2 /* bs */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = bs; path = bs.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68861F307DC100DB9BB2 /* el */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = el; path = el.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68871F307DC300DB9BB2 /* sl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = sl; path = sl.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68881F307DC400DB9BB2 /* pl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = pl; path = pl.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68891F307DC500DB9BB2 /* ar */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ar; path = ar.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E688A1F307DC500DB9BB2 /* ko */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ko; path = ko.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E688B1F307DC600DB9BB2 /* sv */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = sv; path = sv.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E688C1F307DC700DB9BB2 /* hu */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = hu; path = hu.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E688D1F307DC700DB9BB2 /* cs */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = cs; path = cs.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E688E1F307DC800DB9BB2 /* fa */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fa; path = fa.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E688F1F307DC900DB9BB2 /* es-MX */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "es-MX"; path = "es-MX.lproj/InfoPlist.strings"; sourceTree = "<group>"; };
+		417E68901F307DC900DB9BB2 /* ms */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ms; path = ms.lproj/InfoPlist.strings; sourceTree = "<group>"; };
+		417E68911F307DCA00DB9BB2 /* si */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = si; path = si.lproj/InfoPlist.strings; sourceTree = "<group>"; };