Skip to content
Snippets Groups Projects

Equalizer UI

Closed Nicolas Pomepuy requested to merge Aza/vlc-android:equalizer_ui into master

Description

Move the equalizer in a Bottom sheet Completely rework its UI Make vertical seekbars usable with DPAD Add a snapping option for bars

Motivation and Context

The equalizer was really ugly.

How Has This Been Tested?

Emulator 28/29

Screenshots / GIFs (if appropriate):

Screenshot_1559649244

Screenshot_1559649248

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which cleans up / improves existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING section of the README document.

Resolves

Fixes: #197 (closed)

Edited by Nicolas Pomepuy

Merge request reports

Merge request pipeline #7315 passed

Merge request pipeline passed for 85cf3a01

Approval is optional

Closed by Geoffrey MétaisGeoffrey Métais 5 years ago (Jun 5, 2019 8:31am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Pomepuy changed milestone to %3.2

    changed milestone to %3.2

  • Nicolas Pomepuy marked the checklist item I have read the CONTRIBUTING section of the README document. as completed

    marked the checklist item I have read the CONTRIBUTING section of the README document. as completed

  • added 1 commit

    • 49177c15 - Title style improvement + seekbar redesign

    Compare with previous version

  • added 1 commit

    • 85cf3a01 - Improve equalizer save dialog

    Compare with previous version

  • Merged

  • mentioned in issue #197 (closed)

  • Thanks for the redesign!
    here are some corrections for the new eq:

    1. the shadow of the button stay always visible (doesn't disappear) and add more space between the button and the title
      1

    2.1 "snap bands" wasn't easy to translate in some langs, so some (like in german) add a longer explanation to the title, when reaching the left edge the text is out of the screen - seems a correct padding (=0) is not defined

    2.2 the notice about delete the current setting isn't in full screen with and that's why the text is shorten inside (also in EN), but maybe a notice like "do you want to delete" would be more clear because the notice disappears very fast and the user don't release that he can undo the action here
    2

    1. this one is a little bit tricky because when you slide inadvertently between the sliders the whole eq dialog is been closed, happens mostly on the bands when you try to grab them above or below the action field
      3
  • mentioned in issue #929 (closed)

  • Author Maintainer
    1. fixed

    2.1 fixed

    2.2 It's the standard padding of the snackbar. As it has the same background as the equalizer, it's not really understandable though. It's probably easier to understand with the light them

    1. Not easy to do. If we get more report about that, we'll try to find a way to take care of it.
    1. both issues are still visible in the last nightlies
      1. fixed
        2.the light theme shows the whole snackbar (thanks), the content will be shorten to fit in it, on english (pic above) it's this strange issue with "not inline elements" (not on EN system default) , so this is ok for now.
    2. the most important area of the not sliding function will be between each band. For the above and below area it's ok not to turn off the closing dialog function but the touch point of each band should be as wide as possible, so we won't have any spaces between the bands because this it actually the area where you slide a lot.
    Edited by Michał Trzebiatowski
Please register or sign in to reply
Loading