video icon was incorrectly chosen because of MEDIA_FORCE_AUDIO flag

(cherry picked from commit 97462bd4)

(cherry picked from commit a4e133f1)

Calling stopSelf() could cause the service to be destroyed before
calling setForeground() and lead to a RemoteException

(cherry picked from commit 6be3523b)

Geoffrey Métais authored Jan 20, 2020 and Geoffrey Métais committed Jan 22, 2020

Fix #1156


(cherry picked from commit 84d7febc)

Geoffrey Métais authored Jan 13, 2020 and Geoffrey Métais committed Jan 13, 2020

(cherry picked from commit 6625b124)

enterPictureInPictureMode() must be called in onUserLeaveHint() to
support Picture-in-Picture in a multi-window environment such as
Chrome OS.

The current implemententation (calling the API in onPause()) causes
the following issues on Chrome OS:

- VLC enters PiP without being occluded, but just with another
  window activated. In a multi-window environment, we can't assume
  onPause() means the window gets hidden. As only one window can
  be resumed at the same time, it's possible that a window is
  fully visible, but paused.
- When some ChromeOS-specific system UI gets shown (e.g. Alt-Tab
  window cycler, Overview Mode), VLC enters PiP unexpectedly.

This patch moves switchToPopup() from onPause() to onUserLeaveHint()
to prevent those issues.

(cherry picked from commit f466ecb0)

canSwitchToVideo() calls getVideoTracksCount() which can block main
thread.

(cherry picked from commit 95c9aa0a)

Fix #1086


(cherry picked from commit ce2abf0a)

Geoffrey Métais authored Dec 24, 2019 and Geoffrey Métais committed Dec 24, 2019

Could happen if asptect ratio is extreme.


(cherry picked from commit ca418f49)

(cherry picked from commit 93e1983d)

Geoffrey Métais authored Dec 20, 2019 and Geoffrey Métais committed Dec 20, 2019

Fix #1138


(cherry picked from commit 5cd908b7)

(cherry picked from commit 282030aef5c238a9260bcf77ead32c99675a81ca)

(cherry picked from commit 65542175446f124d86cb0e540323707541dd79c6)

Geoffrey Métais authored Dec 19, 2019 and Nicolas Pomepuy committed Dec 19, 2019

(cherry picked from commit 704de593)

Fixes #1128

(cherry picked from commit 8ceeee5e)

Fixes #1134


(cherry picked from commit ea2b127e)

Fixes #1131


(cherry picked from commit 845b917b)

Geoffrey Métais authored Dec 18, 2019 and Geoffrey Métais committed Dec 19, 2019

(cherry picked from commit b1c99f29)

Fix #1129

(cherry picked from commit 32b5077b)

Geoffrey Métais authored Dec 17, 2019 and Nicolas Pomepuy committed Dec 17, 2019

Avoid a race condition where media is closed because we get the video
track too soon


(cherry picked from commit 9f549861)

(cherry picked from commit f342c179)

Fixes #1118


(cherry picked from commit a3d7b4f2)

(cherry picked from commit f2718497)

(cherry picked from commit 3a727247)

Geoffrey Métais authored Dec 12, 2019 and Nicolas Pomepuy committed Dec 12, 2019

(cherry picked from commit 0a423b55)

(cherry picked from commit 09b1c510)

Fixes #1122


(cherry picked from commit 4703fa12)

Geoffrey Métais authored Dec 11, 2019 and Nicolas Pomepuy committed Dec 11, 2019

(cherry picked from commit d4cb648e)