Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC-Android
Manage
Activity
Members
Labels
Plan
Issues
528
Issue boards
Milestones
Wiki
Code
Merge requests
15
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC-Android
Commits
bea54abb
Commit
bea54abb
authored
5 years ago
by
Nicolas Pomepuy
Browse files
Options
Downloads
Patches
Plain Diff
Fix player options item background
Fixes #1014 (cherry picked from commit
85fa57d4
)
parent
9f8a8c9a
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!233
Backport 3.2
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
vlc-android/res/drawable/advanced_option_focusable_background.xml
+5
-0
5 additions, 0 deletions
...oid/res/drawable/advanced_option_focusable_background.xml
vlc-android/res/layout/player_option_item.xml
+23
-19
23 additions, 19 deletions
vlc-android/res/layout/player_option_item.xml
with
28 additions
and
19 deletions
vlc-android/res/drawable/advanced_option_focusable_background.xml
0 → 100644
+
5
−
0
View file @
bea54abb
<?xml version="1.0" encoding="utf-8"?>
<selector
xmlns:android=
"http://schemas.android.com/apk/res/android"
>
<item
android:state_focused=
"true"
android:drawable=
"@color/orange500transparent"
/>
<item
android:drawable=
"@color/transparent"
/>
</selector>
\ No newline at end of file
This diff is collapsed.
Click to expand it.
vlc-android/res/layout/player_option_item.xml
+
23
−
19
View file @
bea54abb
<?xml version="1.0" encoding="utf-8"?>
<layout>
<data>
<variable
name=
"option"
type=
"org.videolan.vlc.gui.helpers.PlayerOption"
/>
name=
"option"
type=
"org.videolan.vlc.gui.helpers.PlayerOption"
/>
</data>
<androidx.constraintlayout.widget.ConstraintLayout
xmlns:android=
"http://schemas.android.com/apk/res/android"
xmlns:app=
"http://schemas.android.com/apk/res-auto"
android:layout_width=
"@dimen/player_option_width"
android:layout_height=
"wrap_content"
android:background=
"@drawable/advanced_option_focusable_background"
android:focusable=
"true"
android:padding=
"8dp"
>
<ImageView
android:id=
"@+id/option_icon"
android:layout_width=
"32dp"
android:layout_height=
"32dp"
android:layout_marginEnd=
"@dimen/default_margin"
app:layout_constraint
Top_toTop
Of=
"parent"
app:layout_constraint
Start
_toStartOf=
"
parent
"
app:layout_constraint
Bottom_toBottom
Of=
"parent"
app:layout_constraint
End_toStartOf=
"@+id/option_title"
/>
android:id=
"@+id/option_icon"
android:layout_width=
"32dp"
android:layout_height=
"32dp"
android:layout_marginEnd=
"@dimen/default_margin"
app:layout_constraint
Bottom_toBottom
Of=
"parent"
app:layout_constraint
End
_toStartOf=
"
@+id/option_title
"
app:layout_constraint
Start_toStart
Of=
"parent"
app:layout_constraint
Top_toTopOf=
"parent"
/>
<TextView
android:id=
"@+id/option_title"
android:layout_width=
"0dp"
android:layout_height=
"wrap_content"
app:layout_constraintTop_toTopOf=
"parent
"
app:layout_constraintBottom_toBottomOf=
"parent
"
app:layout_constraint
End_toEnd
Of=
"parent"
app:layout_constraint
Start
_toEndOf=
"
@+id/option_icon
"
android:textAppearance=
"@style/VLC.CtxTitle
"
android:text=
"@{option.title}
"
/>
android:id=
"@+id/option_title"
android:layout_width=
"0dp"
android:layout_height=
"wrap_content"
android:text=
"@{option.title}
"
android:textAppearance=
"@style/VLC.CtxTitle
"
app:layout_constraint
Bottom_toBottom
Of=
"parent"
app:layout_constraint
End
_toEndOf=
"
parent
"
app:layout_constraintStart_toEndOf=
"@+id/option_icon
"
app:layout_constraintTop_toTopOf=
"parent
"
/>
</androidx.constraintlayout.widget.ConstraintLayout>
</layout>
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment