Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC-Android
Manage
Activity
Members
Labels
Plan
Issues
528
Issue boards
Milestones
Wiki
Code
Merge requests
14
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC-Android
Commits
34ece746
Commit
34ece746
authored
7 years ago
by
Geoffrey Métais
Browse files
Options
Downloads
Patches
Plain Diff
Remove current playlist smoothscroll
Causes crash when swithing to album cover Close #247
parent
5b303100
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
vlc-android/res/xml/preferences_audio.xml
+0
-5
0 additions, 5 deletions
vlc-android/res/xml/preferences_audio.xml
vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.java
+1
-6
1 addition, 6 deletions
vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.java
with
1 addition
and
11 deletions
vlc-android/res/xml/preferences_audio.xml
+
0
−
5
View file @
34ece746
...
...
@@ -14,11 +14,6 @@
android:key=
"audio_save_repeat"
android:summary=
"@string/audio_save_repeat_summary"
android:title=
"@string/audio_save_repeat_title"
/>
<CheckBoxPreference
android:defaultValue=
"true"
android:key=
"animate_playlist_scroll"
android:summary=
"@string/playlist_animate_scroll_summary"
android:title=
"@string/playlist_animate_scroll_title"
/>
<ListPreference
android:defaultValue=
"0"
android:entries=
"@array/audio_title_alignment_list"
...
...
This diff is collapsed.
Click to expand it.
vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.java
+
1
−
6
View file @
34ece746
...
...
@@ -103,7 +103,6 @@ public class AudioPlayer extends PlaybackServiceFragment implements PlaybackServ
private
final
ConstraintSet
playlistConstraintSet
=
AndroidUtil
.
isICSOrLater
?
new
ConstraintSet
()
:
null
;
SharedPreferences
mSettings
;
private
boolean
mAnimateScroll
;
// Tips
private
static
final
String
PREF_PLAYLIST_TIPS_SHOWN
=
"playlist_tips_shown"
;
...
...
@@ -163,7 +162,6 @@ public class AudioPlayer extends PlaybackServiceFragment implements PlaybackServ
@Override
public
void
onStart
()
{
super
.
onStart
();
mAnimateScroll
=
mSettings
.
getBoolean
(
"animate_playlist_scroll"
,
true
);
}
public
void
onPopupMenu
(
View
anchor
,
final
int
position
)
{
...
...
@@ -358,10 +356,7 @@ public class AudioPlayer extends PlaybackServiceFragment implements PlaybackServ
@Override
public
void
onSelectionSet
(
int
position
)
{
if
(
mPlayerState
!=
BottomSheetBehavior
.
STATE_COLLAPSED
&&
mPlayerState
!=
BottomSheetBehavior
.
STATE_HIDDEN
)
{
if
(
mAnimateScroll
)
mBinding
.
songsList
.
smoothScrollToPosition
(
position
);
else
mBinding
.
songsList
.
scrollToPosition
(
position
);
mBinding
.
songsList
.
scrollToPosition
(
position
);
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment