Screenshot tool produces stretched image on Non-Hardware Accelerated VD.
Description
Using screenshot tool produces stretched/shrink images from the video output. Only on non-hardware accelerated video decode.
My device is 19:9 and the video is 16:9 that could mean there is a wrong method of screenshot tool. Maybe it does.
EDIT: Changed the title to non-* that I forgot to review before submitting MR.
Expected behavior
Taking screenshot tool directly from the video output does not affect the quality, aspect ratio, resolution, and black background (not on the video with black background).
Which is excellent, just like mpv it does work with/without Hardware Acceleration. No matter how fast or slow to process the image from video output but also to produce the original, and lossless image.
Actual behavior
Taking screenshot that includes black background (not on the video with black background), based on the phone's display has 19:9, 20:9, or any aspect ratio. And the result it shows stretched image.
And don't know what exactly the same picture quality of the image that uses jpg. If there is option to change with png format for clear image, then it is a good idea adding this feature.
Steps to reproduce
Before to test, you must have a device with 18:9, 19:9, 19.5:9, 20:9 or any aspect ratio, other than 16:9 display so we're using 16:9 video.
- Go to settings, Select Hardware Acceleration, and change the option to Disabled.
- Open a video with exactly 16:9 aspect ratio. Rotate the device to Landscape Mode.
- Set the video zoom to Best Fit.
- Use the screenshot tool by tapping with just 3 fingers.
Then compare it between the video and the screenshot we take on you gallery.
Also tested to take using screenshot tool in Landscape mode with Video Zoom Best Fit on a 16:9 video (not 9:16).
Screenshot / video
Comparing Phone's screenshot and VLC's screenshot tool. My device's Display Aspect Ratio is 19:9.
Hardware Acceleration: Disabled
See the difference.
Best Fit on 19:9 display, 16:9 Video (1080p), Landscape Mode (Real image)
Result after using screenshot tool on VLC
Fit to Screen on 19:9 display, 16:9 Video (1080p), Landscape Mode (Real Image)
Result after using screenshot tool on VLC
Best Fit on 19:9 display, 16:9 Video (1080p), Portrait Mode (Real Image)
Result after using screenshot tool on VLC
Video Source: https://webstatic.mihoyo.com/upload/static-resource/2021/09/15/c647973279cb5d6eb86b84e365e11f17_4337742741070191171.mp4
Context
App version
VLC for Android: 3.5.2 Beta 1 (2022-09-14) Revision 171876ab
Device Model
Cherry_Mobile Omega X
- MediaTek Helio P23 (MT6763V/V)
Android Version
Stock Android 9 (API 28)
App mode
Smartphone