Skip to content

Regression: Video player crashes on rotation

Description

Missing check if hudBinding is initialized prior to accessing playerOverlaySeekbar. See 43066f47.

FATAL EXCEPTION: main
Process: org.videolan.vlc.debug, PID: 19036
kotlin.UninitializedPropertyAccessException: lateinit property hudBinding has not been initialized
	at org.videolan.vlc.gui.video.VideoPlayerOverlayDelegate.getHudBinding(VideoPlayerOverlayDelegate.kt:98)
	at org.videolan.vlc.gui.video.VideoPlayerOverlayDelegate.showControls(VideoPlayerOverlayDelegate.kt:845)
	at org.videolan.vlc.gui.video.VideoPlayerActivity.onConfigurationChanged(VideoPlayerActivity.kt:706)
	at android.app.ActivityThread.performActivityConfigurationChanged(ActivityThread.java:5705)

Steps to reproduce

  1. Start video playback
  2. Rotate phone (without showing hud first)
  3. Observe crash

Context

App version

43066f47

Android version

11

Device model

Pixel 3

App mode

Smartphone