Skip to content

App crashing with rename dialog on orientation change

Description

When the "rename" dialog is opened, the app crashes when the orientation is changed

2020-05-25 08:04:51.340 5198-5198/org.videolan.vlc.debug E/VLC/VlcCrashHandler: java.lang.RuntimeException: Unable to start activity ComponentInfo{org.videolan.vlc.debug/org.videolan.vlc.gui.MainActivity}: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment org.videolan.vlc.gui.dialogs.RenameDialog: could not find Fragment constructor
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3341)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3485)
        at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5358)
        at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:5270)
        at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2045)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7478)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:549)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:941)
        at Android.MODEL(sdk_gphone_x86)
        at Android.VERSION(10)
        at Android.FINGERPRINT(google/sdk_gphone_x86/generic_x86_arm:10/RPP4.200409.015/6455311:user/release-keys)
     Caused by: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment org.videolan.vlc.gui.dialogs.RenameDialog: could not find Fragment constructor
        at androidx.fragment.app.Fragment.instantiate(Fragment.java:563)
        at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57)
        at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:390)
        at androidx.fragment.app.FragmentStateManager.<init>(FragmentStateManager.java:74)
        at androidx.fragment.app.FragmentManager.restoreSaveState(FragmentManager.java:2454)
        at androidx.fragment.app.FragmentController.restoreSaveState(FragmentController.java:196)
        at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:287)
        at androidx.appcompat.app.AppCompatActivity.onCreate(AppCompatActivity.java:106)
        at org.videolan.vlc.gui.BaseActivity.onCreate(BaseActivity.kt:30)
        at org.videolan.vlc.gui.AudioPlayerContainerActivity.onCreate(AudioPlayerContainerActivity.kt:119)
        at org.videolan.vlc.gui.MainActivity.onCreate(MainActivity.kt:79)
        at android.app.Activity.performCreate(Activity.java:7989)
        at android.app.Activity.performCreate(Activity.java:7978)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3316)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3485)
        at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5358)
        at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:5270)
        at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2045)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7478)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:549)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:941)
     Caused by: java.lang.NoSuchMethodException: org.videolan.vlc.gui.dialogs.RenameDialog.<init> []
        at java.lang.Class.getConstructor0(Class.java:2332)
        at java.lang.Class.getConstructor(Class.java:1728)
    	at androidx.fragment.app.Fragment.in

Expected behavior

Actual behavior

Steps to reproduce

  1. Rename a group
  2. Change orientation

Screenshot / video

Context

App version

master

Android version

Device model

Emu API R

App mode

Smartphone