Skip to content

GitLab

Switch branch/tag
  1. 03 Jul, 2014 1 commit
  3. 27 Jun, 2014 1 commit
  5. 26 Jun, 2014 1 commit
  7. 23 Jun, 2014 1 commit
    • Martin Storsjö's avatar
      Don't use the private bionic symbol __get_thread and pthread_internal_t · bdb58418
      Martin Storsjö authored 
      

Use pthread_self() for getting a thread ID - pthread_self()
has been available since API level 3.

After android 4.4, the __get_thread symbol has been hidden, and
the pthread_internal_t struct has been changed.

Previously this used the internal pthread_internal_t struct
(which didn't change up until after 4.4) to get the system
global kernel thread id. For the rwlock code, this is overkill -
using a processwide thread ID is enough.

(Note that a pthread_t is defined as long, but writerThreadId
which stores the return value from __get_thread_id is an int,
thus this workaround shouldn't be used on 64 bit builds. But
it's never necessary on 64 bit builds, since all the
rwlock functions always exist there - they're only provided
for compatibility with pre-2.3 android versions.)

This fixes running VLC on devices running current AOSP master,
and quite probably also is required on the next major
android version.

If VLC drops support for pre-2.2 devices, the pthread-condattr.c
and pthread-once.c files can be removed, and once support for
pre-2.3 devices is dropped, all of pthread-rwlocks.c can be
removed.
Signed-off-by: Martin Storsjö's avatarMartin Storsjö <martin@martin.st>
      bdb58418
  9. 22 Jun, 2014 2 commits
  11. 21 Jun, 2014 34 commits

VideoLAN code repository instance