GitLab

Yes, armeabi-v7a is too long to type

Since this is the future default toolchain of the Android NDK.

The diagnostic certainly implies that the shell script shall abort if
the version of the NDK is less than 11, though the previous case-check
only matched versions matching "11*".

This commit changes the implementation so that we check whether "$REL"
is greater-than-or-equal compared to 11.
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Use ndk-stack instead

Example:
$ adb logcat | $ANDROID_NDK/ndk-stack -sym .dbg/armeabi-v7a/2.1.0
$ $ANDROID_NDK/ndk-stack -sym .dbg/armeabi-v7a/2.1.0 -dump crash.txt

(cherry picked from commit 80650a65)

If an invalid option is passed to "-a" it make sense for us to abort
as early as possible. These changes can be summerized with;

  - do not rely on compile-libvlc.sh to diagnose invalid usage, and;
  - abort before any work is done if an invalid option is present.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Given that it is always nice to have helper functions declared in the
same area, these changes makes it so that "diagnostic" and "checkfail"
is defined at the same place.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Given that diagnostic output should be written to stderr and not
stdout, a function named "diagnostic" is introduced that echo's
whatever is passed to stderr.

Usage of "echo" in terms of diagnostics has been replaced by usage of
this newly added function.
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>