Commit e2c072b7 authored by Sergey Radionov's avatar Sergey Radionov Committed by Jean-Baptiste Kempf

ActiveX: "Toolbar" property now retun actual value

(but not "stub" VARIANT_FALSE, from times when toolbar was not implemented).
Signed-off-by: Jean-Baptiste Kempf's avatarJean-Baptiste Kempf <>
parent 76b933b5
......@@ -1369,21 +1369,7 @@ STDMETHODIMP VLCControl2::get_Toolbar(VARIANT_BOOL *visible)
if( NULL == visible )
return E_POINTER;
* Note to developers
* Returning the _b_toolbar is closer to the method specification.
* But returning True when toolbar is not implemented so not displayed
* could be bad for ActiveX users which rely on this value to show their
* own toolbar if not provided by the ActiveX.
* This is the reason why FALSE is returned, until toolbar get implemented.
/* DISABLED for now */
// *visible = varbool( _p_instance->getShowToolbar() );
*visible = VARIANT_FALSE;
*visible = varbool( _p_instance->getShowToolbar() != FALSE );
return S_OK;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment