medialibrary merge requestshttps://code.videolan.org/videolan/medialibrary/-/merge_requests2017-11-23T10:52:51Zhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/9Playlist rc72017-11-23T10:52:51ZAlexandre FernandezPlaylist rc7https://code.videolan.org/videolan/medialibrary/-/merge_requests/12Rework playlists2019-07-18T12:02:13ZHugo Beauzée-LuyssenRework playlistsThis MR addresses #67
Opinion & review welcome :)This MR addresses #67
Opinion & review welcome :)0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/13fix typo when compiling for Windows Store2019-07-18T12:02:18ZSteve Lhommefix typo when compiling for Windows Store0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/15Do not use the tchar API to find drives2019-07-18T12:02:27ZSteve LhommeDo not use the tchar API to find drivesAlways use the wide char API safely.Always use the wide char API safely.0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/14Rework MRL encode2019-07-18T12:02:22ZHugo Beauzée-LuyssenRework MRL encodeDon't encode anything which isn't:
- A path separator
- A unreserved character (alphanumerical + `-` `.` `_` `~`)
As per #73Don't encode anything which isn't:
- A path separator
- A unreserved character (alphanumerical + `-` `.` `_` `~`)
As per #730.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/17Reduce ci overhead2019-07-18T12:02:33ZHugo Beauzée-LuyssenReduce ci overheadRun all test jobs in the build job in order to:
- Not having to generate artifacts for each builds
- Save the overhead of spawning the 2 test tasks per platform
While we're at it, always run the coverage job on master, and add a UBsan/A...Run all test jobs in the build job in order to:
- Not having to generate artifacts for each builds
- Save the overhead of spawning the 2 test tasks per platform
While we're at it, always run the coverage job on master, and add a UBsan/Asan config0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/18Fix tasks for removable files2019-07-18T12:03:54ZHugo Beauzée-LuyssenFix tasks for removable files0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/16Rework thumbnails2019-07-18T12:04:08ZHugo Beauzée-LuyssenRework thumbnailsThis reworks the thumbnail handling, which mostly comes down to:
- Extracting the cover images from the medialibrary instead of relying on VLC
- Sharing the covers as much as possible between entities
What is yet to be solved:
* [x...This reworks the thumbnail handling, which mostly comes down to:
- Extracting the cover images from the medialibrary instead of relying on VLC
- Sharing the covers as much as possible between entities
What is yet to be solved:
* [x] How to handle attached artwork? Apparently there's no way to disable local art fetching when using libvlc. So if we reject everything from VLC, we lose attached artworks, if don't, we would end up duplicating the album cover for each tracks. Sadly we can't rely on the artwork MRL being "attachment://" when fetching it from the media, as it might or might not be extracted already after a preparsing (depending on which module was used, AFAICS)
Postponing a finer approach for VLC 4.0, where we can have a proper API to do the extraction. Mobile ports will always copy the thumbnails. When possible, the thumbnail will simply be a hardlink.
* [x] Use embedded artwork as a album cover
Postponed until we have a better embedded art management
* [x] Most likely fix win32 build breakage0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/19Fix refresh tasks2019-07-18T12:04:10ZHugo Beauzée-LuyssenFix refresh tasksThis should be completed by fixing #94This should be completed by fixing #940.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/20Fix refresh tasks2019-07-18T12:04:13ZHugo Beauzée-LuyssenFix refresh tasksShould complete the fix for #89Should complete the fix for #890.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/21Relocate video thumbnails2019-07-18T12:04:15ZHugo Beauzée-LuyssenRelocate video thumbnailsOtherwise if VLC finds some artwork, they end up being stored with an absolute URL, causing iOS not to be able to use themOtherwise if VLC finds some artwork, they end up being stored with an absolute URL, causing iOS not to be able to use them0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/22MetadataParser: Fix album creation/modification notifications2019-07-18T12:02:51ZHugo Beauzée-LuyssenMetadataParser: Fix album creation/modification notificationsFix #96Fix #960.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/23Notify on media meta changed2019-07-18T12:02:54ZHugo Beauzée-LuyssenNotify on media meta changed0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/24IMediaLibrary: Allow history to be filtered by media type2019-07-18T12:02:58ZHugo Beauzée-LuyssenIMediaLibrary: Allow history to be filtered by media typeFix #85Fix #850.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/26Create media with durations2019-07-18T12:03:04ZHugo Beauzée-LuyssenCreate media with durations0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/25Thumbnailer: Don't retry thumbnail generations2019-07-18T12:03:07ZHugo Beauzée-LuyssenThumbnailer: Don't retry thumbnail generationsIn case they fail, especially with a crash, we don't want to retry the
thumbnailing automatically.
We now always insert a failure record, before updating it with the path
to the generated thumbnail.
Fix #95In case they fail, especially with a crash, we don't want to retry the
thumbnailing automatically.
We now always insert a failure record, before updating it with the path
to the generated thumbnail.
Fix #950.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/27Media: Add removeFromHistory()2019-07-18T12:03:11ZHugo Beauzée-LuyssenMedia: Add removeFromHistory()Fix #90Fix #900.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/29IMediaLibraryCb: Add onEntryPointAdded2019-07-18T12:03:14ZHugo Beauzée-LuyssenIMediaLibraryCb: Add onEntryPointAddedfix #86fix #860.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/30IMediaLibrary: Provide a success state to onEntryPointAdded2019-07-18T12:03:17ZHugo Beauzée-LuyssenIMediaLibrary: Provide a success state to onEntryPointAddedFor consistency with other callbacks, and because we might try to add a
new entry point but fail to do so.
The callback was also emited a tiny bit too earlyFor consistency with other callbacks, and because we might try to add a
new entry point but fail to do so.
The callback was also emited a tiny bit too early0.5.xhttps://code.videolan.org/videolan/medialibrary/-/merge_requests/32Check number of columns2019-07-18T12:03:20ZHugo Beauzée-LuyssenCheck number of columns0.5.x