Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • M medialibrary
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 69
    • Issues 69
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • medialibrary
  • Issues
  • #354
Closed
Open
Issue created Jul 06, 2021 by Nicolas Pomepuy@AzaDeveloper

Android: migration needed to get rid of metadata

Historically, the Android app uses metadata to keep some media related data that were not implemented in the ML.

Now is the time to get rid of it for harmonization.

There are two metadata to get rid of:

  • IMedia::MetadataType::Seen has been used as the single source of truth (see vlc-android#2030 (closed)). IMedia::playCount() is never used anywhere in the app and has been corrupted by a misuse. The app indeed sets the progress to 1.0 at the start of the playback, making it marked as seen for an incomplete playback : https://code.videolan.org/videolan/vlc-android/-/blob/master/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt#L922

We have to migrate from the meta to the playCount to make it the new SSOT

  • IMedia::MetadataType::Progress (now obsolete) is still currently used in the app to resume the playback, when IMedia::progress() is used in the UI. It seems that both data are valid and no migration is needed here

EDIT: IMedia::MetadataType::Progress is still useful in case we don't know the media length. We use the meta to be able to resume the playback when the saved data in the Media table is useless (duration: -1 and progress -1) image__5_image__6_

Edited Jul 06, 2021 by Nicolas Pomepuy
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking

VideoLAN code repository instance