Fix #399

(cherry picked from commit 5a0ff489

)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit 68edc993

)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Fix #396

(cherry picked from commit 5a840647

)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Refs vlc-ios#906

(cherry picked from commit 6cf3412f

)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
(cherry picked from commit b2351a2d

)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

This fixes #392 for the stable branch.
!543 takes care of removing the constraint in the development branch

(cherry picked from commit 76bda149

)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Mehdi Sabwat authored Nov 08, 2021 and Hugo Beauzée-Luyssen committed Nov 24, 2021

fixes #254

(cherry picked from commit 24ae30be

)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
(cherry picked from commit 984443e7

)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

This mostly fixes cppcheck warnings about value not being read

Fix #370

Which can be used to trigger multiple runs of the same discovery, in
order to collect more profiling data

We always provide all the meta after preparse, and even if we weren't
storing all of those, we just return a default initialized string when
the meta wasn't stored.
This can be done with an std::array which costs nothing at runtime

Expose a single version that takes the string as value and expect the
value to be moved inside the parameter
This doesn't change the performances much but we now have a single
overload to maintain which clarifies the code a bit

Don't provide an in-place version and instead expect the input to be
moved into the parameter

This dates back from the old automatic retry helper which was removed a
while ago

We were already testing decode through toLocalPath, but this allows for
more specific & direct tests

By avoiding the construction of a dummy string to invoke strtoul on, the
decode function gains about 57.5%

This doesn't bench much yet, but will be helpfull in the near future

This will use the more efficients single char overloads