Fix cppcheck warnings

src/database/SqliteConnection.h

@@ -35,7 +35,7 @@ class SqliteConnection
 private:
     using RequestContext = std::unique_lock<std::mutex>;
 public:
-    SqliteConnection( const std::string& dbPath );
+    explicit SqliteConnection( const std::string& dbPath );
     // Returns the current thread's connection
     // This will initiate a connection if required
     sqlite3* getConn();

src/database/SqliteTools.h

@@ -40,7 +40,7 @@ namespace sqlite
 
 struct ForeignKey
 {
-    constexpr ForeignKey(unsigned int v) : value(v) {}
+    constexpr explicit ForeignKey(unsigned int v) : value(v) {}
     unsigned int value;
 };
 

src/discoverer/DiscovererWorker.cpp

@@ -26,6 +26,7 @@
 
 DiscovererWorker::DiscovererWorker()
     : m_run( true )
+    , m_cb( nullptr )
 {
 }
 

src/filesystem/unix/File.h

@@ -32,7 +32,7 @@ namespace fs
 class File : public IFile
 {
 public:
-    File( const std::string& filePath );
+    explicit File( const std::string& filePath );
     virtual ~File() = default;
 
     virtual const std::string& name() const override;

src/metadata_services/vlc/VLCMetadataService.h

@@ -34,7 +34,7 @@ class VLCMetadataService : public IMetadataService
 {
     struct Context
     {
-        Context(std::shared_ptr<Media> file_)
+        explicit Context(std::shared_ptr<Media> file_)
             : file( file_ )
         {
         }
@@ -44,7 +44,7 @@ class VLCMetadataService : public IMetadataService
     };
 
     public:
-        VLCMetadataService(const VLC::Instance& vlc);
+        explicit VLCMetadataService(const VLC::Instance& vlc);
 
         virtual bool initialize( IMetadataServiceCb *callback, MediaLibrary* ml ) override;
         virtual unsigned int priority() const override;

src/metadata_services/vlc/VLCThumbnailer.cpp

@@ -43,6 +43,8 @@
 
 VLCThumbnailer::VLCThumbnailer(const VLC::Instance &vlc)
     : m_instance( vlc )
+    , m_cb( nullptr )
+    , m_ml( nullptr )
 #ifdef WITH_EVAS
     , m_canvas( nullptr, &evas_free )
 #endif

src/metadata_services/vlc/VLCThumbnailer.h

@@ -45,7 +45,7 @@
 class VLCThumbnailer : public IMetadataService
 {
 public:
-    VLCThumbnailer( const VLC::Instance& vlc );
+    explicit VLCThumbnailer( const VLC::Instance& vlc );
     ~VLCThumbnailer();
     virtual bool initialize(IMetadataServiceCb *callback, MediaLibrary *ml) override;
     virtual unsigned int priority() const override;