Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
VideoLAN
medialibrary
Commits
b1b0adad
Commit
b1b0adad
authored
Mar 29, 2018
by
Hugo Beauzée-Luyssen
Browse files
MetadataParser: Don't check for nullptr album
parent
9bc6e16a
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/metadata_services/MetadataParser.cpp
View file @
b1b0adad
...
...
@@ -707,6 +707,7 @@ bool MetadataParser::link( Media& media, std::shared_ptr<Album> album,
assert
(
artist
!=
nullptr
);
albumArtist
=
artist
;
}
assert
(
album
!=
nullptr
);
// We might modify albumArtist later, hence handle thumbnails before.
// If we have an albumArtist (meaning the track was properly tagged, we
...
...
@@ -717,7 +718,7 @@ bool MetadataParser::link( Media& media, std::shared_ptr<Album> album,
if
(
albumArtist
!=
nullptr
&&
albumArtist
->
id
()
!=
UnknownArtistID
&&
albumArtist
->
id
()
!=
VariousArtistID
&&
albumArtist
->
artworkMrl
().
empty
()
==
true
&&
album
!=
nullptr
&&
album
->
artworkMrl
().
empty
()
==
false
)
album
->
artworkMrl
().
empty
()
==
false
)
albumArtist
->
setArtworkMrl
(
album
->
artworkMrl
(),
Thumbnail
::
Origin
::
Album
);
// Until we have a better artwork extraction/assignation, simply do the same
...
...
@@ -725,7 +726,7 @@ bool MetadataParser::link( Media& media, std::shared_ptr<Album> album,
if
(
artist
!=
nullptr
&&
artist
->
id
()
!=
UnknownArtistID
&&
artist
->
id
()
!=
VariousArtistID
&&
artist
->
artworkMrl
().
empty
()
==
true
&&
album
!=
nullptr
&&
album
->
artworkMrl
().
empty
()
==
false
)
album
->
artworkMrl
().
empty
()
==
false
)
artist
->
setArtworkMrl
(
album
->
artworkMrl
(),
Thumbnail
::
Origin
::
Album
);
if
(
albumArtist
!=
nullptr
)
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment