From 85cac5738ce9348cf93f5bd27d01ea99ba8d95fa Mon Sep 17 00:00:00 2001
From: llyyr <llyyr.public@gmail.com>
Date: Sat, 16 Sep 2023 20:29:17 +0530
Subject: [PATCH] filters: remove incorrectly named bcspline alias
Hermite is its own filter where B=C=0. This just causes confusion and
Hermite isn't exactly a popular filter, so remove this altogether
because it's trivial to set B and C params to 0 anyway.
---
src/filters.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/src/filters.c b/src/filters.c
index bf352999d..24e75af92 100644
--- a/src/filters.c
+++ b/src/filters.c
@@ -475,14 +475,6 @@ const struct pl_filter_function pl_filter_function_bcspline = {
.params = {0.5, 0.5},
};
-static const struct pl_filter_function filter_function_hermite = {
- .name = "hermite", // alias
- .tunable = {true, true},
- .weight = bcspline,
- .radius = 2.0,
- .params = {0.5, 0.5},
-};
-
const struct pl_filter_function pl_filter_function_catmull_rom = {
.tunable = {true, true},
.weight = bcspline,
@@ -613,7 +605,6 @@ const struct pl_filter_function * const pl_filter_functions[] = {
&pl_filter_function_jinc,
&pl_filter_function_sphinx,
&pl_filter_function_bcspline,
- &filter_function_hermite, // alias
&pl_filter_function_catmull_rom,
&pl_filter_function_mitchell,
&pl_filter_function_robidoux,
@@ -961,7 +952,6 @@ const struct pl_filter_function_preset pl_filter_function_presets[] = {
{"jinc", &pl_filter_function_jinc},
{"sphinx", &pl_filter_function_sphinx},
{"bcspline", &pl_filter_function_bcspline},
- {"hermite", &filter_function_hermite}, // alias
{"catmull_rom", &pl_filter_function_catmull_rom},
{"mitchell", &pl_filter_function_mitchell},
{"robidoux", &pl_filter_function_robidoux},
--
GitLab