Skip to content

pl_shader_decode_color does not adhere to documentation anymore

Documentation of pl_shader_decode_color states that:

// Note: This function always returns PC-range RGB with independent alpha.
// It mutates the pl_color_repr to reflect the change.

This is no longer true as of 0067206f.

Reading commit message of the above commit, I don't understand the following part:

pl_color_repr_encode/decode merely _assumed_ that the image was straight alpha
going in.

The image "going in" and its parameters are described in pl_color_repr structure which includes alpha mode.

There is some parts of pipeline that expect pl_color_repr_encode/decode to act like the documentation states, so I'm wondering how we should proceed here.

Edited by Kacper Michajłow