Commit 4be9c7e7 authored by Niklas Haas's avatar Niklas Haas
Browse files

colorspace: improve/rewrite documentation of pl_color_repr_decode

The comments were egregiously outdated. Inverted conversions *are*
supported, and so are hue/sat adjustments for everything.
parent 9c8d0a21
Pipeline #85036 passed with stages
in 7 minutes and 50 seconds
...@@ -456,15 +456,12 @@ struct pl_matrix3x3 pl_get_cone_matrix(const struct pl_cone_params *params, ...@@ -456,15 +456,12 @@ struct pl_matrix3x3 pl_get_cone_matrix(const struct pl_cone_params *params,
const struct pl_raw_primaries *prim); const struct pl_raw_primaries *prim);
// Returns a color decoding matrix for a given combination of source color // Returns a color decoding matrix for a given combination of source color
// representation and adjustment parameters. This mutates the color_repr to // representation and adjustment parameters. This mutates `repr` to reflect the
// reflect the change. If `params` is left as NULL, it defaults to // change. If `params` is NULL, it defaults to &pl_color_adjustment_neutral.
// &pl_color_adjustment_neutral.
// //
// This function always performs a conversion to RGB; conversions from // This function always performs a conversion to RGB. To convert to other
// arbitrary color representations to other arbitrary other color // colorspaces (e.g. between YUV systems), obtain a second YUV->RGB matrix
// representations are currently not supported. Not all color systems support // and invert it using `pl_transform3x3_invert`.
// all of the color adjustment parameters. (In particular, hue/sat adjustments
// are currently only supported for YCbCr-like color systems)
// //
// Note: For BT.2020 constant-luminance, this outputs chroma information in the // Note: For BT.2020 constant-luminance, this outputs chroma information in the
// range [-0.5, 0.5]. Since the CL system conversion is non-linear, further // range [-0.5, 0.5]. Since the CL system conversion is non-linear, further
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment