libdvdnav issueshttps://code.videolan.org/videolan/libdvdnav/-/issues2022-05-08T17:19:51Zhttps://code.videolan.org/videolan/libdvdnav/-/issues/12Move buildsystem to meson2022-05-08T17:19:51ZJean-Baptiste KempfMove buildsystem to mesonSee $subjectSee $subject7.0.0https://code.videolan.org/videolan/libdvdnav/-/issues/21Expose VM2023-05-09T23:26:26ZDon MahurinExpose VMMany years ago, I created a modification to dvdbackup, called dvdbackupx, which uses the libdvdnav VM, to find the unused sectors, and skip them.
https://github.com/dmahurin/dvdbackup
https://bugs.launchpad.net/dvdbackup/+bug/648708
As...Many years ago, I created a modification to dvdbackup, called dvdbackupx, which uses the libdvdnav VM, to find the unused sectors, and skip them.
https://github.com/dmahurin/dvdbackup
https://bugs.launchpad.net/dvdbackup/+bug/648708
As the VM interface is still not exposed, this required a modified libdvdnav which exposed the internal VM interfaces.
https://github.com/dmahurin/libdvdnav
Recently, there was some interest in dvdbackupx,
https://github.com/dmahurin/dvdbackup/issues/1
But maintaining it is a challenge as it depends on libdvdnav internal interfaces.
Would the project be open to exposing the VM interface officially.
Then such a unused-sectors change could also possibly be an official feature of dvdbackup, and perhaps "dvdread" (unrelated to libdvdread) as well.https://code.videolan.org/videolan/libdvdnav/-/issues/20DVD .iso file Menu Freezes2022-12-21T17:16:43ZMauser69DVD .iso file Menu FreezesInitially reported as Kodi bug on Android, but the exact same issue is seen in VLC on Windows. I was advised to report it here.
Bug report
Describe the bug
Here is a clear and concise description of what the problem is:
Playback of D...Initially reported as Kodi bug on Android, but the exact same issue is seen in VLC on Windows. I was advised to report it here.
Bug report
Describe the bug
Here is a clear and concise description of what the problem is:
Playback of DVD .iso file for commercial DVD of 13 Ghosts. When the disc starts, the Main Menu has several options, including Play Movie, Scene Selections, Special Features, and Languages. If you try to select a Language, the Main Menu reappears, nothing is highlighted, and the menu seems frozen - the arrow and select buttons on the remote do nothing.
This is a bug because you cannot start the movie or go to any other menu option.
Expected Behavior
Here is a clear and concise description of what was expected to happen:
In a normal DVD player, when you select the Language option, and then select any language or subtitle, the Main Menu reappears with the Play Movie option still highlighted, and you can continue to move the focus up or down to other options or just start the movie.
Actual Behavior
Initially the Play Movie option is highlighted and you can use the up/down arrows to move the selection to any other item. If you go into Special Features and then return to the Main Menu, all is fine and you see the Play Movie option again highlighted - this is all fine and correct so far. The bug shows up if you go into either Language or Scene Selection and select a language (or even just go back to Main Menu), the Main Menu is displaydd, but no highlighted cursor selection and the entire UI for the menu is frozen. The background music continues to play, but pushing any arrow button or the OK button on the remote does nothing at all. At this point, the ONLY option is to press the back button to return to the Kodi file selection screen and then re-select the file for play, at which point the disc starts over.
Possible Fix
**The key to this problems seems to be that when returning to the Main Menu from either the Languages or Scene Selections sub-menus, there is no focus or highlighted option shown on the Main Menu, so nothing happens when you try to use the remote arrow buttons to navigate around the Main Menu.
I will note here that on my Windows computer, the VLC media player shows the exact same menu bug on this disc as Kodi does on my Android TV Box (no focus when returning to the Main Menu), BUT, this does not present a problem on the computer because using the mouse to move the cursor over any of the four Main Menu options brings up the focus highlight, and then the menu functions normally again using the arrow keys.
The significant difference is that on Android TV without a mouse, there is no way to move the non-existent cursor over one of the menu options to restore the focus, thus the entire Main Menu remains frozen.**
To Reproduce
Steps to reproduce the behavior:
Start the disc play from an .iso file (or probably even an attached DVD player)
Select Languages from the Main Menu
Return to the Main Menu and see that none of the four options are highlighted and the remote arrow and selection buttons do nothing at all.
Debuglog
The debuglog can be found here:
https://paste.kodi.tv/ikipevuxam.kodi
Screenshots
Here are some links or screenshots to help explain the problem:
Additional context or screenshots (if appropriate)
Here is some additional context or explanation that might help:
Note that this same .iso file plays the menus perfectly using an old Asus O!Play media player, so the problem is not a bug in the .iso copy.
Here are several other differences noted between normal menu operation on this disc and this bug:
When Languages is selected from the menu, the Languages screen NORMALLY shows nothing selected, and the "Main Menu" option at the bottom is highlighted (the option to return to the Main Menu screen). But with this bug, when the Languages screen comes up, the "Francais" Subtitles option is highlighted.
When you choose Scene Selections" from the Main Menu, the NORMAL initial focus on the Scene Selections screen is the "Start Movie" option, and if you instead choose "Main Menu" you are returned to the Main Menu with the Play Movie option highlighted. But with this bug, when the Scene Selections screen opens, the initial focus is on Scene 2, and if you instead choose "Main Menu" you are returned to the frozen main menu the same as happens if you go into the Languages screen.
NORMAL menu operation on this disc is that any time you return to the Main Menu from a sub-menu, the focus is on Play Movie (highlighted). But with this bug, that normal operation is only seen when you return from the Special Features sub-menu.
Your Environment
Used Operating system:
Android TV 11
No keyboard or mouse, just the Android TV Box remote.
VLC 3.5.3https://code.videolan.org/videolan/libdvdnav/-/issues/19DVD Read Error2022-06-08T13:59:32ZVLCFanDVD Read ErrorHi,
The DVD: Stargate SG-1, Season 7, Disc 1, Episode 1, Region 2
I have bought 2 different versions of this disc and it happens on both (One brand new, the other used). There are no issues when played in a DVD player.
When it gets to...Hi,
The DVD: Stargate SG-1, Season 7, Disc 1, Episode 1, Region 2
I have bought 2 different versions of this disc and it happens on both (One brand new, the other used). There are no issues when played in a DVD player.
When it gets to 3:26, playback stops, it is not possible to seek past that point for other playback.
VLC 3.0.16
Windows 10 (x64)
Windows Debug:
main debug: resampling stopped (drift: -3578 us)
dvdnav warning: cannot get next block (Expected NAV packet but none found.)
main debug: killing decoder fourcc `mpgv'
main debug: removing module "avcodec"
...
[File attached]
Same error happens in Handbrake - log also attached
[sg1fail.log](/uploads/021631a393246530fb96fa2b914c6711/sg1fail.log)
[sg1handbrake.txt](/uploads/90265e6c9d0313f78f94a6e522fa77ce/sg1handbrake.txt)https://code.videolan.org/videolan/libdvdnav/-/issues/18Better language selection?2021-06-19T04:22:27ZLyndon BrownBetter language selection?VLC's `menu-language`, `audio-language` and `spu-language` options were originally designed to take a fallback list of language choices, for instance "fr,en" meaning French if available, otherwise English if available. These are used wit...VLC's `menu-language`, `audio-language` and `spu-language` options were originally designed to take a fallback list of language choices, for instance "fr,en" meaning French if available, otherwise English if available. These are used with the `dvdnav_menu_language_select()`, `dvdnav_audio_language_select()` and `dvdnav_spu_language_select()` functions respectively, but these functions only take a single code and do not perform any check that the given code matches an available language on the disc, thus it is not possible to use the VLC fallback options as intended; only the first code can be supplied to DVDnav, hoping for the best.
Please forgive my lack of familiarity with DVDnav, but it would be helpful if DVDnav were able to actually verify the given code against the available disc languages and accept/reject the supplied code accordingly, such that VLC can step through the user's preference list to find the best match. Can this be done? (Or alternatively could DVDnav take a string with a list of codes, and find the best match itself at the appropriate time if that would work better?)
The same problem exists with libbluray. I'll wait for responses before filing a copy of the issue against that.https://code.videolan.org/videolan/libdvdnav/-/issues/17VLC asserts on opening menu of some DVD whereas VLC 0.9.4 is able.2022-06-08T14:26:02Zpat4vlcVLC asserts on opening menu of some DVD whereas VLC 0.9.4 is able.Hello all,
I can't open only one of my family DVD trees (or its iso image called v8pal_1 in the screen copy below) with VLC 2.1.5 Rincewind running on windows XP SP3 or win8.1 whereas it is OK with VLC 0.9.4 Grishenko on Win XP SP3 only....Hello all,
I can't open only one of my family DVD trees (or its iso image called v8pal_1 in the screen copy below) with VLC 2.1.5 Rincewind running on windows XP SP3 or win8.1 whereas it is OK with VLC 0.9.4 Grishenko on Win XP SP3 only. All others of my DVD images built with the same tool Magix Video such as v8pal_2.iso are successfully read on both environment. The runtime error occurs on opening the menu or VTS_ 01_0.VOB file of v8pal_1.iso for which VLC shows the message below, followed by the closing window message.
Do you know other cases where VLC 2.1.5 hangs on opening DVD menu whereas VLC 0.9.4 is able and why ?
Thank you for your help.
enclosed : the menu part only of the DVD involved with the runtime bug report (v8pal_1_bug_menu.zip).https://code.videolan.org/videolan/libdvdnav/-/issues/11Segfault in set_VTS_PTT2021-04-18T10:12:19ZJaume Delclòs CollSegfault in set_VTS_PTTThis is on VLC 3.0.8 with libdvdnav-6.0.1. I am trying to play a retail DVD published by Selecta Visión.
This is the normal output of the program:
```
> vlc /dev/sr0
VLC media player 3.0.8 Vetinari (revision 3.0.8-0-gf350b6b5a7)
[0000557...This is on VLC 3.0.8 with libdvdnav-6.0.1. I am trying to play a retail DVD published by Selecta Visión.
This is the normal output of the program:
```
> vlc /dev/sr0
VLC media player 3.0.8 Vetinari (revision 3.0.8-0-gf350b6b5a7)
[000055715b475b70] main xml reader error: XML reader not found
[000055715b474fe0] main audio output error: no suitable audio output module
[000055715b3033f0] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.
Remote control interface initialized. Type `help' for help.
libdvdnav: Using dvdnav version 6.0.1
libdvdnav: DVD Title: EVAN_DEATH
libdvdnav: DVD Serial Number: 3CB3699DAPPLEDSP
libdvdnav: DVD Title (Alternative): EVAN_DEATH
libdvdnav: DVD disk reports itself with Region mask 0x00fd0000. Regions: 2
libdvdread: Attempting to retrieve all CSS keys
libdvdread: This can take a _long_ time, please be patient
libdvdread: Get key for /VIDEO_TS/VIDEO_TS.VOB at 0x0000013f
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_01_0.VOB at 0x000001c0
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_01_1.VOB at 0x0000ec11
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_02_0.VOB at 0x0027435c
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_02_0.VOB (0x0027435c)
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_02_1.VOB at 0x002743a9
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_02_1.VOB (0x002743a9)!!
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_03_0.VOB at 0x00276a18
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_03_0.VOB (0x00276a18)
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_03_1.VOB at 0x00276a65
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_03_1.VOB (0x00276a65)!!
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_04_0.VOB at 0x002b6bd3
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_04_0.VOB (0x002b6bd3)
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_04_1.VOB at 0x002b6c20
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_04_1.VOB (0x002b6c20)!!
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_05_0.VOB at 0x002d37c0
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_05_0.VOB (0x002d37c0)
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_05_1.VOB at 0x002d380d
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_05_1.VOB (0x002d380d)!!
libdvdread: Elapsed time 0
libdvdread: Found 5 VTS's
libdvdread: Elapsed time 0
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdread: Can't seek to block 2573139
libdvdread: Can't seek to block 2573139
libdvdread: Invalid IFO for title 2 (VTS_02_0.IFO).
libdvdnav: ifoOpenVTSI failed
libdvdnav: DVD disk reports itself with Region mask 0x00fd0000. Regions: 2
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdnav: Language 'en' not found, using 'es' instead
libdvdnav: Menu Languages available: es
libdvdread: Can't seek to block 2573139
libdvdread: Can't seek to block 2573139
libdvdread: Invalid IFO for title 2 (VTS_02_0.IFO).
libdvdnav: ifoOpenVTSI failed
libdvdread: Can't seek to block 2573139
libdvdread: Can't seek to block 2573139
libdvdread: Can't seek to block 2573139
libdvdread: Can't seek to block 2583044
libdvdread: Can't seek to block 2583044
libdvdread: Can't seek to block 2583044
libdvdread: Invalid IFO for title 2 (VTS_02_0.BUP).
libdvdread: Can't seek to block 2583053
libdvdread: Can't seek to block 2583053
libdvdread: Can't seek to block 2583053
libdvdread: Can't seek to block 2845630
libdvdread: Can't seek to block 2845630
libdvdread: Can't seek to block 2845630
libdvdread: Invalid IFO for title 3 (VTS_03_0.BUP).
libdvdread: Can't seek to block 2845641
libdvdread: Can't seek to block 2845641
libdvdread: Can't seek to block 2845641
libdvdread: Can't seek to block 2963373
libdvdread: Can't seek to block 2963373
libdvdread: Can't seek to block 2963373
libdvdread: Invalid IFO for title 4 (VTS_04_0.BUP).
libdvdread: Can't seek to block 2963383
libdvdread: Can't seek to block 2963383
libdvdread: Can't seek to block 2963383
libdvdread: Can't seek to block 2995047
libdvdread: Can't seek to block 2995047
libdvdread: Can't seek to block 2995047
libdvdread: Invalid IFO for title 5 (VTS_05_0.BUP).
zsh: segmentation fault (core dumped) vlc /dev/sr0
```
Using gdb I have traced the crash to be in the 3rd call to [libdvdnav-6.0.1/src/vm/getset.c:65](https://code.videolan.org/videolan/libdvdnav/blob/ee4f6486d73ab54e7704b4fed2615a1bad76427f/src/vm/getset.c#L69)
```c
if ((vts_ttn < 1) || (vts_ttn > vm->vtsi->vts_ptt_srpt->nr_of_srpts) ||
(part < 1) || (part > vm->vtsi->vts_ptt_srpt->title[vts_ttn - 1].nr_of_ptts) ) {
return 0;
}
```
Specifically, vm->vtsi is a null pointer.
Both vtsN and (vm->state).vtsN are 1, which prevents the earlier branch from falling through.https://code.videolan.org/videolan/libdvdnav/-/issues/8dvdnav_get_title_string does not enforce charset2019-08-27T16:51:30ZFrançois Cartegniedvdnav_get_title_string does not enforce charsetAuthoring a DVD with k3b (mkisofs) with only UDF (disabling Joliet+RockRidge),
allows latin-1 characters into dvdnav_get_title_string() by setting the title using non ascii charsAuthoring a DVD with k3b (mkisofs) with only UDF (disabling Joliet+RockRidge),
allows latin-1 characters into dvdnav_get_title_string() by setting the title using non ascii charshttps://code.videolan.org/videolan/libdvdnav/-/issues/4Issue while changing chapter2020-03-05T12:31:33ZPierre LamotIssue while changing chapterThis can be reproduced with the DVD "Magic Knight Rayearth daybreak":
- start playing an episode
- during the intro generic press the next chapter button
- the program goes to EOS instead of the next chapter (beginning of the actual epi...This can be reproduced with the DVD "Magic Knight Rayearth daybreak":
- start playing an episode
- during the intro generic press the next chapter button
- the program goes to EOS instead of the next chapter (beginning of the actual episode)
If we wait till the end of the program, the next program is loaded correctly.
Using the next button:
```
libdvdnav: play_PGC_PG: (vm->state).pgcN (3)
libdvdnav: Registers before transaction
libdvdnav: # 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 |
libdvdnav: SRPMS: 656e|000f|003e|0001|0001|0001|0003|0003|0400|0000|0000|0000|5553|000f|0100|7cfc|656e|0000|656e|0000|0001|0000|0000|0000|
libdvdnav: GRPMS: 0000|0003|0001|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|
libdvdnav: Gmode: 0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|
libdvdnav: Gtime: 0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|
libdvdnav: Full list of commands to execute
(001) 30 08 00 00 01 87 00 00 | CallSS VTSM (menu 7, rsm_cell 1)
libdvdnav: --------------------------------------------
libdvdnav: Single stepping commands
(001) 30 08 00 00 01 87 00 00 | CallSS VTSM (menu 7, rsm_cell 1)
libdvdnav: Registers after transaction
libdvdnav: # 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 |
libdvdnav: SRPMS: 656e|000f|003e|0001|0001|0001|0003|0003|0400|0000|0000|0000|5553|000f|0100|7cfc|656e|0000|656e|0000|0001|0000|0000|0000|
libdvdnav: GRPMS: 0000|0003|0001|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|
libdvdnav: Gmode: 0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|
libdvdnav: Gtime: 0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|0000|
libdvdnav: eval: Doing Link/Jump/Call
libdvdnav: play_PG: (vm->state).pgN (1)
libdvdnav: play_Cell: (vm->state).cellN (1)
libdvdnav: ************ this chapter FOUND!
libdvdnav: VTS_PTT_SRPT - Title 1 part 3: PGC: 3 PG: 1
libdvdnav: Cell should restart here
libdvdnav: ************ this chapter FOUND!
libdvdnav: VTS_PTT_SRPT - Title 1 part 3: PGC: 3 PG: 1
libdvdnav: ************ this chapter FOUND!
libdvdnav: VTS_PTT_SRPT - Title 1 part 3: PGC: 3 PG: 1
libdvdnav: ************ this chapter FOUND!
libdvdnav: VTS_PTT_SRPT - Title 1 part 3: PGC: 3 PG: 1
libdvdnav: ************ this chapter FOUND!
libdvdnav: VTS_PTT_SRPT - Title 1 part 3: PGC: 3 PG: 1
[00007f9c3017e270] main decoder error: buffer deadlock prevented
[00007f9c301b1930] main decoder error: buffer deadlock prevented
libdvdnav: play_Cell_post: (vm->state).cellN (1)
libdvdnav: last cell in this PGC
libdvdnav: play_PGC_post:
libdvdnav: ** Fell of the end of the pgc, continuing in NextPGC
```https://code.videolan.org/videolan/libdvdnav/-/issues/2Fix for no-return-in-nonvoid-function from rpm lint2021-10-26T07:05:51ZsagibenFix for no-return-in-nonvoid-function from rpm lintHi,
I get this error from the rpm lint when trying to build Kodi for openSUSE.
More over, in case of 'Release' build the assert in the 'default' case is being ignored.
I've created the following pull request
https://github.com/xbmc/lib...Hi,
I get this error from the rpm lint when trying to build Kodi for openSUSE.
More over, in case of 'Release' build the assert in the 'default' case is being ignored.
I've created the following pull request
https://github.com/xbmc/libdvdnav/pull/2
and was suggested to push it here, but I can't fork the repo and create a pull request.
Thanks,
Sagi.